Skip to contentSkip to conversation

linux-next 20111214 - lib/Kconfig help text issue

DISCUSSION [email protected] 1 participant 1 message Dec 15, 2011

lore
Share & tools
lore
#0 lore raw

Seen in linux-next commit 7e8dec91 ( crypto: GnuPG based MPI lib - additional sources (part 4))

Quoted 8 lines
lib/Kconfig +0 -0
index 4af07ec..d411de5 100644
@@ -283,4 +283,14 @@ config MPILIB
          It is used to implement RSA digital signature verification,
          which is used by IMA/EVM digital signature extension.
 

lib/Kconfig config MPILIB · line 295

Quoted 10 lines
lib/Kconfig +10 -0
+config MPILIB_EXTRA
+       bool "Multiprecision maths library - additional sources"
+       depends on MPILIB
+       help
+         Multiprecision maths library from GnuPG.
+         It is used to implement RSA digital signature verification,
+         which is used by IMA/EVM digital signature extension.
+         This code in unnecessary for RSA digital signature verification,
+         and can be compiled if needed.
+

Two issues:

1) Typo - "this code in unnecessary" should be "this code is"

2) The help file says "It is used to implement verification", and then 2 lines later it says "this code is unnesessary for verification". So is it implementing it, or not needed for it? (I suspect it's a bad cut-n-paste from the previous section, and needs 2 lines deleted, to look like this:

+ help

+         Multiprecision maths library from GnuPG.
+         This code in unnecessary for RSA digital signature verification,
+         and can be compiled if needed.