Skip to contentSkip to conversation

Device Driver Etiquette

DISCUSSION Matt Fredrickson 2 participants 2 messages Jun 2, 2007 – Jun 3, 2007 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 10 lines · ----- "Daniel J Blueman
Quoted 4 lines · Lee Revell
Quoted 2 lines · Matthew Fredrickson

is it acceptable (although
not nice) to simply fix it this way, by disabling irqs while it

loads

Quoted 3 lines
Quoted 1 line

the firmware?

I would say to just disable IRQs while loading firmware. Almost

every

Quoted 8 lines
Quoted 1 line

server I maintain has some vendor driver which generates a "many

lost

Quoted 2 lines

ticks!" message on load. As long as it's only done at module load time it should be fine.

For anything ~10s or more, you'll probably also need to call the timer
update function to prevent soft lockup warning being generated.

Ahhh... so there is a way to get rid of that cursed message. I forgot to mention this in my original message, the only place that I had seen this problem is on a certain machine (Dell 2950) with a certain distribution (FC6) kernel. I had trimmed the code down to fit in 4K stacks already quite a bit.

I believe what actually made it crash and overflow the stack (the straw that breaks the camels back, so to speak) was the intermittent triggering of the softlockup detector. I think if I can disable that while the firmware is loading that will fix the stack overflow issues and correct my problem.

Matthew Fredrickson

#2 lore raw
Quoted 20 lines · Matt Fredrickson
Quoted 10 lines · ----- "Daniel J Blueman
Quoted 4 lines · Lee Revell
Quoted 2 lines · Matthew Fredrickson

is it acceptable (although
not nice) to simply fix it this way, by disabling irqs while it

loads

Quoted 3 lines
Quoted 1 line

the firmware?

I would say to just disable IRQs while loading firmware. Almost

every

Quoted 8 lines
Quoted 1 line

server I maintain has some vendor driver which generates a "many

lost

Quoted 2 lines

ticks!" message on load. As long as it's only done at module load time it should be fine.

For anything ~10s or more, you'll probably also need to call the timer
update function to prevent soft lockup warning being generated.

Quoted 6 lines

Ahhh... so there is a way to get rid of that cursed message. I forgot to mention this in my original message, the only place that I had seen this problem is on a certain machine (Dell 2950) with a certain distribution (FC6) kernel. I had trimmed the code down to fit in 4K stacks already quite a bit.

I believe what actually made it crash and overflow the stack (the straw that breaks the camels back, so to speak) was the intermittent triggering of the softlockup detector.
I think if I can disable that while the firmware is loading that will fix the stack overflow
issues and correct my problem.

It may not help, since the NMIs used to detect soft lockups will still be received; the soft lockup update call just updates the per-cpu timer, but there may be less chance of overrunning the end of the stack from not getting the stack trace.

There is no substitute for implementing your own firmware uploading mechanism or getting this one addressed though ;-) .

Dan

Quoted 1 line

Matthew Fredrickson

Signature · 1 line
Daniel J Blueman