ASoC: Remove use of hw_read from TLV320AIC3x driver
Subsystems (3)
PATCH 1/1 ASoC: Remove use of hw_read from TLV320AIC3x driver
The TLV320AIC3x driver is currently the only user of the CODEC hw_read operation and is jumping through some hoops in order to do so. In order to support future refactoring to make the hw_read operation more usable unwrap the usage in this driver to avoid its use.
Signed-off-by Mark Brown <[email protected]>
---
I don't have any hardware I can test this on so it'd be good if someone with suitable hardware could give it a spin. Daniel, you wrote the code that does the readbacks so I guess you're most likely to have a good test setup for this?
sound/soc/codecs/tlv320aic3x.c | 11 ++--------- 1 files changed, 2 insertions(+), 9 deletions(-)
sound/soc/codecs/tlv320aic3x.c +2 -9
@@ -145,8 +145,8 @@ static int aic3x_read(struct snd_soc_codec *codec, unsigned int reg, u8 *value) { *value = reg &0xff ; -if (codec->hw_read (codec->control_data, value,1 ) !=1 ) -return -EIO ; + + value[0 ] =i2c_smbus_read_byte_data (codec->control_data, value[0 ]);aic3x_write_reg_cache (codec, reg, *value);return 0 ;
@@ -1316,12 +1316,6 @@ static struct i2c_driver aic3x_i2c_driver = { .id_table = aic3x_i2c_id, }; -static int aic3x_i2c_read (struct i2c_client *client,u8 *value,int len) -{ - value[0 ] =i2c_smbus_read_byte_data (client, value[0 ]); -return (len ==1 ); -} -static int aic3x_add_i2c_device (struct platform_device *pdev,const struct aic3x_setup_data *setup) {
@@ -1394,7 +1388,6 @@ static int aic3x_probe(struct platform_device *pdev)#if defined(CONFIG_I2C ) || defined(CONFIG_I2C_MODULE )if (setup->i2c_address) { codec->hw_write = (hw_write_t ) i2c_master_send; - codec->hw_read = (hw_read_t ) aic3x_i2c_read; ret =aic3x_add_i2c_device (pdev, setup); }#else
Signature · 1 line
1.6.3.3