Skip to contentSkip to conversation

vmalloc.c: fix vmap_page_range() return

PATCH In review Figo.zhang 1 participant 2 messages Jul 7, 2009

Subsystems (2)
lore
Share & tools
lore

Figo.zhang

author
#0 lore raw

PATCH 1/1 vmalloc.c: fix vmap_page_range() return

vmap_page_range() would never return a positive number.

---
mm/vmalloc.c | 4 ----

 1 files changed, 0 insertions(+), 4 deletions(-)
mm/vmalloc.c +0 -4
index f8189a4..bbd312d 100644
@@ -1109,10 +1109,6 @@ int map_vm_area(struct vm_struct *area, pgprot_t prot, struct page ***pages)
 	int err;
 
 	err = vmap_page_range(addr, end, prot, *pages);
-	if (err > 0) {
-		*pages += err;
-		err = 0;
-	}
 
 	return err;
 }
author
#1 lore raw
Quoted 1 line · Figo.zhang

vmap_page_range() would never return a positive number.

hmm, it is my mistake. vmap_pud_range() will return the succeed mapped page number.

Best,
Figo.zhang

Quoted 22 lines

---
mm/vmalloc.c | 4 ----

 1 files changed, 0 insertions(+), 4 deletions(-)
mm/vmalloc.c +0 -4
index f8189a4..bbd312d 100644
@@ -1109,10 +1109,6 @@ int map_vm_area(struct vm_struct *area, pgprot_t prot, struct page ***pages)
 	int err;
 
 	err = vmap_page_range(addr, end, prot, *pages);
-	if (err > 0) {
-		*pages += err;
-		err = 0;
-	}
 
 	return err;
 }