sound/soc/codecs/wm9081.c compiler warning
Subsystems (3)
I am getting this compiler warning in linus tree:
CC [M] sound/soc/codecs/wm9081.osound/soc/codecs/wm9081.c: In function ‘configure_clock’:sound/soc/codecs/wm9081.c:674: warning: ‘new_sysclk’ may be used uninitialized in this function
This fixes the warning in my case, hope this will be helpful :
sound/soc/codecs/wm9081.c +1 -2
@@ -696,6 +696,7 @@ static int configure_clock(struct snd_soc_codec *codec)* not the case, though care must be taken with free * running mode. */ + new_sysclk =12288000 ;if (wm9081->master && wm9081->bclk) {/* Make sure we can generate CLK_SYS and BCLK * and that we've got 3MHz for optimal
@@ -714,8 +715,6 @@ static int configure_clock(struct snd_soc_codec *codec)if (new_sysclk >3000000 )break ; } - }else { - new_sysclk =12288000 ; } ret = wm9081_set_fll(codec, WM9081_SYSCLK_FLL_MCLK,
--
JSR
At Wed, 15 Jul 2009 12:00:34 +0530,
Quoted 8 lines · Jaswinder Singh Rajput
I am getting this compiler warning in linus tree:
CC [M]
sound/soc/codecs/wm9081.osound/soc/codecs/wm9081.c: In function ‘configure_clock’:sound/soc/codecs/wm9081.c:674: warning: ‘new_sysclk’ may be used uninitialized in this functionThis fixes the warning in my case, hope this will be helpful :
I think your fix is OK, but I let it to Mark :)
thanks,
Takashi
Quoted 26 lines
sound/soc/codecs/wm9081.c +1
-3@@ -696,6 +696,7 @@ static int configure_clock(struct snd_soc_codec *codec)* not the case, though care must be taken with free * running mode. */ + new_sysclk =12288000 ;if (wm9081->master && wm9081->bclk) {/* Make sure we can generate CLK_SYS and BCLK * and that we've got 3MHz for optimal @@ -714,8 +715,6 @@ static int configure_clock(struct snd_soc_codec *codec)if (new_sysclk >3000000 )break ; } - }else { - new_sysclk =12288000 ; } ret = wm9081_set_fll(codec, WM9081_SYSCLK_FLL_MCLK, --JSR
Quoted 5 lines · Takashi Iwai
At Wed, 15 Jul 2009 12:00:34 +0530,
Quoted 1 line · Jaswinder Singh Rajput
I am getting this compiler warning in linus tree:
Quoted 7 lines
Quoted 5 lines
CC [M]
sound/soc/codecs/wm9081.osound/soc/codecs/wm9081.c: In function ‘configure_clock’:sound/soc/codecs/wm9081.c:674: warning: ‘new_sysclk’ may be used uninitialized in this functionThis fixes the warning in my case, hope this will be helpful :
I think your fix is OK, but I let it to Mark :)
I'm just looking at this at the minute. I'm trying to decide if it should take that approach or error out if it can't find a configuration.
Again, I'm not seeing the warning itself - compiler versions would be useful in warning reports (particularly for control flow analysis stuff like this).
Quoted 5 lines · Jaswinder Singh Rajput
CC [M]
sound/soc/codecs/wm9081.osound/soc/codecs/wm9081.c: In function ‘configure_clock’:sound/soc/codecs/wm9081.c:674: warning: ‘new_sysclk’ may be used uninitialized in this functionThis fixes the warning in my case, hope this will be helpful :
I've pushed an alternative patch which hopefully fixes this (none of my compilers appear to generate the warning so I can't check that the warning is gone).