drivers/isdn/hardware/mISDN/hfcpci.c compiler warning seems like a BUG
I am getting this compiler warning in linus tree :
CC [M] drivers/isdn/hardware/mISDN/hfcpci.odrivers/isdn/hardware/mISDN/hfcpci.c: In function ‘hfcpci_softirq’:drivers/isdn/hardware/mISDN/hfcpci.c:2333: warning: ignoring return value of ‘driver_for_each_device’, declared with attribute warn_unused_result
static voidhfcpci_softirq(void *arg)
{
(void) driver_for_each_device(&hfc_driver.driver, NULL, arg,
_hfcpci_softirq);
/* if next event would be in the past ... */
if ((s32)(hfc_jiffies + tics - jiffies) <= 0)
hfc_jiffies = jiffies + 1;
else
hfc_jiffies += tics;
hfc_tl.expires = hfc_jiffies;
add_timer(&hfc_tl);
}It seems to me it should return is driver_for_each_device fails :
if (driver_for_each_device(&hfc_driver.driver, NULL, arg,
_hfcpci_softirq))
return;
or if possible can we return this error code for hfcpci_softirq()
Thanks,
--
JSR
Quoted 21 lines · Jaswinder Singh Rajput
I am getting this compiler warning in linus tree :
CC [M]
drivers/isdn/hardware/mISDN/hfcpci.odrivers/isdn/hardware/mISDN/hfcpci.c: In function ‘hfcpci_softirq’:drivers/isdn/hardware/mISDN/hfcpci.c:2333: warning: ignoring return value of ‘driver_for_each_device’, declared with attributewarn_unused_resultstatic void
hfcpci_softirq(void *arg){ (void) driver_for_each_device(&hfc_driver.driver, NULL, arg, _hfcpci_softirq); /* if next event would be in the past ... */ if ((s32)(hfc_jiffies + tics - jiffies) <= 0) hfc_jiffies = jiffies + 1; else hfc_jiffies += tics; hfc_tl.expires = hfc_jiffies; add_timer(&hfc_tl); }
Quoted 4 lines
It seems to me it should return is
driver_for_each_devicefails :
if (driver_for_each_device(&hfc_driver.driver, NULL, arg,
_hfcpci_softirq))
return;
Without looking deeper into it (I'm on a trip with limited net access), this sounds resonable for me, I will have a closer look next week.
Quoted 13 lines
or if possible can we return this error code for
hfcpci_softirq()Thanks,
--
JSR--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/