Skip to contentSkip to conversation

add flag IRQF_NO_SUSPEND in 'struct irqaction'

PATCH Rafael J. Wysocki 3 participants 5 messages Jul 17, 2009 – Jul 20, 2009 1 message not in the archive Xen hypervisor interface

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 4 lines · Guanqun Lu

We currently only bypass IRQF_TIMER in '__disable_irq', but Xen specific IRQs should not be disabled either. This commit adds a new flag to accompolish this goal without being mixed up with IRQF_TIMER flag.

For some obscure reasons [2/3] didn't reach my inbox. The other 2 patches look fine to me.

Best,
Rafael

Quoted 32 lines
---
 include/linux/interrupt.h |    1 +
 kernel/irq/manage.c       |    3 ++-
 2 files changed, 3 insertions(+), 1 deletions(-)
include/linux/interrupt.h +1 -0
index 2721f07..99264c3 100644
@@ -58,6 +58,7 @@
 #define IRQF_PERCPU		0x00000400
 #define IRQF_NOBALANCING	0x00000800
 #define IRQF_IRQPOLL		0x00001000
+#define IRQF_NO_SUSPEND		0x00002000
 
 /*
  * Bits used by threaded handlers:
kernel/irq/manage.c +2 -1
index 50da676..3dc4e74 100644
@@ -192,7 +192,8 @@ static inline int setup_affinity(unsigned int irq, struct irq_desc *desc)
 void __disable_irq(struct irq_desc *desc, unsigned int irq, bool suspend)
 {
 	if (suspend) {
-		if (!desc->action || (desc->action->flags & IRQF_TIMER))
+		if (!desc->action ||
+		    (desc->action->flags & (IRQF_TIMER | IRQF_NO_SUSPEND)))
 			return;
 		desc->status |= IRQ_SUSPENDED;
 	}
#2 lore raw
Quoted 7 lines

-----Original Message-----
From: Rafael J. Wysocki [mailto:[email protected]]
Sent: Friday, July 17, 2009 9:52 AM
To: Lu, Guanqun
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 1/3] add flag IRQF_NO_SUSPEND in 'struct irqaction'

Quoted 8 lines
Quoted 4 lines · Guanqun Lu

We currently only bypass IRQF_TIMER in '__disable_irq', but Xen specific IRQs should not be disabled either. This commit adds a new flag to accompolish this goal without being mixed up with IRQF_TIMER flag.

For some obscure reasons [2/3] didn't reach my inbox. The other 2 patches look fine to me.

I'm sending patch [2/3] via attachment in case it's lost accidentally by git-send-email again. Sorry for the inconvenience it may cause.

Guanqun

Quoted 29 lines

Best,
Rafael

kernel/irq/manage.c static inline int setup_affinity(unsigned int irq, struct irq_desc

Quoted 23 lines
---
 include/linux/interrupt.h |    1 +
 kernel/irq/manage.c       |    3 ++-
 2 files changed, 3 insertions(+), 1 deletions(-)
include/linux/interrupt.h +1 -0
index 2721f07..99264c3 100644
@@ -58,6 +58,7 @@
 #define IRQF_PERCPU		0x00000400
 #define IRQF_NOBALANCING	0x00000800
 #define IRQF_IRQPOLL		0x00001000
+#define IRQF_NO_SUSPEND		0x00002000
 
 /*
  * Bits used by threaded handlers:
kernel/irq/manage.c +0 -0
index 50da676..3dc4e74 100644
@@ -192,7 +192,8 @@ static inline int setup_affinity(unsigned int irq, struct irq_desc

*desc)

Quoted 9 lines

kernel/irq/manage.c static inline int setup_affinity(unsigned int irq, struct irq_desc · line 199

Quoted 9 lines
kernel/irq/manage.c +2 -1
 void __disable_irq(struct irq_desc *desc, unsigned int irq, bool suspend)
 {
 	if (suspend) {
-		if (!desc->action || (desc->action->flags & IRQF_TIMER))
+		if (!desc->action ||
+		    (desc->action->flags & (IRQF_TIMER | IRQF_NO_SUSPEND)))
 			return;
 		desc->status |= IRQ_SUSPENDED;
 	}

From fcd8a32c16d509270ef90069b92dadc506ce49ea Mon Sep 17 00:00:00 2001
From: Guanqun Lu <[email protected]>
Date: Tue, 14 Jul 2009 05:15:12 -0400
Subject: [PATCH 2/3] add IRQF_NO_SUSPEND for 'bind_ipi_to_irqhandler'

This function exports the ipi functionality to kernel, and the corresponding irq should not be disabled during host S3 suspend.

---
 drivers/xen/events.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/xen/events.c +1 -0
index abad71b..f0647bd 100644
@@ -532,6 +532,7 @@ int bind_ipi_to_irqhandler(enum ipi_vector ipi,
 	if (irq < 0)
 		return irq;
 
+	irqflags |= IRQF_NO_SUSPEND;
 	retval = request_irq(irq, handler, irqflags, devname, dev_id);
 	if (retval != 0) {
 		unbind_from_irq(irq);
Signature · 1 line
1.6.1.rc3
#3 lore raw
Quoted 13 lines · Guanqun
Quoted 13 lines

-----Original Message-----
From: Rafael J. Wysocki [mailto:[email protected]]
Sent: Friday, July 17, 2009 9:52 AM
To: Lu, Guanqun
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 1/3] add flag IRQF_NO_SUSPEND in 'struct irqaction'

Quoted 4 lines · Guanqun Lu

We currently only bypass IRQF_TIMER in '__disable_irq', but Xen specific IRQs should not be disabled either. This commit adds a new flag to accompolish this goal without being mixed up with IRQF_TIMER flag.

Quoted 5 lines
Quoted 2 lines

For some obscure reasons [2/3] didn't reach my inbox. The other 2 patches look fine to me.

I'm sending patch [2/3] via attachment in case it's lost accidentally by git-send-email again. Sorry for the inconvenience it may cause.

Thanks, patch looks OK to me.

Best,
Rafael

Quoted 33 lines
Quoted 33 lines

kernel/irq/manage.c static inline int setup_affinity(unsigned int irq, struct irq_desc

Quoted 23 lines
---
 include/linux/interrupt.h |    1 +
 kernel/irq/manage.c       |    3 ++-
 2 files changed, 3 insertions(+), 1 deletions(-)
include/linux/interrupt.h +1 -0
index 2721f07..99264c3 100644
@@ -58,6 +58,7 @@
 #define IRQF_PERCPU		0x00000400
 #define IRQF_NOBALANCING	0x00000800
 #define IRQF_IRQPOLL		0x00001000
+#define IRQF_NO_SUSPEND		0x00002000
 
 /*
  * Bits used by threaded handlers:
kernel/irq/manage.c +0 -0
index 50da676..3dc4e74 100644
@@ -192,7 +192,8 @@ static inline int setup_affinity(unsigned int irq, struct irq_desc

*desc)

Quoted 9 lines
kernel/irq/manage.c +2 -1
 void __disable_irq(struct irq_desc *desc, unsigned int irq, bool suspend)
 {
 	if (suspend) {
-		if (!desc->action || (desc->action->flags & IRQF_TIMER))
+		if (!desc->action ||
+		    (desc->action->flags & (IRQF_TIMER | IRQF_NO_SUSPEND)))
 			return;
 		desc->status |= IRQ_SUSPENDED;
 	}
#4 lore raw
In reply to Rafael J. Wysocki
Quoted 8 lines · Rafael J. Wysocki
Quoted 4 lines · Guanqun Lu

We currently only bypass IRQF_TIMER in '__disable_irq', but Xen specific IRQs should not be disabled either. This commit adds a new flag to accompolish this goal without being mixed up with IRQF_TIMER flag.

For some obscure reasons [2/3] didn't reach my inbox. The other 2 patches look fine to me.

I do not receive the patches at all. Can you please resend and cc me ?

Thanks,

tglx

#5 lore raw
Quoted 15 lines

-----Original Message-----
From: Thomas Gleixner [mailto:[email protected]]
Sent: Friday, July 17, 2009 10:18 PM
To: Rafael J. Wysocki
Cc: Lu, Guanqun; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 1/3] add flag IRQF_NO_SUSPEND in 'struct irqaction'

Quoted 6 lines · Rafael J. Wysocki
Quoted 4 lines · Guanqun Lu

We currently only bypass IRQF_TIMER in '__disable_irq', but Xen specific IRQs should not be disabled either. This commit adds a new flag to accompolish this goal without being mixed up with IRQF_TIMER flag.

Quoted 4 lines
Quoted 2 lines

For some obscure reasons [2/3] didn't reach my inbox. The other 2 patches look fine to me.

I do not receive the patches at all. Can you please resend and cc me ?

Resent now, let me know it doesn't get to your inbox again.

Guanqun

Quoted 4 lines

Thanks,

tglx