vc: create vcs(a) devices for consoles
From: Kay Sievers <[email protected]>
Subject: vc: create vcs(a) devices for consoles
The buffer for the consoles are unconditionally allocated at con_init() time, which miss the creation of the vcs(a) devices.
Since 2.6.30, these devices are no longer created at open() and removed on close(), but controlled by the lifetime of the buffers.
---
drivers/char/vc_screen.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/char/vc_screen.c +4 -0
@@ -495,11 +495,15 @@ void vcs_remove_sysfs(int index)int __init vcs_init (void ) { +unsigned int i; +if (register_chrdev (VCS_MAJOR ,"vcs" , &vcs_fops))panic ("unable to get major %d for vcs device" ,VCS_MAJOR ); vc_class =class_create (THIS_MODULE ,"vc" );device_create (vc_class,NULL ,MKDEV (VCS_MAJOR ,0 ),NULL ,"vcs" );device_create (vc_class,NULL ,MKDEV (VCS_MAJOR ,128 ),NULL ,"vcsa" ); +for (i =0 ; i <MIN_NR_CONSOLES ; i++) +vcs_make_sysfs (i);return 0 ; }
Quoted 9 lines · Kay Sievers
From: Kay Sievers <[email protected]>
Subject: vc: create vcs(a) devices for consolesThe buffer for the consoles are unconditionally allocated at
con_init()time, which miss the creation of the vcs(a) devices.Since 2.6.30, these devices are no longer created at
open()and removed onclose(), but controlled by the lifetime of the buffers.
Is this a bug in .31-rc right now? Should this make it into the final .31 release?
And what caused this change, tty changes? If so, it should go through Alan Cox's tree.
thanks,
greg k-h
Quoted 7 lines · Greg KH
Quoted 6 lines · Kay Sievers
From: Kay Sievers <[email protected]>
Subject: vc: create vcs(a) devices for consolesThe buffer for the consoles are unconditionally allocated at
con_init()time, which miss the creation of the vcs(a) devices.
Quoted 6 lines
Quoted 3 lines
Since 2.6.30, these devices are no longer created at
open()and removed onclose(), but controlled by the lifetime of the buffers.Is this a bug in .31-rc right now? Should this make it into the final .31 release?
Yes, and in .30.
Quoted 2 lines
And what caused this change, tty changes? If so, it should go through Alan Cox's tree.
This change caused it:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4995f8ef9d3aac72745e12419d7fbaa8d01b1d81
Thanks,
Kay
Quoted 8 lines · Kay Sievers, le Sat 18 Jul 2009 18:12:20 +0200, a écrit :
Quoted 7 lines · Greg KH
Quoted 6 lines · Kay Sievers
From: Kay Sievers <[email protected]>
Subject: vc: create vcs(a) devices for consolesThe buffer for the consoles are unconditionally allocated at
con_init()time, which miss the creation of the vcs(a) devices.
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Since 2.6.30, these devices are no longer created at
open()and removed onclose(), but controlled by the lifetime of the buffers.Is this a bug in .31-rc right now? Should this make it into the final .31 release?
Yes, and in .30.
Please also push it to [email protected] The bug makes the console unusable e.g. for blind users using braille devices.
Samuel
Quoted 13 lines · Samuel Thibault
Quoted 12 lines · Kay Sievers, le Sat 18 Jul 2009 18:12:20 +0200, a écrit :
Quoted 11 lines · Greg KH
Quoted 9 lines · Kay Sievers
From: Kay Sievers <[email protected]>
Subject: vc: create vcs(a) devices for consolesThe buffer for the consoles are unconditionally allocated at
con_init()time, which miss the creation of the vcs(a) devices.Since 2.6.30, these devices are no longer created at
open()and removed onclose(), but controlled by the lifetime of the buffers.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Is this a bug in .31-rc right now? Should this make it into the final .31 release?
Yes, and in .30.
Please also push it to [email protected] The bug makes the console unusable e.g. for blind users using braille devices.
... as well as blind developers as myself. Thanks for fixing this.
Nicolas
Quoted 15 lines · Kay Sievers
Quoted 7 lines · Greg KH
Quoted 6 lines · Kay Sievers
From: Kay Sievers <[email protected]>
Subject: vc: create vcs(a) devices for consolesThe buffer for the consoles are unconditionally allocated at
con_init()time, which miss the creation of the vcs(a) devices.Quoted 6 lines
Quoted 3 lines
Since 2.6.30, these devices are no longer created at
open()and removed onclose(), but controlled by the lifetime of the buffers.Is this a bug in .31-rc right now? Should this make it into the final .31 release?
Quoted 7 lines
Yes, and in .30.
Quoted 2 lines
And what caused this change, tty changes? If so, it should go through Alan Cox's tree.
This change caused it:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4995f8ef9d3aac72745e12419d7fbaa8d01b1d81
Ah, ok, I will queue it up.
thanks,
greg k-h