ACPICA Release 20090730 linuxized patches

DISCUSSION Applied Lin Ming 2 participants 7 messages Aug 14, 2009 – Aug 28, 2009

Subsystems (2)

ACPI ACPI component architecture (acpica)

lore

Share & tools

lore

Lin Ming

author

2009-08-14 02:01 UTC #0 lore raw

Hi, Len

ACPICA Release 20090730 linuxized patches attached. Build&Test on 32&64 bit machines.

Applied cleanly on top of linux-acpi-2.6/test branch.

Lin Ming
---
[PATCH 01/13] ACPICA: Move predefined repair code to new file, no functional change [PATCH 02/13] ACPICA: Add repair for predefined methods that return nested packages [PATCH 03/13] ACPICA: ACPI 4.0 : Add new return package type, restructure module. [PATCH 04/13] ACPICA: Fix fault if acpi_terminate is called twice [PATCH 05/13] ACPICA: Split large ACPI table header
[PATCH 06/13] ACPICA: ACPI 4: Update headers for new and changed ACPI tables. [PATCH 07/13] ACPICA: reformat predefined method table, no functional change [PATCH 08/13] ACPICA: ACPI 4: Add validation for new predefined names. [PATCH 09/13] ACPICA: Add support for module-level executable AML code [PATCH 10/13] ACPICA: Update definitions for HEST table
[PATCH 11/13] ACPICA: Fix typo for HEST ACPI table
[PATCH 12/13] ACPICA: acpi_reset: Bypass port validation mechanism [PATCH 13/13] ACPICA: Update version to 20090730

Len Brown

reviewer

2009-08-15 03:31 UTC #1 lore raw

Quoted 7 lines · Lin Ming

Hi, Len
ACPICA Release 20090730 linuxized patches attached. Build&Test on 32&64 bit machines.
Applied cleanly on top of linux-acpi-2.6/test branch.

Quoted 15 lines

Lin Ming
---
[PATCH 01/13] ACPICA: Move predefined repair code to new file, no functional change [PATCH 02/13] ACPICA: Add repair for predefined methods that return nested packages [PATCH 03/13] ACPICA: ACPI 4.0 : Add new return package type, restructure module. [PATCH 04/13] ACPICA: Fix fault if acpi_terminate is called twice [PATCH 05/13] ACPICA: Split large ACPI table header
[PATCH 06/13] ACPICA: ACPI 4: Update headers for new and changed ACPI tables. [PATCH 07/13] ACPICA: reformat predefined method table, no functional change [PATCH 08/13] ACPICA: ACPI 4: Add validation for new predefined names. [PATCH 09/13] ACPICA: Add support for module-level executable AML code [PATCH 10/13] ACPICA: Update definitions for HEST table
[PATCH 11/13] ACPICA: Fix typo for HEST ACPI table
[PATCH 12/13] ACPICA: acpi_reset: Bypass port validation mechanism [PATCH 13/13] ACPICA: Update version to 20090730

thanks for the port, Lin-Ming.

checkpatch.pl, as usual, is not happy:

total: 389 errors, 103 warnings, 4771 lines checked

someday we need to address these formatting issues...

thanks,
Len Brown, Intel Open Source Technology Center

Lin Ming

author

2009-08-17 01:45 UTC #2 lore raw

Quoted 25 lines · Len Brown

Quoted 7 lines · Lin Ming
Hi, Len
ACPICA Release 20090730 linuxized patches attached. Build&Test on 32&64 bit machines.
Applied cleanly on top of linux-acpi-2.6/test branch.
Quoted 15 lines
Lin Ming
---
[PATCH 01/13] ACPICA: Move predefined repair code to new file, no functional change [PATCH 02/13] ACPICA: Add repair for predefined methods that return nested packages [PATCH 03/13] ACPICA: ACPI 4.0 : Add new return package type, restructure module. [PATCH 04/13] ACPICA: Fix fault if acpi_terminate is called twice [PATCH 05/13] ACPICA: Split large ACPI table header
[PATCH 06/13] ACPICA: ACPI 4: Update headers for new and changed ACPI tables. [PATCH 07/13] ACPICA: reformat predefined method table, no functional change [PATCH 08/13] ACPICA: ACPI 4: Add validation for new predefined names. [PATCH 09/13] ACPICA: Add support for module-level executable AML code [PATCH 10/13] ACPICA: Update definitions for HEST table
[PATCH 11/13] ACPICA: Fix typo for HEST ACPI table
[PATCH 12/13] ACPICA: acpi_reset: Bypass port validation mechanism [PATCH 13/13] ACPICA: Update version to 20090730

Quoted 5 lines

thanks for the port, Lin-Ming.
checkpatch.pl, as usual, is not happy:
total: 389 errors, 103 warnings, 4771 lines checked

$checkpatch.pl acpica-v20090730.mbox | grep "ERROR:" | sort | uniq
ERROR: return is not a function, parentheses are not required
ERROR: space required after that close brace '}'
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '?' (ctx:VxE)

I think we don't need to fix these errors in order to decrease the gap between ACPICA and linux-acpica code.

Quoted 2 lines

someday we need to address these formatting issues...

We need to document which error(s) need to be fixed. Currently, only two errors are fixed.

ERROR: trailing whitespace
ERROR: code indent should use tabs where possible

Lin Ming

Quoted 5 lines

thanks,
Len Brown, Intel Open Source Technology Center

Len Brown

reviewer

2009-08-15 03:33 UTC #3 lore raw

In reply to Lin Ming

Quoted 4 lines · Lin Ming

Hi, Len
ACPICA Release 20090730 linuxized patches attached. Build&Test on 32&64 bit machines.

please build with CONFIG_DMAR=y

CC drivers/pci/dmar.o
drivers/pci/dmar.c: In function ‘dmar_parse_one_dev_scope’:
drivers/pci/dmar.c:87: error: ‘struct acpi_dmar_pci_path’ has no member named ‘dev’
drivers/pci/dmar.c:87: error: ‘struct acpi_dmar_pci_path’ has no member named ‘fn’
drivers/pci/dmar.c:91: error: ‘struct acpi_dmar_pci_path’ has no member named ‘dev’
drivers/pci/dmar.c:91: error: ‘struct acpi_dmar_pci_path’ has no member named ‘fn’
drivers/pci/dmar.c:101: error: ‘struct acpi_dmar_pci_path’ has no member named ‘dev’
drivers/pci/dmar.c:101: error: ‘struct acpi_dmar_pci_path’ has no member named ‘fn’

Lin Ming

author

2009-08-17 02:11 UTC #4 lore raw

Quoted 8 lines · Len Brown

Quoted 4 lines · Lin Ming
Hi, Len
ACPICA Release 20090730 linuxized patches attached. Build&Test on 32&64 bit machines.
please build with CONFIG_DMAR=y

Fix dmar build error.
Now build OK with "make allyesconfig"

include/acpi/actbl2.h +2 -2

index 674e27b..6f3dce9 100644
@@ -252,8 +252,8 @@ enum acpi_dmar_scope_type {
 };
 
 struct acpi_dmar_pci_path {
-	u8 device;
-	u8 function;
+	u8 dev;
+	u8 fn;
 };
 
 /*

Quoted 15 lines

CC drivers/pci/dmar.o
drivers/pci/dmar.c: In function ‘dmar_parse_one_dev_scope’:
drivers/pci/dmar.c:87: error: ‘struct acpi_dmar_pci_path’ has no member named ‘dev’
drivers/pci/dmar.c:87: error: ‘struct acpi_dmar_pci_path’ has no member named ‘fn’
drivers/pci/dmar.c:91: error: ‘struct acpi_dmar_pci_path’ has no member named ‘dev’
drivers/pci/dmar.c:91: error: ‘struct acpi_dmar_pci_path’ has no member named ‘fn’
drivers/pci/dmar.c:101: error: ‘struct acpi_dmar_pci_path’ has no member named ‘dev’
drivers/pci/dmar.c:101: error: ‘struct acpi_dmar_pci_path’ has no member named ‘fn’

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Lin Ming

author

2009-08-17 02:16 UTC #5 lore raw

Quoted 5 lines · Lin Ming

Quoted 4 lines · Len Brown
Quoted 2 lines · Lin Ming
Hi, Len

Quoted 7 lines

Quoted 4 lines
Quoted 2 lines
ACPICA Release 20090730 linuxized patches attached. Build&Test on 32&64 bit machines.
please build with CONFIG_DMAR=y
Fix dmar build error.
Now build OK with "make allyesconfig"

New mbox file attached.

Lin Ming

Quoted 34 lines

include/acpi/actbl2.h +2 -2
index 674e27b..6f3dce9 100644
@@ -252,8 +252,8 @@ enum acpi_dmar_scope_type {
 };
 
 struct acpi_dmar_pci_path {
-	u8 device;
-	u8 function;
+	u8 dev;
+	u8 fn;
 };
 
 /*
Quoted 17 lines
CC drivers/pci/dmar.o
drivers/pci/dmar.c: In function ‘dmar_parse_one_dev_scope’:
drivers/pci/dmar.c:87: error: ‘struct acpi_dmar_pci_path’ has no member named ‘dev’
drivers/pci/dmar.c:87: error: ‘struct acpi_dmar_pci_path’ has no member named ‘fn’
drivers/pci/dmar.c:91: error: ‘struct acpi_dmar_pci_path’ has no member named ‘dev’
drivers/pci/dmar.c:91: error: ‘struct acpi_dmar_pci_path’ has no member named ‘fn’
drivers/pci/dmar.c:101: error: ‘struct acpi_dmar_pci_path’ has no member named ‘dev’
drivers/pci/dmar.c:101: error: ‘struct acpi_dmar_pci_path’ has no member named ‘fn’

Len Brown

reviewer Applied

2009-08-28 23:41 UTC #6 lore raw

Quoted 1 line

New mbox file attached.

applied.

thanks,
Len Brown, Intel Open Source Technology Center