Skip to contentSkip to conversation

mdio: mdio_if_info::mmds should not be __bitwise

PATCH Applied Ben Hutchings 2 participants 2 messages Aug 18, 2009 – Aug 19, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mdio: mdio_if_info::mmds should not be __bitwise

I misunderstood the meaning of __bitwise. In practice it makes sparse warn about every use of mmds which is certainly not what we want.

---
This should be safe to include in 2.6.31 but it's hardly critical.

Ben.

 include/linux/mdio.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/mdio.h +1 -1
index cfdf1df..c779b49 100644
@@ -304,7 +304,7 @@ static inline __u16 mdio_phy_id_devad(int phy_id)
  */
 struct mdio_if_info {
 	int prtad;
-	u32 __bitwise mmds;
+	u32 mmds;
 	unsigned mode_support;
 
 	struct net_device *dev;
Signature · 3 lines
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
maintainer Applied
#1 lore raw

From: Ben Hutchings <[email protected]>
Date: Tue, 18 Aug 2009 17:59:38 +0100

Quoted 6 lines

I misunderstood the meaning of __bitwise. In practice it makes sparse warn about every use of mmds which is certainly not what we want.

---
This should be safe to include in 2.6.31 but it's hardly critical.

Applied to net-next-2.6, thanks.