Skip to contentSkip to conversation

Patch format for submission?

DISCUSSION Peter Barada 11 participants 13 messages Aug 19, 2009 – May 3, 2010

lore
Share & tools
lore
#0 lore raw

1) Does anyone have a URL of the format patches should be in that are submitted to the linux-omap list?

I've got some patches to add base support for the Logic OMAP 35x SOM and Torpedo boards and I'd like to submit them in the right format for inclusion and push into mainline.

Signature · 2 lines
Peter Barada <[email protected]>
Logic Product Development, Inc.
#1 lore raw

Hi Peter,

Quoted 6 lines · Peter Barada

1) Does anyone have a URL of the format patches should be in that are submitted to the linux-omap list?

I've got some patches to add base support for the Logic OMAP 35x SOM and Torpedo boards and I'd like to submit them in the right format for inclusion and push into mainline.

Documentation/SubmittingPatches and Documentation/CodingStyle are pretty good intros to this.

- Paul

#8 lore raw
In reply to Peter Barada
Quoted 6 lines · Peter Barada

1) Does anyone have a URL of the format patches should be in that are submitted to the linux-omap list?

I've got some patches to add base support for the Logic OMAP 35x SOM and Torpedo boards and I'd like to submit them in the right format for inclusion and push into mainline.

Peter,

Look at Documentation/SubmittingPatches in the kernel top level directory. It has instructions and links to other documents for submitting a correct patch.

Regards,
Amit

Signature · 3 lines
-------------------------------------------------------------------------
Amit Kucheria,				 Kernel Developer, Verdurent
-------------------------------------------------------------------------
#2 lore raw
In reply to Paul Walmsley
Quoted 7 lines · Paul Walmsley

Hi Peter,

Quoted 3 lines · Peter Barada

1) Does anyone have a URL of the format patches should be in that are submitted to the linux-omap list?

Quoted 7 lines
Quoted 3 lines

I've got some patches to add base support for the Logic OMAP 35x SOM and Torpedo boards and I'd like to submit them in the right format for inclusion and push into mainline.

Documentation/SubmittingPatches and Documentation/CodingStyle are pretty good intros to this.

Also, Andrew Morton wrote a paper called "The Perfect Patch" with a nice checklist of attributes.

http://userweb.kernel.org/~akpm/stuff/tpp.txt

-- Tim
=============================
Tim Bird
Architecture Group Chair, CE Linux Forum Senior Staff Engineer, Sony Corporation of America
=============================

#9 lore raw
In reply to Peter Barada

Am Mittwoch, 19. August 2009 schrieb Peter Barada:

Quoted 6 lines

1) Does anyone have a URL of the format patches should be in that are submitted to the linux-omap list?

I've got some patches to add base support for the Logic OMAP 35x SOM and Torpedo boards and I'd like to submit them in the right format for inclusion and push into mainline.

Hi Peter,

nice to see your announcement here at linux-omap. Today I've finished my own port for the Logic OMAP 35x SOM based on 2.6.31-rc1. We should share our results befor submitting any patches to the list, or not?

Signature · 7 lines
Viele Grüße / Best Regards
Stephan Linz

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw
In reply to Tim Bird
Quoted 12 lines · Tim Bird
Quoted 11 lines · Paul Walmsley

Hi Peter,

Quoted 6 lines · Peter Barada

1) Does anyone have a URL of the format patches should be in that are submitted to the linux-omap list?

I've got some patches to add base support for the Logic OMAP 35x SOM and Torpedo boards and I'd like to submit them in the right format for inclusion and push into mainline.

Quoted 8 lines
Quoted 3 lines

Documentation/SubmittingPatches and Documentation/CodingStyle are pretty good intros to this.

Also, Andrew Morton wrote a paper called "The Perfect Patch" with a nice checklist of attributes.

http://userweb.kernel.org/~akpm/stuff/tpp.txt

In addition to above suggestions, I highly recommend using git tools which automate many of these recommended steps.

Usin 'git format-patch' and then 'git send-email' will get you a long ways.

Kevin

#4 lore raw
Quoted 20 lines · Kevin Hilman
Quoted 18 lines · Tim Bird
Quoted 7 lines · Paul Walmsley

Hi Peter,

Quoted 3 lines · Peter Barada

1) Does anyone have a URL of the format patches should be in that are submitted to the linux-omap list?

Quoted 7 lines
Quoted 3 lines

I've got some patches to add base support for the Logic OMAP 35x SOM and Torpedo boards and I'd like to submit them in the right format for inclusion and push into mainline.

Documentation/SubmittingPatches and Documentation/CodingStyle are pretty good intros to this.

Also, Andrew Morton wrote a paper called "The Perfect Patch" with a nice checklist of attributes.

Quoted 8 lines
Quoted 2 lines

http://userweb.kernel.org/~akpm/stuff/tpp.txt

In addition to above suggestions, I highly recommend using git tools which automate many of these recommended steps.

Usin 'git format-patch' and then 'git send-email' will get you a long ways.

Kevin,

Most of my work is done with LTIB/svn. Is there a good starter document for git on how to have a local tree, local changes, and keep it up to date with a remote tree? I've waded through some of git's documentation, but its bit daunting bending my brain around git after many years of SVN/CVS.

1) If I use "git fetch" to create a local copy, how do I check in changes to my tree (that stay local), then update my tree to changes you've made? I assume this is where rebasing comes in, but I'm unclear on the process - I've littered my machine with multiple busted git trees trying to track yours and Tony's trees/branches/tags. Any quick examples are highly appreciated.

2) Are there tools to take an SVN tree and "import" it into a git tree (or do I have to do that by hand, patching my git tree foreach SVN revision I have)?

Signature · 2 lines
Peter Barada <[email protected]>
Logic Product Development, Inc.
#5 lore raw

Hi!

Quoted 27 lines · On Friday 21 August 2009 16:34:33 Peter Barada wrote:
Quoted 18 lines · Kevin Hilman
Quoted 17 lines · Tim Bird
Quoted 6 lines · Paul Walmsley

Hi Peter,

Quoted 3 lines · Peter Barada

1) Does anyone have a URL of the format patches should be in that are submitted to the linux-omap list?

Quoted 6 lines
Quoted 3 lines

I've got some patches to add base support for the Logic OMAP 35x SOM and Torpedo boards and I'd like to submit them in the right format for inclusion and push into mainline.

Documentation/SubmittingPatches and Documentation/CodingStyle are pretty good intros to this.

Also, Andrew Morton wrote a paper called "The Perfect Patch" with a nice checklist of attributes.

Quoted 7 lines
Quoted 1 line

http://userweb.kernel.org/~akpm/stuff/tpp.txt

In addition to above suggestions, I highly recommend using git tools which automate many of these recommended steps.

Usin 'git format-patch' and then 'git send-email' will get you a long ways.

Quoted 7 lines

Kevin,

Most of my work is done with LTIB/svn. Is there a good starter document for git on how to have a local tree, local changes, and keep it up to date with a remote tree? I've waded through some of git's documentation, but its bit daunting bending my brain around git after many years of SVN/CVS.

You can start with the Git tutorial [1] and Everyday Git [2]. The entry point for git documentation is at [3].

[1] http://www.kernel.org/pub/software/scm/git/docs/gittutorial.html
[2] http://www.kernel.org/pub/software/scm/git/docs/everyday.html
[3] http://www.kernel.org/pub/software/scm/git/docs/git.html

Quoted 6 lines

1) If I use "git fetch" to create a local copy, how do I check in changes to my tree (that stay local), then update my tree to changes you've made? I assume this is where rebasing comes in, but I'm unclear on the process - I've littered my machine with multiple busted git trees trying to track yours and Tony's trees/branches/tags. Any quick examples are highly appreciated.

You use 'git fetch', 'git pull' and 'git rebase' commands for that, cf. [1] and [2].

Quoted 3 lines

2) Are there tools to take an SVN tree and "import" it into a git tree (or do I have to do that by hand, patching my git tree foreach SVN revision I have)?

Regards,
Jean

#7 lore raw
In reply to Peter Barada
Quoted 30 lines · ext Peter Barada
Quoted 20 lines · Kevin Hilman
Quoted 18 lines · Tim Bird
Quoted 7 lines · Paul Walmsley

Hi Peter,

Quoted 3 lines · Peter Barada

1) Does anyone have a URL of the format patches should be in that are submitted to the linux-omap list?

Quoted 7 lines
Quoted 3 lines

I've got some patches to add base support for the Logic OMAP 35x SOM and Torpedo boards and I'd like to submit them in the right format for inclusion and push into mainline.

Documentation/SubmittingPatches and Documentation/CodingStyle are pretty good intros to this.

Also, Andrew Morton wrote a paper called "The Perfect Patch" with a nice checklist of attributes.

Quoted 8 lines
Quoted 2 lines

http://userweb.kernel.org/~akpm/stuff/tpp.txt

In addition to above suggestions, I highly recommend using git tools which automate many of these recommended steps.

Usin 'git format-patch' and then 'git send-email' will get you a long ways.

Quoted 7 lines

Kevin,

Most of my work is done with LTIB/svn. Is there a good starter document for git on how to have a local tree, local changes, and keep it up to date with a remote tree? I've waded through some of git's documentation, but its bit daunting bending my brain around git after many years of SVN/CVS.

git svn clone <repository url> <local repo name>

will do it.

Something like:

git svn clone https://www.mydomain.com/svn/project/trunk project

then you can even commit and push to a svn tree. after getting newest git tarball from [1], you can:

$ make prefix=/usr all doc
# make prefix=/usr install install-doc
$ git help svn

then you get git installed and help about svn support on git ;-)

[1] http://www.kernel.org/pub/scm/git/git-1.6.4.1.tar.bz2

Signature · 1 line
balbi
#6 lore raw
In reply to Jean Pihet
Quoted 9 lines · Jean Pihet
Quoted 2 lines

documentation, but its bit daunting bending my brain around git after many years of SVN/CVS.

You can start with the Git tutorial [1] and Everyday Git [2]. The entry point for git documentation is at [3].

[1] http://www.kernel.org/pub/software/scm/git/docs/gittutorial.html
[2] http://www.kernel.org/pub/software/scm/git/docs/everyday.html
[3] http://www.kernel.org/pub/software/scm/git/docs/git.html

For SVN users this is also handy:

http://git-scm.com/course/svn.html

Signature · 1 line
Kalle Valo
#10 lore raw

OMAP 3530 LV-SOM support (was: Re: Patch format for submission?)

In reply to Stephan Linz
Quoted 8 lines · Stephan Linz

Am Mittwoch, 19. August 2009 schrieb Peter Barada:

Quoted 6 lines

1) Does anyone have a URL of the format patches should be in that are submitted to the linux-omap list?

I've got some patches to add base support for the Logic OMAP 35x SOM and Torpedo boards and I'd like to submit them in the right format for inclusion and push into mainline.

Quoted 5 lines

Hi Peter,

nice to see your announcement here at linux-omap. Today I've finished my own port for the Logic OMAP 35x SOM based on 2.6.31-rc1. We should share our results befor submitting any patches to the list, or not?

That's the last message I can find from either of you on this topic. I'm in the process of rolling yet another patch set for 2.6.32. Was any further work done on this, or anything posted anywhere?

#11 lore raw

Re: OMAP 3530 LV-SOM support (was: Re: Patch format for submission?)

Quoted 11 lines · Zygo Blaxell
Quoted 10 lines · Stephan Linz

Am Mittwoch, 19. August 2009 schrieb Peter Barada:

Quoted 6 lines

1) Does anyone have a URL of the format patches should be in that are submitted to the linux-omap list?

I've got some patches to add base support for the Logic OMAP 35x SOM and Torpedo boards and I'd like to submit them in the right format for inclusion and push into mainline.

Hi Peter,

Quoted 8 lines
Quoted 3 lines

nice to see your announcement here at linux-omap. Today I've finished my own port for the Logic OMAP 35x SOM based on 2.6.31-rc1. We should share our results befor submitting any patches to the list, or not?

That's the last message I can find from either of you on this topic. I'm in the process of rolling yet another patch set for 2.6.32.  Was any further work done on this, or anything posted anywhere?

Zygo,

No, the LogicPD OMAP 35x support didn't quite make it out to the list, we are taking another crack at it shortly and would definitely love to collaborate to get the changes out. We did create a Gitorious repo[1], but that's sitting at 2.6.31-rc1 and we've internally got a newer version of the Kernel up to date..

So we should definitely discuss off-list on how to pool our efforts to get the support into the L-O tree..

Regards
-- Ashwin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#12 lore raw

Re: OMAP 3530 LV-SOM support (was: Re: Patch format for submission?)

Am Samstag, 1. Mai 2010 04:12:19 schrieb Ashwin Bihari:

Quoted 24 lines

On Thu, Apr 29, 2010 at 1:18 PM, Zygo Blaxell

Quoted 11 lines · <[email protected]> wrote:
Quoted 10 lines · Stephan Linz

Am Mittwoch, 19. August 2009 schrieb Peter Barada:

Quoted 6 lines

1) Does anyone have a URL of the format patches should be in that are submitted to the linux-omap list?

I've got some patches to add base support for the Logic OMAP 35x SOM and Torpedo boards and I'd like to submit them in the right format for inclusion and push into mainline.

Hi Peter,

Quoted 7 lines
Quoted 3 lines

nice to see your announcement here at linux-omap. Today I've finished my own port for the Logic OMAP 35x SOM based on 2.6.31-rc1. We should share our results befor submitting any patches to the list, or not?

That's the last message I can find from either of you on this topic. I'm in the process of rolling yet another patch set for 2.6.32. Was any further work done on this, or anything posted anywhere?

Zygo,

Quoted 8 lines

No, the LogicPD OMAP 35x support didn't quite make it out to the list, we are taking another crack at it shortly and would definitely love to collaborate to get the changes out. We did create a Gitorious repo[1], but that's sitting at 2.6.31-rc1 and we've internally got a newer version of the Kernel up to date..

So we should definitely discuss off-list on how to pool our efforts to get the support into the L-O tree..

Hi Zygo, Ashwin and Peter,

I was tied up with business and did no further work on my 2.6.31-rc1 for more than six months. Since last week I've been working on a fresh port of my own patch set based on latest stable 2.6.32-omap1 (looks good except USB and NOR flash access).

Yes of course. We should discuss off-list on how to share our results. Last summer I did create a new gitorious.org project for LogicPD omap boards too:
http://gitorious.org/omap3logic (soory there is no content til now ;-))

We can use it as our stage, or not?

@Ashwin: Where is your Gitorious repo you tell about?

Regards,
Stephan

Quoted 7 lines

Regards
-- Ashwin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 13 lines
Viele Grüße,
Stephan Linz
______________________________________________________________________________
OpenDCC: http://www.li-pro.net/opendcc.phtml
PC/M: http://www.li-pro.net/pcm.phtml
CDK4AVR: http://cdk4avr.sourceforge.net/
CDK4NIOS: http://cdk4nios.sourceforge.net/
CDK4MSP: http://cdk4msp.sourceforge.net/
CPM4L: http://download.opensuse.org/repositories/home:/rexut:/CPM4L
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html