ia64: pci_br, fix infinite loop
PATCH 1/1 ia64: pci_br, fix infinite loop
When
* there is almost out of ates
* one asks for more than one ate
* there are some available at the end of ate array
then the inner for loop will end without incrementing 'index'. This means the outer loop will start at the same point finding it's available and runs the inner loop again from the same index. This repeats forever.
Hence make sure we check we were at the end of ate array and return an error in such case.
Signed-off-by Jiri Slaby <[email protected]>
Cc Tony Luck <[email protected]>
Cc Fenghua Yu <[email protected]>
Found-by Jeff Mahoney <[email protected]>
--- arch/ia64/sn/pci/pcibr/pcibr_ate.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
arch/ia64/sn/pci/pcibr/pcibr_ate.c +2 -0
@@ -54,6 +54,8 @@ static int find_free_ate(struct ate_resource *ate_resource, int start,break ; } } +if (i >= ate_resource->num_ate) +return -1 ; }else index++;/* Try next ate */ }
Signature · 1 line
1.6.3.3