sfc: Improve reliability of RX queue flushing
Subsystems (2)
PATCH 6/7 sfc: Improve reliability of RX queue flushing
Reconfiguring the port requires us to flush all DMA queues. In repeated testing we have found that RX flushes would sometimes fail because the RX DMA engine was not properly isolated from the MACs.
Signed-off-by Ben Hutchings <[email protected]>
--- drivers/net/sfc/efx.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/net/sfc/efx.c +2 -0
@@ -1179,6 +1179,8 @@ static void efx_stop_all(struct efx_nic *efx)/* Isolate the MAC from the TX and RX engines, so that queue * flushes will complete in a timely fashion. */ +falcon_deconfigure_mac_wrapper (efx); +msleep (10 );/* Let the Rx FIFO drain */ falcon_drain_tx_fifo (efx);/* Stop the kernel transmit interface late, so the watchdog
Signature · 3 lines
Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.
From: Ben Hutchings <[email protected]>
Date: Wed, 26 Aug 2009 19:18:13 +0100
Quoted 5 lines
Reconfiguring the port requires us to flush all DMA queues. In repeated testing we have found that RX flushes would sometimes fail because the RX DMA engine was not properly isolated from the MACs.
Signed-off-by Ben Hutchings <[email protected]>
Applied.