Skip to contentSkip to conversation

module: preferred way to use MODULE_AUTHOR

PATCH Applied Johannes Berg 2 participants 2 messages Aug 28, 2009 – Sep 3, 2009 Module support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 module: preferred way to use MODULE_AUTHOR

For the longest time now we've been using multiple MODULE_AUTHOR() statements when a module has more than one author, but the comment here disagrees.

---
 include/linux/module.h |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
include/linux/module.h +4 -1
@@ -127,7 +127,10 @@ extern struct module __this_module;
  */
 #define MODULE_LICENSE(_license) MODULE_INFO(license, _license)
 
-/* Author, ideally of form NAME[, NAME]*[ and NAME] */
+/*
+ * Author(s), use "Name <email>" or just "Name", for multiple
+ * authors use multiple MODULE_AUTHOR() statements/lines.
+ */
 #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
   
 /* What your module does. */
Applied
#1 lore raw
Quoted 13 lines · Johannes Berg

For the longest time now we've been using multiple MODULE_AUTHOR() statements when a module has more than one author, but the comment here disagrees.

---
 include/linux/module.h |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
include/linux/module.h +0 -0
@@ -127,7 +127,10 @@ extern struct module __this_module;
  */

include/linux/module.h extern struct module __this_module; · line 136

Quoted 10 lines
include/linux/module.h +4 -1
 #define MODULE_LICENSE(_license) MODULE_INFO(license, _license)
 
-/* Author, ideally of form NAME[, NAME]*[ and NAME] */
+/*
+ * Author(s), use "Name <email>" or just "Name", for multiple
+ * authors use multiple MODULE_AUTHOR() statements/lines.
+ */
 #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
 
 /* What your module does. */

Applied, thanks Johannes.

Signature · 2 lines
Jiri Kosina
SUSE Labs