fb: change rules for global rules match.
PATCH 1/2 fb: change rules for global rules match.
From: Dave Airlie <[email protected]>
Having a : should be enough 'fb:' isn't really useful if the fb wants to a kms output ID.
Andrew: I can push this via the drm tree if no objections, as I have a kms patch that requires it.
--- drivers/video/fbmem.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/video/fbmem.c +1 -1
@@ -1789,7 +1789,7 @@ static int __init video_setup(char *options) global =1 ; } -if (!global && !strstr (options,"fb:" )) { +if (!global && !strstr (options,":" )) { fb_mode_option = options; global =1 ; }
Signature · 9 lines
1.6.4.4 ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf
Quoted 18 lines · Dave Airlie
From: Dave Airlie <[email protected]>
Having a : should be enough 'fb:' isn't really useful if the fb wants to a kms output ID.
Andrew: I can push this via the drm tree if no objections, as I have a kms patch that requires it.
Signed-off-by Dave Airlie <[email protected]>---
drivers/video/fbmem.c | 2 +-1 files changed, 1 insertions(+), 1 deletions(-)drivers/video/fbmem.c +0
-0
drivers/video/fbmem.c static int __init video_setup(char *options) · line 1795
Quoted 8 lines
drivers/video/fbmem.c +1
-1@@ -1789,7 +1789,7 @@ static int __init video_setup(char *options) global = 1; } - if (!global && !strstr(options, "fb:")) { + if (!global && !strstr(options, ":")) { fb_mode_option = options; global = 1; }
Please don't use strstr() with single-character needle parameter strings. Use strchr() instead.
Gcc may change such a strstr() to strchr() behind our back, causing linking errors
on platforms that only provide an inline version of strchr().
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Linux-fbdev-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel