Skip to contentSkip to conversation

pmcraid build problem on ppc64

DISCUSSION James Bottomley 2 participants 2 messages Sep 24, 2009 SCSI

lore
Share & tools
lore

James Bottomley

author maintainer
#0 lore raw

I'm getting this in testing:

drivers/scsi/pmcraid.c: In function 'pmcraid_request_sense':
drivers/scsi/pmcraid.c:2254: warning: large integer implicitly truncated to unsigned type
drivers/scsi/pmcraid.c: In function 'pmcraid_build_ioadl':
drivers/scsi/pmcraid.c:3020: warning: large integer implicitly truncated to unsigned type
drivers/scsi/pmcraid.c: In function 'pmcraid_build_passthrough_ioadls':
drivers/scsi/pmcraid.c:3390: warning: large integer implicitly truncated to unsigned type
drivers/scsi/pmcraid.c: In function 'pmcraid_querycfg':
drivers/scsi/pmcraid.c:5317: warning: large integer implicitly truncated to unsigned type

It's code like this:

	ioadl->flags = cpu_to_le32(IOADL_FLAGS_LAST_DESC);

But ->flags is only u8, so that cpu_to_le32() will cause the flag to be too big to fit on a BE architecture.

James

#1 lore raw

I guess we don't need conversions cpu_to_le32 for these ones. I will make this change and send an update patch.

With regards,
Anil

Quoted 26 lines · James Bottomley

I'm getting this in testing:

drivers/scsi/pmcraid.c: In function 'pmcraid_request_sense':
drivers/scsi/pmcraid.c:2254: warning: large integer implicitly truncated to unsigned type
drivers/scsi/pmcraid.c: In function 'pmcraid_build_ioadl':
drivers/scsi/pmcraid.c:3020: warning: large integer implicitly truncated to unsigned type
drivers/scsi/pmcraid.c: In function 'pmcraid_build_passthrough_ioadls':
drivers/scsi/pmcraid.c:3390: warning: large integer implicitly truncated to unsigned type
drivers/scsi/pmcraid.c: In function 'pmcraid_querycfg':
drivers/scsi/pmcraid.c:5317: warning: large integer implicitly truncated to unsigned type

It's code like this:

	ioadl->flags = cpu_to_le32(IOADL_FLAGS_LAST_DESC);

But ->flags is only u8, so that cpu_to_le32() will cause the flag to be too big to fit on a BE architecture.

James