qla2xxx: Fix Null ptr dereference in fail path in queue create code
Subsystems (2)
PATCH v2 1/1 qla2xxx: Fix Null ptr dereference in fail path in queue create code
From: Anirban Chakraborty <[email protected]>
Current code jumps to fail path in queue create functions and there it invokes the queue free call with a (NULL) pointer to the queue which could not be allocated. Fix it by returning ENOMEM directly without invoking the queue free call.
[v2] use return 0 instead of return ENOMEM. Callers expect that.
Signed-off-by Jiri Slaby <[email protected]>
Signed-off-by Anirban Chakraborty <[email protected]>
--- drivers/scsi/qla2xxx/qla_mid.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/qla2xxx/qla_mid.c +2 -2
@@ -568,7 +568,7 @@ qla25xx_create_req_que(struct qla_hw_data *ha, uint16_t options,if (req ==NULL ) {qla_printk (KERN_WARNING , ha,"could not allocate memory" "for request que\n" ); - goto que_failed; +return 0 ; } req->length =REQUEST_ENTRY_CNT_24XX ;
@@ -659,7 +659,7 @@ qla25xx_create_rsp_que(struct qla_hw_data *ha, uint16_t options,if (rsp ==NULL ) {qla_printk (KERN_WARNING , ha,"could not allocate memory for" " response que\n" ); - goto que_failed; +return 0 ; } rsp->length =RESPONSE_ENTRY_CNT_MQ ;
Signature · 1 line
1.6.4.2