OMAP3: RX51: support sleep indicator LEDs
Subsystems (3)
PATCH 1/1 OMAP3: RX51: support sleep indicator LEDs
The sleep indicator LEDs can be enabled/disabled by toggling GPIO162. Request this GPIO in RX51 board init, disable by default and expose GPIO162 to userspace so LEDs can be toggled from userspace:
To enable:
# echo 1 > /sys/class/gpio/gpio162/value
To disable:
# echo 0 > /sys/class/gpio/gpio162/value
--- arch/arm/mach-omap2/board-rx51.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/board-rx51.c +7 -0
@@ -31,6 +31,8 @@#include <mach/gpmc.h> #include <mach/usb.h> +#define RX51_GPIO_SLEEP_IND 162 +static struct omap_lcd_config rx51_lcd_config = { .ctrl_name ="internal" , };
@@ -74,6 +76,11 @@ static void __init rx51_init(void)/* Ensure SDRC pins are mux'd for self-refresh */ omap_cfg_reg (H16_34XX_SDRC_CKE0 );omap_cfg_reg (H17_34XX_SDRC_CKE1 ); + +if (!(gpio_request (RX51_GPIO_SLEEP_IND ,"SLEEP_IND" ))) { +gpio_direction_output (RX51_GPIO_SLEEP_IND ,0 ); +gpio_export (RX51_GPIO_SLEEP_IND ,1 ); + } }static void __init rx51_map_io (void )
Signature · 1 line
1.6.4.3
Quoted 3 lines · Kevin Hilman
The sleep indicator LEDs can be enabled/disabled by toggling GPIO162. Request this GPIO in RX51 board init, disable by default and expose GPIO162 to userspace so LEDs can be toggled from userspace:
Wouldn't this be better done using the LED class subsystem?
Quoted 10 lines
To enable:
# echo 1 > /sys/class/gpio/gpio162/valueTo disable:
# echo 0 > /sys/class/gpio/gpio162/valueSigned-off-by Kevin Hilman <[email protected]>---
J.
Signature · 1 line
101 things you can't have too much of : 16 - Time.
Quoted 6 lines · Jonathan McDowell
Quoted 3 lines · Kevin Hilman
The sleep indicator LEDs can be enabled/disabled by toggling GPIO162. Request this GPIO in RX51 board init, disable by default and expose GPIO162 to userspace so LEDs can be toggled from userspace:
Wouldn't this be better done using the LED class subsystem?
No, these are HW controlled LEDs which blink based on whether the OMAP is hitting retention or OFF mode etc. The software has no control over the blinking of LEDs themselves. The GPIO simply enables them.
Kevin
Quoted 15 lines
Quoted 10 lines
To enable:
# echo 1 > /sys/class/gpio/gpio162/valueTo disable:
# echo 0 > /sys/class/gpio/gpio162/valueSigned-off-by Kevin Hilman <[email protected]>---
J.
Signature · 1 line
101 things you can't have too much of : 16 - Time.
Quoted 6 lines · ext Kevin Hilman
Quoted 4 lines · Jonathan McDowell
Quoted 3 lines · Kevin Hilman
The sleep indicator LEDs can be enabled/disabled by toggling GPIO162. Request this GPIO in RX51 board init, disable by default and expose GPIO162 to userspace so LEDs can be toggled from userspace:
Quoted 8 lines
Quoted 1 line
Wouldn't this be better done using the LED class subsystem?
No, these are HW controlled LEDs which blink based on whether the OMAP is hitting retention or OFF mode etc. The software has no control over the blinking of LEDs themselves. The GPIO simply enables them.
Kevin
Actually, i think it would make sense to use LED class subsystem, even if the GPIO does not directly control LEDs because
1) it does indirectly control a group of LEDs. enable/disable
2) it solves our GPIO numbering problem. user-space does not need to care about or track which GPIO to set/reset
3) Makes better sense from architecture point of view
User-space will write to /sys/class/leds/debug_leds/brightness
-roger
Quoted 20 lines
Quoted 5 lines
Quoted 5 lines
To enable:
# echo 1 > /sys/class/gpio/gpio162/valueQuoted 10 lines
Quoted 6 lines
To disable:
# echo 0 > /sys/class/gpio/gpio162/valueSigned-off-by Kevin Hilman <[email protected]>---
J.
Signature · 1 line
101 things you can't have too much of : 16 - Time.--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 3 lines · ext Kevin Hilman
The sleep indicator LEDs can be enabled/disabled by toggling GPIO162. Request this GPIO in RX51 board init, disable by default and expose GPIO162 to userspace so LEDs can be toggled from userspace:
It would also make more sense to use gpio_export_link() to provide a named link to userspace (e.g. sleep_ind, instead of GPIO162), as it is possible for gpio number to change among board revisions and userspace shouldn't bother about that.
-roger
Quoted 39 lines
To enable:
# echo 1 > /sys/class/gpio/gpio162/valueTo disable:
# echo 0 > /sys/class/gpio/gpio162/valueSigned-off-by Kevin Hilman <[email protected]>--- arch/arm/mach-omap2/board-rx51.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)arch/arm/mach-omap2/board-rx51.c +7
-0@@ -31,6 +31,8 @@#include <mach/gpmc.h> #include <mach/usb.h> +#define RX51_GPIO_SLEEP_IND 162 +static struct omap_lcd_config rx51_lcd_config = { .ctrl_name ="internal" , };@@ -74,6 +76,11 @@ static void __init rx51_init(void)/* Ensure SDRC pins are mux'd for self-refresh */ omap_cfg_reg (H16_34XX_SDRC_CKE0 );omap_cfg_reg (H17_34XX_SDRC_CKE1 ); + +if (!(gpio_request (RX51_GPIO_SLEEP_IND ,"SLEEP_IND" ))) { +gpio_direction_output (RX51_GPIO_SLEEP_IND ,0 ); +gpio_export (RX51_GPIO_SLEEP_IND ,1 ); + } }static void __init rx51_map_io (void )