Skip to contentSkip to conversation

perf tools: Add missing tools/perf/util/include/string.h

PATCH In review Arnaldo Carvalho de Melo 2 participants 3 messages Oct 19, 2009 – Oct 24, 2009 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf tools: Add missing tools/perf/util/include/string.h

To cure a bunch of:

In file included from util/include/linux/bitmap.h:1,
from util/header.h:8,
from builtin-trace.c:7:
util/include/../../../../include/linux/bitmap.h:8:26: error: linux/string.h: No such file or directory
make: *** [builtin-trace.o] Error 1
make: *** Waiting for unfinished jobs....

Cc Steven Rostedt <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Frederic Weisbecker <[email protected]>
---
 tools/perf/Makefile                    |    1 +
 tools/perf/util/include/linux/string.h |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
 create mode 100644 tools/perf/util/include/linux/string.h
tools/perf/Makefile +1 -0
index db89a6d..3b154f1 100644
@@ -329,6 +329,7 @@ LIB_H += ../../include/linux/perf_event.h
 LIB_H += ../../include/linux/rbtree.h
 LIB_H += ../../include/linux/list.h
 LIB_H += util/include/linux/list.h
+LIB_H += util/include/linux/string.h
 LIB_H += perf.h
 LIB_H += util/event.h
 LIB_H += util/types.h
tools/perf/util/include/linux/string.h new file +1 -0
new file mode 100644
index 0000000..3b2f590
@@ -0,0 +1 @@
+#include <string.h>
Signature · 1 line
1.5.5.1
#1 lore raw
Quoted 8 lines · Arnaldo Carvalho de Melo

To cure a bunch of:

In file included from util/include/linux/bitmap.h:1,
from util/header.h:8,
from builtin-trace.c:7:
util/include/../../../../include/linux/bitmap.h:8:26: error: linux/string.h: No such file or directory
make: *** [builtin-trace.o] Error 1
make: *** Waiting for unfinished jobs....

Hmm, while exporting some headers, I saw that some kernel headers inclusion didn't triggered any warning although they were including headers for which I hadn't put any stub, so they couldn't find it.

So it looks like my gcc is sometimes missing such problems. Sorry.

Thanks.

#2 lore raw
In reply to Arnaldo Carvalho de Melo
Commit-ID:  20639c15d2e78f180d398a6b6422880fac3258bb
Gitweb:     http://git.kernel.org/tip/20639c15d2e78f180d398a6b6422880fac3258bb
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Mon, 19 Oct 2009 15:11:36 -0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 20 Oct 2009 02:59:34 +0200

perf tools: Add missing tools/perf/util/include/string.h

To cure a bunch of:

In file included from util/include/linux/bitmap.h:1,
from util/header.h:8,
from builtin-trace.c:7:
util/include/../../../../include/linux/bitmap.h:8:26: error:
linux/string.h: No such file or directory make: *** [builtin-trace.o] Error 1 make: *** Waiting for unfinished jobs....

LKML-Reference: <[email protected]>

---
 tools/perf/Makefile                    |    1 +
 tools/perf/util/include/linux/string.h |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
tools/perf/Makefile +1 -0
index db89a6d..3b154f1 100644
@@ -329,6 +329,7 @@ LIB_H += ../../include/linux/perf_event.h
 LIB_H += ../../include/linux/rbtree.h
 LIB_H += ../../include/linux/list.h
 LIB_H += util/include/linux/list.h
+LIB_H += util/include/linux/string.h
 LIB_H += perf.h
 LIB_H += util/event.h
 LIB_H += util/types.h
tools/perf/util/include/linux/string.h new file +1 -0
new file mode 100644
index 0000000..3b2f590
@@ -0,0 +1 @@
+#include <string.h>