Skip to contentSkip to conversation

Staging: Android logger: fix compiling error

PATCH In review Bryan Wu 5 participants 14 messages Oct 23, 2009 – Nov 1, 2009 Staging

lore
Share & tools
lore

Bryan Wu

author
#0 lore raw

PATCH 1/1 Staging: Android logger: fix compiling error

When compiling Android staging driver for PXA3XX machine, met following error:

CC drivers/staging/android/logger.o
drivers/staging/android/logger.c: In function 'logger_read':
drivers/staging/android/logger.c:165: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function) drivers/staging/android/logger.c:165: error: (Each undeclared identifier is reported only once drivers/staging/android/logger.c:165: error: for each function it appears in.) drivers/staging/android/logger.c:178: error: implicit declaration of function 'signal_pending' drivers/staging/android/logger.c:183: error: implicit declaration of function 'schedule' drivers/staging/android/logger.c: In function 'logger_aio_write':
drivers/staging/android/logger.c:325: error: dereferencing pointer to incomplete type drivers/staging/android/logger.c:333: error: dereferencing pointer to incomplete type drivers/staging/android/logger.c:334: error: dereferencing pointer to incomplete type drivers/staging/android/logger.c:337: error: dereferencing pointer to incomplete type drivers/staging/android/logger.c:360: error: dereferencing pointer to incomplete type drivers/staging/android/logger.c:363: error: dereferencing pointer to incomplete type drivers/staging/android/logger.c:370: error: increment of pointer to unknown structure drivers/staging/android/logger.c:370: error: arithmetic on pointer to an incomplete type drivers/staging/android/logger.c:377: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function) make[3]: *** [drivers/staging/android/logger.o] Error 1

Compiling broke since commit a99bbaf5ee6bad1aca0c88ea65ec6e5373e86184
headers: remove sched.h from poll.h

Adding <linux/sched.h> to fix this compiling bug.

Cc Alexey Dobriyan <[email protected]>
---
 drivers/staging/android/logger.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/staging/android/logger.c +1 -0
index 6c10b45..a8eb7d1 100644
@@ -21,6 +21,7 @@
 #include <linux/fs.h>
 #include <linux/miscdevice.h>
 #include <linux/uaccess.h>
+#include <linux/sched.h>
 #include <linux/poll.h>
 #include <linux/time.h>
 #include "logger.h"
Signature · 1 line
1.6.3.3
#1 lore raw
Quoted 5 lines

Compiling broke since commit a99bbaf5ee6bad1aca0c88ea65ec6e5373e86184
   headers: remove sched.h from poll.h

Adding <linux/sched.h> to fix this compiling bug.

Bryan,

Is this something caused by incorrect pxa header files?

Quoted 27 lines
Cc Alexey Dobriyan <[email protected]>

---
 drivers/staging/android/logger.c |    1 +

 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/staging/android/logger.c +1 -1
index 6c10b45..a8eb7d1 100644
@@ -21,6 +21,7 @@
  #include <linux/fs.h>
  #include <linux/miscdevice.h>
  #include <linux/uaccess.h>
+#include <linux/sched.h>
  #include <linux/poll.h>
  #include <linux/time.h>
  #include "logger.h"
--

1.6.3.3

--
kernel-team mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

author
#2 lore raw
Quoted 10 lines · Eric Miao
Quoted 5 lines

Compiling broke since commit a99bbaf5ee6bad1aca0c88ea65ec6e5373e86184
headers: remove sched.h from poll.h

Adding <linux/sched.h> to fix this compiling bug.

Bryan,

Is this something caused by incorrect pxa header files?

No. the commit a99bbaf5ee6bad1aca0c88ea65ec6e5373e86184 missed to fix this issue in Android driver. It fixed others. I just added it back.

-Bryan

#3 lore raw
In reply to Eric Miao
Quoted 4 lines · Eric Miao
Quoted 4 lines

Compiling broke since commit a99bbaf5ee6bad1aca0c88ea65ec6e5373e86184
   headers: remove sched.h from poll.h

Adding <linux/sched.h> to fix this compiling bug.

I have now just marked the android drivers as broken, as this is not the only build error in them at the moment :(

thanks,

greg k-h

author
#4 lore raw
Quoted 9 lines · Greg KH
Quoted 4 lines · Eric Miao
Quoted 4 lines

Compiling broke since commit a99bbaf5ee6bad1aca0c88ea65ec6e5373e86184
headers: remove sched.h from poll.h

Adding <linux/sched.h> to fix this compiling bug.

I have now just marked the android drivers as broken, as this is not the only build error in them at the moment :(

Yeah, actually the drivers/staging/android/lowmemorykiller.c has been failing to compile for a long time, because that struct mm_struct does not have a field named oom_adj. All the Android drivers are compiled as modules in Ubuntu kernel package, except this one.

Although Android public kernel is still in 2.6.29, it's own driver is totally different with our mainline staging version. Is there any plan to sync with it?

Thanks,
-Bryan

#5 lore raw
Quoted 11 lines · Bryan Wu
Quoted 9 lines · Greg KH
Quoted 4 lines · Eric Miao
Quoted 4 lines

Compiling broke since commit a99bbaf5ee6bad1aca0c88ea65ec6e5373e86184
headers: remove sched.h from poll.h

Adding <linux/sched.h> to fix this compiling bug.

I have now just marked the android drivers as broken, as this is not the only build error in them at the moment :(

Quoted 8 lines

Yeah, actually the drivers/staging/android/lowmemorykiller.c has been failing to compile for a long time, because that struct mm_struct does not have a field named oom_adj. All the Android drivers are compiled as modules in Ubuntu kernel package, except this one.

Although Android public kernel is still in 2.6.29, it's own driver is totally different with our mainline staging version. Is there any plan to sync with it?

No, Google has abandoned any current effort to push code upstream for the past year :(

The android drivers are deleted in linux-next and will go away in 2.6.33 because of this.

thanks,

greg k-h

author
#6 lore raw
Quoted 19 lines · Greg KH
Quoted 9 lines · Bryan Wu
Quoted 8 lines · Greg KH
Quoted 4 lines · Eric Miao
Quoted 4 lines

Compiling broke since commit a99bbaf5ee6bad1aca0c88ea65ec6e5373e86184
headers: remove sched.h from poll.h

Adding <linux/sched.h> to fix this compiling bug.

I have now just marked the android drivers as broken, as this is not the only build error in them at the moment :(

Quoted 8 lines

Yeah, actually the drivers/staging/android/lowmemorykiller.c has been failing to compile for a long time, because that struct mm_struct does not have a field named oom_adj. All the Android drivers are compiled as modules in Ubuntu kernel package, except this one.

Although Android public kernel is still in 2.6.29, it's own driver is totally different with our mainline staging version. Is there any plan to sync with it?

Quoted 6 lines

No, Google has abandoned any current effort to push code upstream for the past year :(

The android drivers are deleted in linux-next and will go away in 2.6.33 because of this.

Thanks a lot for this update. It looks like we need to consider to drop Android modules in our Ubuntu kernel building somehow.

Cheers,
-Bryan

#7 lore raw
Quoted 23 lines · Bryan Wu
Quoted 22 lines · Greg KH
Quoted 9 lines · Bryan Wu
Quoted 8 lines · Greg KH
Quoted 4 lines · Eric Miao
Quoted 4 lines

Compiling broke since commit a99bbaf5ee6bad1aca0c88ea65ec6e5373e86184
headers: remove sched.h from poll.h

Adding <linux/sched.h> to fix this compiling bug.

I have now just marked the android drivers as broken, as this is not the only build error in them at the moment :(

Quoted 8 lines

Yeah, actually the drivers/staging/android/lowmemorykiller.c has been failing to compile for a long time, because that struct mm_struct does not have a field named oom_adj. All the Android drivers are compiled as modules in Ubuntu kernel package, except this one.

Although Android public kernel is still in 2.6.29, it's own driver is totally different with our mainline staging version. Is there any plan to sync with it?

No, Google has abandoned any current effort to push code upstream for the past year :(

Quoted 6 lines
Quoted 3 lines

The android drivers are deleted in linux-next and will go away in 2.6.33 because of this.

Thanks a lot for this update. It looks like we need to consider to drop Android modules in our Ubuntu kernel building somehow.

As no one is using them, it should be trivial to just change your kernel config, right?

thanks,

greg k-h

author
#8 lore raw
Quoted 23 lines · Greg KH
Quoted 22 lines · Bryan Wu
Quoted 21 lines · Greg KH
Quoted 9 lines · Bryan Wu
Quoted 8 lines · Greg KH
Quoted 4 lines · Eric Miao
Quoted 4 lines

Compiling broke since commit a99bbaf5ee6bad1aca0c88ea65ec6e5373e86184
headers: remove sched.h from poll.h

Adding <linux/sched.h> to fix this compiling bug.

I have now just marked the android drivers as broken, as this is not the only build error in them at the moment :(

Quoted 8 lines

Yeah, actually the drivers/staging/android/lowmemorykiller.c has been failing to compile for a long time, because that struct mm_struct does not have a field named oom_adj. All the Android drivers are compiled as modules in Ubuntu kernel package, except this one.

Although Android public kernel is still in 2.6.29, it's own driver is totally different with our mainline staging version. Is there any plan to sync with it?

No, Google has abandoned any current effort to push code upstream for the past year :(

Quoted 8 lines
Quoted 4 lines
Quoted 3 lines

The android drivers are deleted in linux-next and will go away in 2.6.33 because of this.

Thanks a lot for this update. It looks like we need to consider to drop Android modules in our Ubuntu kernel building somehow.

As no one is using them, it should be trivial to just change your kernel config, right?

The reason we include them is that we wanna port the Android runtime environment to Ubuntu. Then the Android applications can run on Android compatible Ubuntu OS directly without any modification.

The Android runtime environment needs some Android drivers such as Binder.

But now, it is hard for us to do that without a workable Android drivers in mainline.

Thanks
-Bryan

#9 lore raw
Quoted 34 lines · Bryan Wu
Quoted 23 lines · Greg KH
Quoted 22 lines · Bryan Wu
Quoted 21 lines · Greg KH
Quoted 9 lines · Bryan Wu
Quoted 8 lines · Greg KH
Quoted 4 lines · Eric Miao
Quoted 4 lines

Compiling broke since commit a99bbaf5ee6bad1aca0c88ea65ec6e5373e86184
headers: remove sched.h from poll.h

Adding <linux/sched.h> to fix this compiling bug.

I have now just marked the android drivers as broken, as this is not the only build error in them at the moment :(

Quoted 8 lines

Yeah, actually the drivers/staging/android/lowmemorykiller.c has been failing to compile for a long time, because that struct mm_struct does not have a field named oom_adj. All the Android drivers are compiled as modules in Ubuntu kernel package, except this one.

Although Android public kernel is still in 2.6.29, it's own driver is totally different with our mainline staging version. Is there any plan to sync with it?

No, Google has abandoned any current effort to push code upstream for the past year :(

Quoted 9 lines
Quoted 5 lines
Quoted 3 lines

The android drivers are deleted in linux-next and will go away in 2.6.33 because of this.

Thanks a lot for this update. It looks like we need to consider to drop Android modules in our Ubuntu kernel building somehow.

As no one is using them, it should be trivial to just change your kernel config, right?

Quoted 5 lines

The reason we include them is that we wanna port the Android runtime environment to Ubuntu. Then the Android applications can run on Android compatible Ubuntu OS directly without any modification.

The Android runtime environment needs some Android drivers such as Binder.

Don't you also need the wakelocks and the hooks in the core of the kernel to tie into the binder mess?

Quoted 2 lines

But now, it is hard for us to do that without a workable Android drivers in mainline.

Then push on Google to get them cleaned up and fixed! Or do it yourself, all I need is a developer to take ownership of the code.

thanks,

greg k-h

author
#10 lore raw
Quoted 32 lines · Greg KH
Quoted 31 lines · Bryan Wu
Quoted 30 lines · Greg KH
Quoted 19 lines · Bryan Wu
Quoted 18 lines · Greg KH
Quoted 17 lines · Bryan Wu
Quoted 8 lines · Greg KH
Quoted 4 lines · Eric Miao
Quoted 4 lines

Compiling broke since commit a99bbaf5ee6bad1aca0c88ea65ec6e5373e86184
headers: remove sched.h from poll.h

Adding <linux/sched.h> to fix this compiling bug.

I have now just marked the android drivers as broken, as this is not the only build error in them at the moment :(

Yeah, actually the drivers/staging/android/lowmemorykiller.c has been failing to compile for a long time, because that struct mm_struct does not have a field named oom_adj. All the Android drivers are compiled as modules in Ubuntu kernel package, except this one.

Although Android public kernel is still in 2.6.29, it's own driver is totally different with our mainline staging version. Is there any plan to sync with it?

Quoted 7 lines
Quoted 6 lines

No, Google has abandoned any current effort to push code upstream for the past year :(

The android drivers are deleted in linux-next and will go away in 2.6.33 because of this.

Thanks a lot for this update. It looks like we need to consider to drop Android modules in our Ubuntu kernel building somehow.

As no one is using them, it should be trivial to just change your kernel config, right?

Quoted 7 lines
Quoted 3 lines

The reason we include them is that we wanna port the Android runtime environment to Ubuntu. Then the Android applications can run on Android compatible Ubuntu OS directly without any modification.

The Android runtime environment needs some Android drivers such as Binder.

Don't you also need the wakelocks and the hooks in the core of the kernel to tie into the binder mess?

Yeah, that is complicated. -:(

Quoted 5 lines
Quoted 1 line

But now, it is hard for us to do that without a workable Android drivers in mainline.

Then push on Google to get them cleaned up and fixed! Or do it yourself, all I need is a developer to take ownership of the code.

I'm doing a task which is trying to merge Android patches to Ubuntu kernel and mainline, not only the Android drivers but also the ARM port code which is not in mainline.

But since Android kernel is 2.6.29 and ours or mainline is 2.6.31+, you know it needs much more effort without Google's help.

And for sure, I'm very happy to help this out.

Cheers,
-Bryan

#11 lore raw
Quoted 6 lines · Bryan Wu
Quoted 5 lines
Quoted 2 lines

But now, it is hard for us to do that without a workable Android drivers in mainline.

Then push on Google to get them cleaned up and fixed!  Or do it yourself, all I need is a developer to take ownership of the code.

Quoted 8 lines

I'm doing a task which is trying to merge Android patches to Ubuntu kernel and mainline, not only the Android drivers but also the ARM port code which is not in mainline.

But since Android kernel is 2.6.29 and ours or mainline is 2.6.31+, you know it needs much more effort without Google's help.

And for sure, I'm very happy to help this out.

We (Google) definitely want to get back in sync with mainline (as I've mentioned earlier in this or a related thread), and we're planning on snapping up our kernel trees to 2.6.32+ once we get past various deadlines in the near future. Obviously action speaks louder than words here, and I understand Greg's frustration at the slow pace so far and appreciate his efforts to encourage us to stop dropping the ball.

Probably the two biggest pain points for general driver support are wakelocks (which we were making some progress on getting cleaned up on the linux-pm list -- Arve will be respinning those patchsets for review again before long) and some of the gpio support. Otherwise, most of the drivers don't have a lot of dependencies on new core kernel infrastructure and many effectively stand alone. For some of the qualcomm chipsets, there is a fair bit of layering needed for functions owned by the modem or dsp cores -- smem / smd / rpc / etc.

Brian

#12 lore raw
In reply to Bryan Wu

Hi!

Quoted 7 lines
Quoted 6 lines
Quoted 2 lines

But now, it is hard for us to do that without a workable Android drivers in mainline.

Then push on Google to get them cleaned up and fixed! Or do it yourself, all I need is a developer to take ownership of the code.

Quoted 8 lines

I'm doing a task which is trying to merge Android patches to Ubuntu kernel and mainline, not only the Android drivers but also the ARM port code which is not in mainline.

But since Android kernel is 2.6.29 and ours or mainline is 2.6.31+, you know it needs much more effort without Google's help.

And for sure, I'm very happy to help this out.

I guess Greg will be happy to put android stuff back into staging if you promise to maintain it. That should be fairly low effort (hour per week?). Basically you have to respond to email, fix it when it breaks, and perhaps test compile it when -rc1 comes...

Sounds easy enough, no?
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
author
#13 lore raw
Quoted 12 lines · Pavel Machek

Hi!

Quoted 9 lines
Quoted 4 lines
Quoted 1 line

But now, it is hard for us to do that without a workable Android drivers in mainline.

Then push on Google to get them cleaned up and fixed! Or do it yourself, all I need is a developer to take ownership of the code.

I'm doing a task which is trying to merge Android patches to Ubuntu kernel and mainline, not only the Android drivers but also the ARM port code which is not in mainline.

But since Android kernel is 2.6.29 and ours or mainline is 2.6.31+, you know it needs much more effort without Google's help.

And for sure, I'm very happy to help this out.

Quoted 7 lines

I guess Greg will be happy to put android stuff back into staging if you promise to maintain it. That should be fairly low effort (hour per week?). Basically you have to respond to email, fix it when it breaks, and perhaps test compile it when -rc1 comes...

Sounds easy enough, no?
Pavel

Great, I do love to maintain it with the help from Brian Swetland and other Google folks.

Thanks a lot, Greg and Pavel.

-Bryan