Skip to contentSkip to conversation

omap3: beagle: Fix USB host port power control

PATCH In review Jarkko Nikula 4 participants 5 messages Oct 24, 2009 – Nov 9, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 omap3: beagle: Fix USB host port power control

The host port power is enabled by driving the nEN_USB_PWR low as stated in the comment. This fix is originally from Steve Sakoman <[email protected]>.

---
 arch/arm/mach-omap2/board-omap3beagle.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-omap3beagle.c +1 -1
index 6cb99f6..7ad9846 100644
@@ -162,7 +162,7 @@ static int beagle_twl_gpio_setup(struct device *dev,
 
 	/* TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, active low) */
 	gpio_request(gpio + TWL4030_GPIO_MAX, "nEN_USB_PWR");
-	gpio_direction_output(gpio + TWL4030_GPIO_MAX, 1);
+	gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
 
 	/* TWL4030_GPIO_MAX + 1 == ledB, PMU_STAT (out, active low LED) */
 	gpio_leds[2].gpio = gpio + TWL4030_GPIO_MAX + 1;
Signature · 1 line
1.6.3.3
#1 lore raw

Any comments on this, I need this on beagleboard to make ehci work.

regards,

Koen

Op 24 okt 2009, om 09:59 heeft Jarkko Nikula het volgende geschreven:

Quoted 33 lines

The host port power is enabled by driving the nEN_USB_PWR low as stated in the comment. This fix is originally from Steve Sakoman <[email protected]

Quoted 1 line

.

---
arch/arm/mach-omap2/board-omap3beagle.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-omap3beagle.c +1 -1
index 6cb99f6..7ad9846 100644
@@ -162,7 +162,7 @@ static int beagle_twl_gpio_setup(struct device  
 *dev,
 
 	/* TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, active low)  
 */
 	gpio_request(gpio + TWL4030_GPIO_MAX, "nEN_USB_PWR");
-	gpio_direction_output(gpio + TWL4030_GPIO_MAX, 1);
+	gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
 
	/* TWL4030_GPIO_MAX + 1 == ledB, PMU_STAT (out, active low LED) */
	gpio_leds[2].gpio = gpio + TWL4030_GPIO_MAX + 1;
Signature · 6 lines
1.6.3.3

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
maintainer
#2 lore raw
Quoted 1 line · Koen Kooi

Any comments on this, I need this on beagleboard to make ehci work.

Looks like a fix to me, will queue.

Tony

Quoted 47 lines

regards,

Koen

Op 24 okt 2009, om 09:59 heeft Jarkko Nikula het volgende geschreven:

Quoted 25 lines

The host port power is enabled by driving the nEN_USB_PWR low as stated in
the comment. This fix is originally from Steve Sakoman <[email protected]>.

---
arch/arm/mach-omap2/board-omap3beagle.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-omap3beagle.c +0 -0
index 6cb99f6..7ad9846 100644
@@ -162,7 +162,7 @@ static int beagle_twl_gpio_setup(struct device
 *dev,
 
 	/* TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, active

low) */

	gpio_request(gpio + TWL4030_GPIO_MAX, "nEN_USB_PWR");
arch/arm/mach-omap2/board-omap3beagle.c +1 -1
-	gpio_direction_output(gpio + TWL4030_GPIO_MAX, 1);
+	gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
Quoted 11 lines
	/* TWL4030_GPIO_MAX + 1 == ledB, PMU_STAT (out, active low LED) */
	gpio_leds[2].gpio = gpio + TWL4030_GPIO_MAX + 1;
Signature · 7 lines
1.6.3.3

--
To unsubscribe from this list: send the line "unsubscribe linux-
omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
In reply to Koen Kooi
Quoted 32 lines · Koen Kooi

Any comments on this, I need this on beagleboard to make ehci work.

regards,

Koen

Op 24 okt 2009, om 09:59 heeft Jarkko Nikula het volgende geschreven:

Quoted 24 lines

The host port power is enabled by driving the nEN_USB_PWR low as stated in
the comment. This fix is originally from Steve Sakoman <[email protected]>.

---
arch/arm/mach-omap2/board-omap3beagle.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-omap3beagle.c +0 -0
index 6cb99f6..7ad9846 100644
@@ -162,7 +162,7 @@ static int beagle_twl_gpio_setup(struct device *dev,
 
    /* TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, active

low) */

    gpio_request(gpio + TWL4030_GPIO_MAX, "nEN_USB_PWR");
arch/arm/mach-omap2/board-omap3beagle.c +1 -1
-    gpio_direction_output(gpio + TWL4030_GPIO_MAX, 1);
+    gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
Quoted 6 lines
Quoted 6 lines
    /* TWL4030_GPIO_MAX + 1 == ledB, PMU_STAT (out, active low LED) */
    gpio_leds[2].gpio = gpio + TWL4030_GPIO_MAX + 1;
Signature · 3 lines
1.6.3.3

-- 

Certainly works on 2.6.32-rc5, all EHCI devices are now enumerated. Regards
Sid.

Signature · 4 lines
Sid Boyce ... Hamradio License G3VBV, Licensed Private Pilot
Emeritus IBM/Amdahl Mainframes and Sun/Fujitsu Servers Tech Support
Specialist, Cricket Coach
Microsoft Windows Free Zone - Linux used for all Computing Tasks
maintainer
#4 lore raw

PATCH 1/1 omap3: beagle: Fix USB host port power control

In reply to Jarkko Nikula

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): 12187e35445bef725406b8f0bbf745ac5501da63

PatchWorks
http://patchwork.kernel.org/patch/55703/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=12187e35445bef725406b8f0bbf745ac5501da63