Skip to contentSkip to conversation

nfs: reorder nfs4_sequence_regs to remove 8 bytes of padding on 64 bits

PATCH New Richard Kennedy 1 participant 1 message Oct 27, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfs: reorder nfs4_sequence_regs to remove 8 bytes of padding on 64 bits

reorder nfs4_sequence_args to remove 8 bytes of padding on 64 bit builds.

The size of this structure drops to 24 bytes from 32 and reduces the text size of nfs.ko.
On my x86_64 size reports

text data bss
2.6.32-rc5 200996 8512 432 209940 33414 nfs.ko
+patch 200884 8512 432 209828 333a4 nfs.ko

----
patch against 2.6.32-rc5
only lightly tested but it seems to work both with
64 bit client -> 32 bit server & 32 bit client -> 64 bit server.

regards

Richard

include/linux/nfs_xdr.h +1 -1
index 62f63fb..8c88037 100644
@@ -170,8 +170,8 @@ struct nfs4_sequence_args {
 struct nfs4_sequence_res {
 	struct nfs4_session	*sr_session;
 	u8			sr_slotid;	/* slot used to send request */
-	unsigned long		sr_renewal_time;
 	int			sr_status;	/* sequence operation status */
+	unsigned long		sr_renewal_time;
 };
 
 struct nfs4_get_lease_time_args {