pci: remove pci_find_slot from PCI_LEGACY config description
PATCH 1/1 pci: remove pci_find_slot from PCI_LEGACY config description
Commit 3b073eda has removed pci_find_slot, so there's no point in mentioning it in the config description as one of the deprecated APIs there are enabled by PCI_LEGACY and still used by some drivers.
--- drivers/pci/Kconfig | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/pci/Kconfig +4 -4
@@ -27,10 +27,10 @@ config PCI_LEGACY default y help Say Y here if you want to include support for the deprecated - pci_find_slot() and pci_find_device() APIs. Most drivers have - been converted over to using the proper hotplug APIs, so this - option serves to include/exclude only a few drivers that are - still using this API. + pci_find_device() API. Most drivers have been converted over + to using the proper hotplug APIs, so this option serves to + include/exclude only a few drivers that are still using this + API. config PCI_DEBUG bool "PCI Debugging"
Signature · 1 line
1.6.3.3
Quoted 15 lines · Thadeu Lima de Souza Cascardo
Commit
3b073edahas removedpci_find_slot, so there's no point in mentioning it in the config description as one of the deprecated APIs there are enabled byPCI_LEGACYand still used by some drivers.Signed-off-by Thadeu Lima de Souza Cascardo <[email protected]>--- drivers/pci/Kconfig | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)drivers/pci/Kconfig +0
-0@@ -27,10 +27,10 @@ config PCI_LEGACY default y
drivers/pci/Kconfig config PCI_LEGACY · line 33
Quoted 10 lines
drivers/pci/Kconfig +4
-4help Say Y here if you want to include support for the deprecated - pci_find_slot() and pci_find_device() APIs. Most drivers have - been converted over to using the proper hotplug APIs, so this - option serves to include/exclude only a few drivers that are - still using this API. + pci_find_device() API. Most drivers have been converted over + to using the proper hotplug APIs, so this option serves to + include/exclude only a few drivers that are still using this + API.
While you are at it, how about removing the references in Documentation/PCI/pci.txt as well?
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs, Novell Inc.
Quoted 31 lines · Jiri Kosina
Quoted 15 lines · Thadeu Lima de Souza Cascardo
Commit
3b073edahas removedpci_find_slot, so there's no point in mentioning it in the config description as one of the deprecated APIs there are enabled byPCI_LEGACYand still used by some drivers.Signed-off-by Thadeu Lima de Souza Cascardo <[email protected]>--- drivers/pci/Kconfig | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)drivers/pci/Kconfig +0
-0@@ -27,10 +27,10 @@ config PCI_LEGACY default ydrivers/pci/Kconfig config PCI_LEGACY · line 33
Quoted 10 lines
drivers/pci/Kconfig +4
-4help Say Y here if you want to include support for the deprecated - pci_find_slot() and pci_find_device() APIs. Most drivers have - been converted over to using the proper hotplug APIs, so this - option serves to include/exclude only a few drivers that are - still using this API. + pci_find_device() API. Most drivers have been converted over + to using the proper hotplug APIs, so this option serves to + include/exclude only a few drivers that are still using this + API.While you are at it, how about removing the references in
Documentation/PCI/pci.txtas well?
Quoted 5 lines
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs, Novell Inc.
I've hit them. But, on a first fast look, they seemed important historically. I will take a closer look and point that if it's proper or remove them entirely as you suggest.
Regards,
Cascardo.
* Thadeu Lima de Souza Cascardo <[email protected]>:
Quoted 7 lines · Jiri Kosina
Quoted 6 lines · Thadeu Lima de Souza Cascardo
Quoted 4 lines
Commit
3b073edahas removedpci_find_slot, so there's no point in mentioning it in the config description as one of the deprecated APIs there are enabled byPCI_LEGACYand still used by some drivers.
Quoted 6 lines
Quoted 2 lines
While you are at it, how about removing the references in
Documentation/PCI/pci.txtas well?I've hit them. But, on a first fast look, they seemed important historically. I will take a closer look and point that if it's proper or remove them entirely as you suggest.
I think you can safely remove the references to the APIs that are no longer in the kernel at all, such as pci_find_slot(), etc.
On the other hand, if an interface is still there but deprecated, you can leave it in Documentation/PCI/pci.txt.
Thanks,
/ac
Jesse Barnes
AppliedQuoted 6 lines · On Fri, 30 Oct 2009 17:46:48 -0200 Thadeu Lima de Souza Cascardo…
Commit
3b073edahas removedpci_find_slot, so there's no point in mentioning it in the config description as one of the deprecated APIs there are enabled byPCI_LEGACYand still used by some drivers.Signed-off-by Thadeu Lima de Souza Cascardo <[email protected]>---
Applied to linux-next. You can do the suggested pci.txt stuff in a followup if you want.
Thanks,
Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center