Fix zoom2 defconfig build
PATCH 1/1 Fix zoom2 defconfig build
From: Manjunatha GK <[email protected]>
--- arch/arm/configs/omap_zoom2_defconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/configs/omap_zoom2_defconfig +1 -1
@@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y CONFIG_FRAME_WARN=1024 CONFIG_MAGIC_SYSRQ=y # CONFIG_UNUSED_SYMBOLS is not set -# CONFIG_DEBUG_FS is not set +CONFIG_DEBUG_FS=y # CONFIG_HEADERS_CHECK is not set CONFIG_DEBUG_KERNEL=y # CONFIG_DEBUG_SHIRQ is not set
Signature · 1 line
1.6.0.4
It looks like config issue with git-send-email on my system.
Here is Patch Description:
The CONFIG_DEBUG_FS is not enabled in omap_zoom2_defconfig which is breaking zoom2 defconfig build in linux-omap-pm(pm branch). This patch fixes build issue and kernel booting is also tested on zoom2.
Quoted 33 lines
-----Original Message-----
From: G, Manjunath Kondaiah
Sent: Monday, November 02, 2009 1:26 PM
To: [email protected]
Cc: [email protected]; G, Manjunath Kondaiah
Subject: [PATCH] [OMAP3_PM] Fix zoom2 defconfig buildFrom: Manjunatha GK <[email protected]>
Signed-off-by Manjunatha GK <[email protected]>--- arch/arm/configs/omap_zoom2_defconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/configs/omap_zoom2_defconfig +1
-1@@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y CONFIG_FRAME_WARN=1024 CONFIG_MAGIC_SYSRQ=y # CONFIG_UNUSED_SYMBOLS is not set -# CONFIG_DEBUG_FS is not set +CONFIG_DEBUG_FS=y # CONFIG_HEADERS_CHECK is not set CONFIG_DEBUG_KERNEL=y # CONFIG_DEBUG_SHIRQ is not setSignature · 1 line
1.6.0.4
Quoted 13 lines · On Mon, 2009-11-02 at 13:26 +0530, [email protected] wrote:
From: Manjunatha GK <[email protected]>
Signed-off-by Manjunatha GK <[email protected]>--- arch/arm/configs/omap_zoom2_defconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/configs/omap_zoom2_defconfig +0
-0
arch/arm/configs/omap_zoom2_defconfig CONFIG_ENABLE_MUST_CHECK=y · line 1356
Quoted 8 lines
arch/arm/configs/omap_zoom2_defconfig +1
-1@@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y CONFIG_FRAME_WARN=1024 CONFIG_MAGIC_SYSRQ=y # CONFIG_UNUSED_SYMBOLS is not set -# CONFIG_DEBUG_FS is not set +CONFIG_DEBUG_FS=y # CONFIG_HEADERS_CHECK is not set CONFIG_DEBUG_KERNEL=y # CONFIG_DEBUG_SHIRQ is not set
It is nicer to provide the build failure log. But if this is a build failure, this means there is a problem with Kconfig dependency, which should be fixed properly, not hidden.
Signature · 7 lines
Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 16 lines
arch/arm/configs/omap_zoom2_defconfig CONFIG_ENABLE_MUST_CHECK=y · line 1356
Quoted 12 lines
arch/arm/configs/omap_zoom2_defconfig +1
-1@@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y CONFIG_FRAME_WARN=1024 CONFIG_MAGIC_SYSRQ=y # CONFIG_UNUSED_SYMBOLS is not set -# CONFIG_DEBUG_FS is not set +CONFIG_DEBUG_FS=y # CONFIG_HEADERS_CHECK is not set CONFIG_DEBUG_KERNEL=y # CONFIG_DEBUG_SHIRQ is not setIt is nicer to provide the build failure log. But if this is a build failure, this means there is a problem with
Kconfigdependency, which should be fixed properly, not hidden.
Here is build failure log:
MODPOST vmlinux.o
WARNING: modpost: Found 1 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'
GEN .version CHK include/linux/compile.h UPD include/linux/compile.h CC init/version.o LD init/built-in.o LD .tmp_vmlinux1
arch/arm/mach-omap2/built-in.o: In function `omap_sram_idle':/home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:441: undefined reference to pm_dbg_regset_save' /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:452: undefined reference to pm_dbg_regset_save' arch/arm/mach-omap2/built-in.o: In function `configure_vc':/home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1226: undefined reference to pm_dbg_regset_init' /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1227: undefined reference to pm_dbg_regset_init'
make: *** [.tmp_vmlinux1] Error 1
The above two API's are under CONFIG_DEBUG_FS flag in arch/arm/mach-omap2/pm-debug.c
-Manjunath
Quoted 36 lines · Manjunath Kondaiah
Quoted 16 lines
arch/arm/configs/omap_zoom2_defconfig CONFIG_ENABLE_MUST_CHECK=y · line 1356
Quoted 12 lines
arch/arm/configs/omap_zoom2_defconfig +1
-1@@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y CONFIG_FRAME_WARN=1024 CONFIG_MAGIC_SYSRQ=y # CONFIG_UNUSED_SYMBOLS is not set -# CONFIG_DEBUG_FS is not set +CONFIG_DEBUG_FS=y # CONFIG_HEADERS_CHECK is not set CONFIG_DEBUG_KERNEL=y # CONFIG_DEBUG_SHIRQ is not setIt is nicer to provide the build failure log. But if this is a build failure, this means there is a problem with
Kconfigdependency, which should be fixed properly, not hidden.Here is build failure log:
MODPOST vmlinux.o
WARNING: modpost: Found 1 section mismatch(es).
To see full details build your kernel with:
'makeCONFIG_DEBUG_SECTION_MISMATCH=y'GEN .version CHK include/linux/compile.h UPD include/linux/compile.h CC init/version.o LD init/built-in.o LD .tmp_vmlinux1
arch/arm/mach-omap2/built-in.o: In function `omap_sram_idle':/home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:441: undefined reference topm_dbg_regset_save' /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:452: undefined reference topm_dbg_regset_save'arch/arm/mach-omap2/built-in.o: In function `configure_vc':/home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1226: undefined reference topm_dbg_regset_init' /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1227: undefined reference topm_dbg_regset_init'
make: *** [.tmp_vmlinux1] Error 1
Quoted 1 line
The above two API's are under
CONFIG_DEBUG_FSflag inarch/arm/mach-omap2/pm-debug.c
so the right fix would be to change the ifdef to something saner. Probably on the header file something like:
#if defined(CONFIG_PM_DEBUG) && defined(CONFIG_DEBUG_FS)
Signature · 1 line
balbi
Quoted 57 lines
-----Original Message-----
From: Felipe Balbi [mailto:[email protected]]
Sent: Monday, November 02, 2009 2:44 PM
To: G, Manjunath Kondaiah
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] [OMAP3_PM] Fix zoom2 defconfig buildQuoted 14 lines · Manjunath Kondaiah
Quoted 14 lines
arch/arm/configs/omap_zoom2_defconfig CONFIG_ENABLE_MUST_CHECK=y · line 1356
Quoted 12 lines
arch/arm/configs/omap_zoom2_defconfig +1
-1@@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y CONFIG_FRAME_WARN=1024 CONFIG_MAGIC_SYSRQ=y # CONFIG_UNUSED_SYMBOLS is not set -# CONFIG_DEBUG_FS is not set +CONFIG_DEBUG_FS=y # CONFIG_HEADERS_CHECK is not set CONFIG_DEBUG_KERNEL=y # CONFIG_DEBUG_SHIRQ is not setIt is nicer to provide the build failure log. But if this
is a build
Quoted 1 line
Quoted 1 line
failure, this means there is a problem with
Kconfigdependency, which
Quoted 7 lines
Quoted 1 line
should be fixed properly, not hidden.
Here is build failure log:
MODPOST vmlinux.o
WARNING: modpost: Found 1 section mismatch(es).
To see full details build your kernel with:
'makeCONFIG_DEBUG_SECTION_MISMATCH=y'Quoted 8 lines
GEN .version CHK include/linux/compile.h UPD include/linux/compile.h CC init/version.o LD init/built-in.o LD .tmp_vmlinux1
arch/arm/mach-omap2/built-in.o: In function `omap_sram_idle':
/home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:441: undefined reference to `pm_dbg_regset_save'Quoted 1 line
/home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:452: undefined reference to `pm_dbg_regset_save'Quoted 2 lines
arch/arm/mach-omap2/built-in.o: In function `configure_vc':
/home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1226: undefined reference to `pm_dbg_regset_init'Quoted 1 line
/home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1227: undefined reference to `pm_dbg_regset_init'Quoted 2 lines
make: *** [.tmp_vmlinux1] Error 1
Quoted 8 lines
Quoted 1 line
The above two API's are under
CONFIG_DEBUG_FSflag in
arch/arm/mach-omap2/pm-debug.cso the right fix would be to change the ifdef to something saner. Probably on the header file something like:
#if
defined(CONFIG_PM_DEBUG)&&defined(CONFIG_DEBUG_FS)
Thanks for review comments. I have handled the same thing in pm-debug.c. Here is code snippet. Now it compiles even without enabling CONFIG_DEBUG_FS. I will submit this patch if there are no comments for this rework.
arch/arm/mach-omap2/pm-debug.c +2 -0
@@ -625,4 +625,6 @@ arch_initcall(pm_dbg_init);#else void pm_dbg_update_time (struct powerdomain *pwrdm,int prev) {} +int pm_dbg_regset_init (int reg_set) {} +int pm_dbg_regset_save (int reg_set) {}#endif
Quoted 4 lines
Signature · 1 line
balbi
Quoted 74 lines · Manjunath Kondaiah
Quoted 56 lines
-----Original Message-----
From: Felipe Balbi [mailto:[email protected]]
Sent: Monday, November 02, 2009 2:44 PM
To: G, Manjunath Kondaiah
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] [OMAP3_PM] Fix zoom2 defconfig buildQuoted 14 lines · Manjunath Kondaiah
Quoted 14 lines
arch/arm/configs/omap_zoom2_defconfig CONFIG_ENABLE_MUST_CHECK=y · line 1356
Quoted 12 lines
arch/arm/configs/omap_zoom2_defconfig +1
-1@@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y CONFIG_FRAME_WARN=1024 CONFIG_MAGIC_SYSRQ=y # CONFIG_UNUSED_SYMBOLS is not set -# CONFIG_DEBUG_FS is not set +CONFIG_DEBUG_FS=y # CONFIG_HEADERS_CHECK is not set CONFIG_DEBUG_KERNEL=y # CONFIG_DEBUG_SHIRQ is not setIt is nicer to provide the build failure log. But if this
is a build
Quoted 1 line
Quoted 1 line
failure, this means there is a problem with
Kconfigdependency, which
Quoted 7 lines
Quoted 1 line
should be fixed properly, not hidden.
Here is build failure log:
MODPOST vmlinux.o
WARNING: modpost: Found 1 section mismatch(es).
To see full details build your kernel with:
'makeCONFIG_DEBUG_SECTION_MISMATCH=y'Quoted 8 lines
GEN .version CHK include/linux/compile.h UPD include/linux/compile.h CC init/version.o LD init/built-in.o LD .tmp_vmlinux1
arch/arm/mach-omap2/built-in.o: In function `omap_sram_idle':
/home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:441: undefined reference to `pm_dbg_regset_save'Quoted 1 line
/home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:452: undefined reference to `pm_dbg_regset_save'Quoted 2 lines
arch/arm/mach-omap2/built-in.o: In function `configure_vc':
/home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1226: undefined reference to `pm_dbg_regset_init'Quoted 1 line
/home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1227: undefined reference to `pm_dbg_regset_init'Quoted 2 lines
make: *** [.tmp_vmlinux1] Error 1
Quoted 8 lines
Quoted 1 line
The above two API's are under
CONFIG_DEBUG_FSflag in
arch/arm/mach-omap2/pm-debug.cso the right fix would be to change the ifdef to something saner. Probably on the header file something like:
#if
defined(CONFIG_PM_DEBUG)&&defined(CONFIG_DEBUG_FS)Thanks for review comments. I have handled the same thing in
pm-debug.c. Here is code snippet. Now it compiles even without enablingCONFIG_DEBUG_FS. I will submit this patch if there are no comments for this rework.arch/arm/mach-omap2/pm-debug.c +0
-0
arch/arm/mach-omap2/pm-debug.c arch_initcall(pm_dbg_init); · line 629
Quoted 5 lines
arch/arm/mach-omap2/pm-debug.c +2
-0@@ -625,4 +625,6 @@ arch_initcall(pm_dbg_init);#else void pm_dbg_update_time (struct powerdomain *pwrdm,int prev) {} +int pm_dbg_regset_init (int reg_set) {} +int pm_dbg_regset_save (int reg_set) {}
you'll get compiler warnings from these.
arch/arm/mach-omap2/pm-debug.c arch_initcall(pm_dbg_init); · line 630
Quoted 1 line
arch/arm/mach-omap2/pm-debug.c +0
-0#endif
but even there, this should be fixed in pm.h. The current PM branch has these defines already:
#define pm_dbg_regset_save(reg_set) do {} while (0); #define pm_dbg_regset_init(reg_set) do {} while (0);
It would be cleaner to fix the #ifdef there to handle the !CONFIG_DEBUG_FS case.
Kevin
Quoted 8 lines
Review
Quoted 2 lines
(quoted diff) +0
-0
b/arch/arm/mach-omap2/pm-debug.cQuoted 5 lines
index 767ebbc..3a42615 100644
arch/arm/mach-omap2/pm-debug.c +0
-0@@ -625,4 +625,6 @@ arch_initcall(pm_dbg_init);
Quoted 6 lines
arch/arm/mach-omap2/pm-debug.c arch_initcall(pm_dbg_init); · line 629
Quoted 4 lines
arch/arm/mach-omap2/pm-debug.c +2
-0#else void pm_dbg_update_time (struct powerdomain *pwrdm,int prev) {} +int pm_dbg_regset_init (int reg_set) {} +int pm_dbg_regset_save (int reg_set) {}you'll get compiler warnings from these.
Can be changed to return with value zero for these API's.
Quoted 11 lines
arch/arm/mach-omap2/pm-debug.c arch_initcall(pm_dbg_init); · line 630
Quoted 2 lines
arch/arm/mach-omap2/pm-debug.c +0
-0#endif but even there, this should be fixed in
pm.h. The current PM branch has these defines already:#define
pm_dbg_regset_save(reg_set)do {} while (0); #definepm_dbg_regset_init(reg_set)do {} while (0);It would be cleaner to fix the #ifdef there to handle the !CONFIG_DEBUG_FS case.
pm branch has else condition for CONFIG_PM_DEBUG. But, CONFIG_DEBUG_FS is not handled. As there is already similar API - pm_dbg_update_time in pm_debug.c, these API's can also fit there. More over, using !CONFIG_DEBUG_FS will add some #ifdef's in header.
-Manjunath
Quoted 22 lines · Manjunath Kondaiah
Quoted 7 lines
Review
Quoted 1 line
(quoted diff) +0
-0
b/arch/arm/mach-omap2/pm-debug.cQuoted 5 lines
index 767ebbc..3a42615 100644
arch/arm/mach-omap2/pm-debug.c +0
-0@@ -625,4 +625,6 @@ arch_initcall(pm_dbg_init);Quoted 6 lines
arch/arm/mach-omap2/pm-debug.c arch_initcall(pm_dbg_init); · line 629
Quoted 4 lines
arch/arm/mach-omap2/pm-debug.c +2
-0#else void pm_dbg_update_time (struct powerdomain *pwrdm,int prev) {} +int pm_dbg_regset_init (int reg_set) {} +int pm_dbg_regset_save (int reg_set) {}you'll get compiler warnings from these.
Can be changed to return with value zero for these API's.
Quoted 6 lines
arch/arm/mach-omap2/pm-debug.c arch_initcall(pm_dbg_init); · line 630
Quoted 2 lines
arch/arm/mach-omap2/pm-debug.c +0
-0#endif but even there, this should be fixed in
pm.h. The current PM branch has these defines already:
Quoted 8 lines
Quoted 5 lines
#define
pm_dbg_regset_save(reg_set)do {} while (0); #definepm_dbg_regset_init(reg_set)do {} while (0);It would be cleaner to fix the #ifdef there to handle the !CONFIG_DEBUG_FS case.
pm branch has else condition for
CONFIG_PM_DEBUG. But,CONFIG_DEBUG_FSis not handled.
I know, my proposal is to handle the DEBUG_FS case there also.
Quoted 3 lines
As there is already similar API -
pm_dbg_update_timeinpm_debug.c, these API's can also fit there. More over, using !CONFIG_DEBUG_FS will add some #ifdef's in header.
So handle the pm_dbg_update_time() in the header as well.
Handling them in the header will also eliminate the runtime overhead of an empty function call when DEBUG_FS is not included.
Kevin
<
Quoted 35 lines · Manjunath Kondaiah
Quoted 7 lines
Quoted 7 lines
arch/arm/configs/omap_zoom2_defconfig +0
-1@@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y CONFIG_FRAME_WARN=1024 CONFIG_MAGIC_SYSRQ=y # CONFIG_UNUSED_SYMBOLS is not set -# CONFIG_DEBUG_FS is not setQuoted 8 lines
arch/arm/configs/omap_zoom2_defconfig CONFIG_ENABLE_MUST_CHECK=y · line 1356
Quoted 4 lines
arch/arm/configs/omap_zoom2_defconfig +1
-0+CONFIG_DEBUG_FS=y # CONFIG_HEADERS_CHECK is not set CONFIG_DEBUG_KERNEL=y # CONFIG_DEBUG_SHIRQ is not setIt is nicer to provide the build failure log. But if this is a build failure, this means there is a problem with
Kconfigdependency, which should be fixed properly, not hidden.Here is build failure log:
MODPOST vmlinux.o
WARNING: modpost: Found 1 section mismatch(es).
To see full details build your kernel with:
'makeCONFIG_DEBUG_SECTION_MISMATCH=y'GEN .version CHK include/linux/compile.h UPD include/linux/compile.h CC init/version.o LD init/built-in.o LD .tmp_vmlinux1
arch/arm/mach-omap2/built-in.o: In function `omap_sram_idle':/home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:441: undefined reference topm_dbg_regset_save' /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:452: undefined reference topm_dbg_regset_save'arch/arm/mach-omap2/built-in.o: In function `configure_vc':/home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1226: undefined reference topm_dbg_regset_init' /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1227: undefined reference topm_dbg_regset_init'
make: *** [.tmp_vmlinux1] Error 1
Quoted 1 line
The above two API's are under
CONFIG_DEBUG_FSflag inarch/arm/mach-omap2/pm-debug.c
OK, but why do you send a band-aid to fix this, instead of a real fix?
Signature · 7 lines
Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html