Skip to contentSkip to conversation

ASoC ADS117x ADC driver

PATCH In review Liam Girdwood 2 participants 2 messages Nov 4, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC ADS117x ADC driver

From: Graeme Gregory <[email protected]>

This patch adds support for the TI ADS117x family of multichannel ADCs and was sponsored by Shotspotter Inc.

---
 sound/soc/codecs/Kconfig   |    5 ++
 sound/soc/codecs/Makefile  |    2 +
 sound/soc/codecs/ads117x.c |  129 ++++++++++++++++++++++++++++++++++++++++++++
 sound/soc/codecs/ads117x.h |   13 +++++
 4 files changed, 149 insertions(+), 0 deletions(-)
 create mode 100644 sound/soc/codecs/ads117x.c
 create mode 100644 sound/soc/codecs/ads117x.h
sound/soc/codecs/Kconfig +5 -0
index b54dfd0..9763062 100644
@@ -15,6 +15,7 @@ config SND_SOC_ALL_CODECS
 	select SND_SOC_AD1836 if SPI_MASTER
 	select SND_SOC_AD1938 if SPI_MASTER
 	select SND_SOC_AD1980 if SND_SOC_AC97_BUS
+	select SND_SOC_ADS117X
 	select SND_SOC_AD73311 if I2C
 	select SND_SOC_AK4104 if SPI_MASTER
 	select SND_SOC_AK4535 if I2C
@@ -97,6 +98,9 @@ config SND_SOC_AD1980
 
 config SND_SOC_AD73311
 	tristate
+	
+config SND_SOC_ADS117X
+	tristate
 
 config SND_SOC_AK4104
 	tristate
@@ -261,3 +265,4 @@ config SND_SOC_WM9713
 # Amp
 config SND_SOC_MAX9877
 	tristate
+
sound/soc/codecs/Makefile +2 -0
index 15350ec..ad12458 100644
@@ -5,6 +5,7 @@ snd-soc-ad1939-objs := ad1939.o
 snd-soc-ad1980-objs := ad1980.o
 snd-soc-ak4535-objs := ak4535.o
 snd-soc-ad73311-objs := ad73311.o
+snd-soc-ads117x-objs := ads117x.o
 snd-soc-ak4104-objs := ak4104.o
 snd-soc-ak4535-objs := ak4535.o
 snd-soc-ak4642-objs := ak4642.o
@@ -67,6 +68,7 @@ obj-$(CONFIG_SND_SOC_AD1938)	+= snd-soc-ad1938.o
 obj-$(CONFIG_SND_SOC_AD1939)	+= snd-soc-ad1939.o
 obj-$(CONFIG_SND_SOC_AD1980)	+= snd-soc-ad1980.o
 obj-$(CONFIG_SND_SOC_AD73311) += snd-soc-ad73311.o
+obj-$(CONFIG_SND_SOC_ADS117X)	+= snd-soc-ads117x.o
 obj-$(CONFIG_SND_SOC_AK4104)	+= snd-soc-ak4104.o
 obj-$(CONFIG_SND_SOC_AK4535)	+= snd-soc-ak4535.o
 obj-$(CONFIG_SND_SOC_CS4251X)	+= snd-soc-cs4251x.o
sound/soc/codecs/ads117x.c new file +129 -0

129 lines not on this page · raw message

sound/soc/codecs/ads117x.h new file +13 -0
new file mode 100644
index 0000000..dbcf50e
@@ -0,0 +1,13 @@
+/*
+ * ads117x.h  --  Driver for ads1174/8 ADC chips
+ *
+ * Copyright 2009 ShotSpotter Inc.
+ * Author: Graeme Gregory <[email protected]>
+ *
+ *  This program is free software; you can redistribute  it and/or modify it
+ *  under  the terms of  the GNU General  Public License as published by the
+ *  Free Software Foundation;  either version 2 of the  License, or (at your
+ *  option) any later version.
+ */
+extern struct snd_soc_dai ads117x_dai;
+extern struct snd_soc_codec_device soc_codec_dev_ads117x;
Signature · 1 line
1.6.3.3
#1 lore raw

sound/soc/codecs/Kconfig config SND_SOC_WM9713 · line 268

Quoted 5 lines · Liam Girdwood
sound/soc/codecs/Kconfig +1 -0
@@ -261,3 +265,4 @@ config SND_SOC_WM9713
 # Amp
 config SND_SOC_MAX9877
 	tristate
+

Extra whitespace.

sound/soc/codecs/ads117x.c line 25

Quoted 3 lines
sound/soc/codecs/ads117x.c new file +3 -0
+#define ADS117X_RATES (SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_11025 |\
+		SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_22050 |\
+		SNDRV_PCM_RATE_44100 | SNDRV_PCM_RATE_48000 )

There's SNDRV_PCM_RATE_8000_48000

sound/soc/codecs/ads117x.c line 65

Quoted 4 lines
sound/soc/codecs/ads117x.c new file +4 -0
+       ret = snd_soc_init_card(socdev);
+       if (ret < 0) {
+               printk(KERN_ERR "ads117x: failed to register card\n");
+               goto card_err;

I just last night did a patch pulling the snd_soc_init_card() stuff into the core in preparation for multi-CODEC support. Since there's no way you'd have known about that churn I'll take a look at updating the driver myself.

sound/soc/codecs/ads117x.c line 125

Quoted 11 lines
sound/soc/codecs/ads117x.c new file +11 -0
+static int __init ads117x_modinit(void)
+{
+	return snd_soc_register_dai(&ads117x_dai);
+}
+module_init(ads117x_modinit);
+
+static void __exit ads117x_exit(void)
+{
+	snd_soc_unregister_dai(&ads117x_dai);
+}
+module_exit(ads117x_exit);

This should be using standard device model stuff - I know there are some older drivers that have not yet been updated but the goal is to reduce that number, it's down to only 11 now.