Skip to contentSkip to conversation

spider-net: declare MODULE_FIRMWARE

PATCH Applied Ben Hutchings 3 participants 4 messages Nov 7, 2009 – Nov 11, 2009

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Ben Hutchings

author
#0 lore raw

PATCH 43/75 spider-net: declare MODULE_FIRMWARE

Signed-off-by Ben Hutchings <[email protected]>
---
 drivers/net/spider_net.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/spider_net.c +1 -0
index 90e663f..782910c 100644
@@ -57,6 +57,7 @@ MODULE_AUTHOR("Utz Bacher <[email protected]> and Jens Osterkamp " \
 MODULE_DESCRIPTION("Spider Southbridge Gigabit Ethernet driver");
 MODULE_LICENSE("GPL");
 MODULE_VERSION(VERSION);
+MODULE_FIRMWARE(SPIDER_NET_FIRMWARE_NAME);
 
 static int rx_descriptors = SPIDER_NET_RX_DESCRIPTORS_DEFAULT;
 static int tx_descriptors = SPIDER_NET_TX_DESCRIPTORS_DEFAULT;
Signature · 1 line
1.6.5.2
#1 lore raw
Quoted 15 lines · Ben Hutchings
Signed-off-by Ben Hutchings <[email protected]>
---
 drivers/net/spider_net.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/spider_net.c +0 -0
index 90e663f..782910c 100644
@@ -57,6 +57,7 @@ MODULE_AUTHOR("Utz Bacher <[email protected]> and

Jens Osterkamp " \ MODULE_DESCRIPTION("Spider Southbridge Gigabit Ethernet driver"); MODULE_LICENSE("GPL");
MODULE_VERSION(VERSION);
+MODULE_FIRMWARE(SPIDER_NET_FIRMWARE_NAME);

Quoted 2 lines

static int rx_descriptors = SPIDER_NET_RX_DESCRIPTORS_DEFAULT; static int tx_descriptors = SPIDER_NET_TX_DESCRIPTORS_DEFAULT;

In spider_net, the filesystem is checked for a valid firmware first, if it does not exist, the firmware is taken from the device tree (which is the default case).

Do you expect this behaviour to cause problems together with MODULE_FIRMWARE ?

Signature · 9 lines
Best regards, 

Jens Osterkamp
--------------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Erich Baier
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
maintainer
#2 lore raw

From: Jens Osterkamp <[email protected]>
Date: Mon, 9 Nov 2009 12:58:13 +0100

Quoted 5 lines

In spider_net, the filesystem is checked for a valid firmware first, if it does not exist, the firmware is taken from the device tree (which is the default case).

Do you expect this behaviour to cause problems together with MODULE_FIRMWARE ?

I think it should be OK.