Skip to contentSkip to conversation

cxacru: declare MODULE_FIRMWARE

PATCH Simon Arlott 1 participant 1 message Nov 9, 2009 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 1257631753.15927.500.camel@localhost

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 1257632395.15927.524.camel@localhost

#3 lore raw
Quoted 9 lines · Ben Hutchings
Quoted 6 lines · Simon Arlott

Review

Quoted 3 lines · Ben Hutchings

+++ b/drivers/usb/atm/cxacru.c

(quoted diff) +2 -0
+MODULE_FIRMWARE("cxacru-fw.bin");
+MODULE_FIRMWARE("cxacru-bp.bin");

It also optionally loads "cxacru-cf.bin".

I saw that, but thought it better not to list optional files.

In that case, "cxacru-bp.bin" is optional as only certain versions of the device require it.

Perhaps MODULE_FIRMWARE() should have an "optional" flag too, so that all files can be listed?

Signature · 1 line
Simon Arlott