SCSI: No longer use Scsi_Cmd typedef
cover SCSI: No longer use Scsi_Cmd typedef
Plenty of older drivers are still using Scsi_Cmd. The following patches remove its use and changes them for "struct scsi_cmnd". There is also no need for the drivers/scsi/scsi_typedefs.h file anymore since this only contains the typedef for Scsi_Cmd.
Thanks,
Davidlohr
drivers/scsi/NCR5380.c | 72 ++++++++++++++++--------------- drivers/scsi/NCR5380.h | 16 ++++---- drivers/scsi/NCR53c406a.c | 6 +- drivers/scsi/aha152x.c | 68 +++++++++++++++--------------- drivers/scsi/aha1542.c | 30 +++++++------- drivers/scsi/aha1542.h | 12 +++--- drivers/scsi/aha1740.c | 8 ++-- drivers/scsi/aha1740.h | 4 +- drivers/scsi/atari_NCR5380.c | 94 +++++++++++++++++++++--------------------- drivers/scsi/atari_scsi.c | 12 +++--- drivers/scsi/atari_scsi.h | 2 +- drivers/scsi/dtc.h | 6 +- drivers/scsi/fd_mcs.c | 10 ++-- drivers/scsi/g_NCR5380.c | 10 ++-- drivers/scsi/g_NCR5380.h | 6 +- drivers/scsi/gdth.c | 66 +++++++++++++++--------------- drivers/scsi/gdth.h | 10 ++-- drivers/scsi/gdth_proc.c | 2 +- drivers/scsi/ibmmca.c | 28 ++++++------ drivers/scsi/in2000.c | 68 +++++++++++++++--------------- drivers/scsi/in2000.h | 14 +++--- drivers/scsi/megaraid.c | 28 ++++++------ drivers/scsi/megaraid.h | 18 ++++---- drivers/scsi/nsp32_debug.c | 2 +- drivers/scsi/pas16.h | 6 +- drivers/scsi/scsi.h | 3 - drivers/scsi/sym53c416.c | 6 +- drivers/scsi/sym53c416.h | 4 +- drivers/scsi/wd7000.c | 2 +- 29 files changed, 306 insertions(+), 307 deletions(-)
Quoted 31 lines · Davidlohr Bueso
Plenty of older drivers are still using
Scsi_Cmd. The following patches remove its use and changes them for "structscsi_cmnd". There is also no need for thedrivers/scsi/scsi_typedefs.hfile anymore since this only contains the typedef forScsi_Cmd.Thanks,
Davidlohrdrivers/scsi/NCR5380.c | 72 ++++++++++++++++--------------- drivers/scsi/NCR5380.h | 16 ++++---- drivers/scsi/NCR53c406a.c | 6 +- drivers/scsi/aha152x.c | 68 +++++++++++++++--------------- drivers/scsi/aha1542.c | 30 +++++++------- drivers/scsi/aha1542.h | 12 +++--- drivers/scsi/aha1740.c | 8 ++-- drivers/scsi/aha1740.h | 4 +- drivers/scsi/atari_NCR5380.c | 94 +++++++++++++++++++++--------------------- drivers/scsi/atari_scsi.c | 12 +++--- drivers/scsi/atari_scsi.h | 2 +- drivers/scsi/dtc.h | 6 +- drivers/scsi/fd_mcs.c | 10 ++-- drivers/scsi/g_NCR5380.c | 10 ++-- drivers/scsi/g_NCR5380.h | 6 +- drivers/scsi/gdth.c | 66 +++++++++++++++--------------- drivers/scsi/gdth.h | 10 ++-- drivers/scsi/gdth_proc.c | 2 +- drivers/scsi/ibmmca.c | 28 ++++++------ drivers/scsi/in2000.c | 68 +++++++++++++++--------------- drivers/scsi/in2000.h | 14 +++--- drivers/scsi/megaraid.c | 28 ++++++------
Quoted 9 lines
drivers/scsi/megaraid.h | 18 ++++---- drivers/scsi/nsp32_debug.c | 2 +- drivers/scsi/pas16.h | 6 +- drivers/scsi/scsi.h | 3 - drivers/scsi/sym53c416.c | 6 +- drivers/scsi/sym53c416.h | 4 +- drivers/scsi/wd7000.c | 2 +- 29 files changed, 306 insertions(+), 307 deletions(-)
Thanks for doing this. What a grate relief.
One thing that I'm missing is the actual patch to remove the scsi_typedefs.h file. Is it still used?
Thanks
Boaz
Quoted 11 lines · Boaz Harrosh
Quoted 4 lines · Davidlohr Bueso
Plenty of older drivers are still using
Scsi_Cmd. The following patches remove its use and changes them for "structscsi_cmnd". There is also no need for thedrivers/scsi/scsi_typedefs.hfile anymore since this only contains the typedef forScsi_Cmd.Thanks for doing this. What a grate relief.
One thing that I'm missing is the actual patch to remove the
scsi_typedefs.hfile. Is it still used?
Oops, you're right, sending now.
Thanks,
Davidlohr
--- drivers/scsi/scsi_typedefs.h | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) delete mode 100644 drivers/scsi/scsi_typedefs.h
drivers/scsi/scsi_typedefs.h deleted +0 -2
@@ -1,2 +0,0 @@ - -typedef struct scsi_cmnd Scsi_Cmnd ;
Signature · 1 line
1.6.3.3
Quoted 1 line
Thanks for doing this. What a grate relief.
Just following up on the status of the patch.
Thanks,
Davidlohr