Skip to contentSkip to conversation

Fix null DESTDIR in depmod execution

PATCH In review Sheng Yang 2 participants 2 messages Nov 13, 2009

Subsystems (2)
KVM Kbuild
lore
Share & tools
lore

Sheng Yang

author
#0 lore raw

PATCH 1/1 Fix null DESTDIR in depmod execution

commit 52ea5897fa9fdadf0cc1a5242a23ce3dab599769 "Use DESTDIR consitently on installation" add -b ${DESTDIR} to depmod. But the DESTDIR is default NULL, then depmod would report error.

Set DESTDIR=/ as default

Signed-off-by Sheng Yang <[email protected]>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Makefile +1 -1
index f406e3d..33ddc81 100644
@@ -7,7 +7,7 @@ NONARCH_CONFIG = $(filter-out $(ARCH_CONFIG),X86 IA64)
 
 KVERREL = $(patsubst /lib/modules/%/build,%,$(KERNELDIR))
 
-DESTDIR=
+DESTDIR = /
 
 MAKEFILE_PRE = $(ARCH_DIR)/Makefile.pre
Signature · 1 line
1.5.4.5
#1 lore raw
Quoted 16 lines · Sheng Yang

commit 52ea5897fa9fdadf0cc1a5242a23ce3dab599769 "Use DESTDIR consitently on installation" add -b ${DESTDIR} to depmod. But the DESTDIR is default NULL, then depmod would report error.

Set DESTDIR=/ as default

Signed-off-by Sheng Yang <[email protected]>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Makefile +0 -0
index f406e3d..33ddc81 100644

Makefile NONARCH_CONFIG = $(filter-out $(ARCH_CONFIG),X86 IA64) · line 13

Quoted 8 lines
Makefile +1 -1
@@ -7,7 +7,7 @@ NONARCH_CONFIG = $(filter-out $(ARCH_CONFIG),X86 IA64)
 
 KVERREL = $(patsubst /lib/modules/%/build,%,$(KERNELDIR))
 
-DESTDIR=
+DESTDIR = /
 
 MAKEFILE_PRE = $(ARCH_DIR)/Makefile.pre

Yeah, thanks, applied.

But please add a prefix to your patch subjects in the future to identify the subsystem they applies to.

Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux