Network stress tests patches
PATCH 1/1 Network stress tests patches
Hello guys,
I have run into some problems with the network stress tests. I submitted a bug through the sourceforge bug tracker, but after subscribing to the mailing list I can see that it's here where all the action is. If this is not the right place, then please tell me what is the preferred way to submit bug reports and patches.
I am using ltp-full-20091031.
A lot of the TCP tests involving packet loss fail with this error:
./tcp4-uni-basic01: line 394: netem_param: unbound variable
The reason is that strict checking for undefined variables is enabled with "set -u", but the variable netem_param is not always defined before testing its contents.
The fix I have applied is to initialize the netem_param variable with an empty string.
Also if4-addr-change always fails with this error:
TBROK : Failed to set an IPv4 address at the remote host
I have found the reason to be a missing semicolon.
Best regards,
Radoslav Kolev
testcases/network/stress/tcp/uni-basic/tcp4-uni-basic01 +1 -0
@@ -379,6 +379,7 @@ esac # Make the network delay + netem_param="" if $DO_NET_DELAY ; then netem_param="delay ${NET_DELAY}ms ${NET_DELAY_DEFL}ms distribution normal" ret=`$LTP_RSH $RHOST 'PATH=/sbin:/usr/sbin:$PATH tc' qdisc add dev $rhost_ifname root netem $netem_param' ; echo $?'`
testcases/network/stress/interface/if4-addr-change +1 -1
@@ -70,7 +70,7 @@ LINK_NUM=0 # Network portion of the IPv4 address -IPV4_NETWORK=${IPV4_NETWORK-"10.0.0"} +IPV4_NETWORK=${IPV4_NETWORK:-"10.0.0"} # Netmask of for the tested network IPV4_NETMASK="255.255.255.0"
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Quoted 51 lines · Radoslav Kolev
Hello guys,
I have run into some problems with the network stress tests. I submitted a bug through the sourceforge bug tracker, but after subscribing to the mailing list I can see that it's here where all the action is. If this is not the right place, then please tell me what is the preferred way to submit bug reports and patches.
I am using ltp-full-20091031.
A lot of the TCP tests involving packet loss fail with this error:
./tcp4-uni-basic01: line 394:
netem_param: unbound variableThe reason is that strict checking for undefined variables is enabled with "set -u", but the variable
netem_paramis not always defined before testing its contents.The fix I have applied is to initialize the
netem_paramvariable with an empty string.Also if4-addr-change always fails with this error:
TBROK : Failed to set an IPv4 address at the remote host
I have found the reason to be a missing semicolon.
Best regards,
Radoslav Kolevtestcases/network/stress/tcp/uni-basic/tcp4-uni-basic01 2009-11-18 11:44:37.000000000 +0200 renamed from testcases/network/stress/tcp/uni-basic/tcp4-uni-basic01 2009-11-18 11:41:02.000000000 +0200 +0
-0@@ -379,6 +379,7 @@esac
# Make the network delay
+ netem_param=""
if $DO_NET_DELAY ; then
netem_param="delay ${NET_DELAY}ms ${NET_DELAY_DEFL}ms distribution normal"
ret=$LTP_RSH $RHOST 'PATH=/sbin:/usr/sbin:$PATH tc' qdisc add dev $rhost_ifname root netem $netem_param' ; echo $?'testcases/network/stress/interface/if4-addr-change 2009-11-18 11:56:23.000000000 +0200 renamed from testcases/network/stress/interface/if4-addr-change 2009-11-18 11:41:02.000000000 +0200 +0
-0@@ -70,7 +70,7 @@LINK_NUM=0
# Network portion of the IPv4 address
testcases/network/stress/interface/if4-addr-change 2009-11-18 11:56:23.000000000 +0200 renamed from testcases/network/stress/interface/if4-addr-change 2009-11-18 11:41:02.000000000 +0200 +1
-1-IPV4_NETWORK=${IPV4_NETWORK-"10.0.0"} +IPV4_NETWORK=${IPV4_NETWORK:-"10.0.0"}
Quoted 2 lines
# Netmask of for the tested network
IPV4_NETMASK="255.255.255.0"
Done. Please add a:
tag before your patch when you submit it next time.
Thanks!
-Garrett
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list