Skip to contentSkip to conversation

perf tools: allow cross compiling of perf tools

PATCH In review Jamie Iles 3 participants 4 messages Dec 1, 2009 – Dec 2, 2009 perf events

lore
Share & tools
lore

Jamie Iles

author
#0 lore raw

PATCH 1/1 perf tools: allow cross compiling of perf tools

For embedded systems we need to cross compile applications on the build machine. Use the CROSS_COMPILE variable like the kernel itself.

Additionally, we can't use uname to determine whether we should build for 64 bit. Use the -dumpmachine flag of GCC to determine the target arch.

Cc Peter Zijlstra <[email protected]>
---
 tools/perf/Makefile |   56 ++++++++++++++++++++++++++++++---------------------
 1 files changed, 33 insertions(+), 23 deletions(-)
tools/perf/Makefile +33 -23
index 7e190d5..aed4812 100644
@@ -150,27 +150,6 @@ PERF-VERSION-FILE: .FORCE-PERF-VERSION-FILE
 	@$(SHELL_PATH) util/PERF-VERSION-GEN
 -include PERF-VERSION-FILE
 
-uname_S := $(shell sh -c 'uname -s 2>/dev/null || echo not')
-uname_M := $(shell sh -c 'uname -m 2>/dev/null || echo not')
-uname_O := $(shell sh -c 'uname -o 2>/dev/null || echo not')
-uname_R := $(shell sh -c 'uname -r 2>/dev/null || echo not')
-uname_P := $(shell sh -c 'uname -p 2>/dev/null || echo not')
-uname_V := $(shell sh -c 'uname -v 2>/dev/null || echo not')
-
-#
-# Add -m32 for cross-builds:
-#
-ifdef NO_64BIT
-  MBITS := -m32
-else
-  #
-  # If we're on a 64-bit kernel, use -m64:
-  #
-  ifneq ($(patsubst %64,%,$(uname_M)),$(uname_M))
-    MBITS := -m64
-  endif
-endif
-
 # CFLAGS and LDFLAGS are for the users to override from the command line.
 
 #
@@ -239,8 +218,16 @@ lib = lib
 
 export prefix bindir sharedir sysconfdir
 
-CC = gcc
-AR = ar
+# CROSS_COMPILE specify the prefix used for all executables used
+# during compilation. Only gcc and related bin-utils executables
+# are prefixed with $(CROSS_COMPILE).
+# CROSS_COMPILE can be set on the command line
+# make CROSS_COMPILE=ia64-linux-
+# Alternatively CROSS_COMPILE can be set in the environment.
+# Default value for CROSS_COMPILE is not to prefix executables
+CROSS_COMPILE ?=
+CC = $(CROSS_COMPILE)gcc
+AR = $(CROSS_COMPILE)ar
 RM = rm -f
 TAR = tar
 FIND = find
@@ -252,6 +239,29 @@ PTHREAD_LIBS = -lpthread
 # explicitly what architecture to check for. Fix this up for yours..
 SPARSE_FLAGS = -D__BIG_ENDIAN__ -D__powerpc__
 
+uname_S := $(shell sh -c 'uname -s 2>/dev/null || echo not')
+uname_M := $(shell sh -c 'uname -m 2>/dev/null || echo not')
+uname_O := $(shell sh -c 'uname -o 2>/dev/null || echo not')
+uname_R := $(shell sh -c 'uname -r 2>/dev/null || echo not')
+uname_P := $(shell sh -c 'uname -p 2>/dev/null || echo not')
+uname_V := $(shell sh -c 'uname -v 2>/dev/null || echo not')
+machine := $(shell sh -c '$(CC) -dumpmachine | cut -d- -f1')
+
+#
+# Add -m32 for cross-builds:
+# Note: not all architectures have a -m32/-m64 so only define it if we
+# explicitly force to 32 bits or detect a 64 bit arch.
+#
+ifdef FORCE_32BIT
+  MBITS := -m32
+else
+  #
+  # If we're on a 64-bit kernel, use -m64:
+  #
+  ifneq ($(patsubst %64,%,$(machine)),$(machine))
+    MBITS := -m64
+  endif
+endif
 
 
 ### --- END CONFIGURATION SECTION ---
Signature · 1 line
1.6.3.3
maintainer
#1 lore raw
Quoted 7 lines · Jamie Iles

For embedded systems we need to cross compile applications on the build machine. Use the CROSS_COMPILE variable like the kernel itself.

Additionally, we can't use uname to determine whether we should build for 64 bit. Use the -dumpmachine flag of GCC to determine the target arch.

Hmm, and here I though Michael already send something similar to this.. but apparently I can't really find it

Quoted 87 lines
Cc Peter Zijlstra <[email protected]>
---
 tools/perf/Makefile |   56 ++++++++++++++++++++++++++++++---------------------
 1 files changed, 33 insertions(+), 23 deletions(-)
tools/perf/Makefile +33 -23
index 7e190d5..aed4812 100644
@@ -150,27 +150,6 @@ PERF-VERSION-FILE: .FORCE-PERF-VERSION-FILE
 	@$(SHELL_PATH) util/PERF-VERSION-GEN
 -include PERF-VERSION-FILE
 
-uname_S := $(shell sh -c 'uname -s 2>/dev/null || echo not')
-uname_M := $(shell sh -c 'uname -m 2>/dev/null || echo not')
-uname_O := $(shell sh -c 'uname -o 2>/dev/null || echo not')
-uname_R := $(shell sh -c 'uname -r 2>/dev/null || echo not')
-uname_P := $(shell sh -c 'uname -p 2>/dev/null || echo not')
-uname_V := $(shell sh -c 'uname -v 2>/dev/null || echo not')
-
-#
-# Add -m32 for cross-builds:
-#
-ifdef NO_64BIT
-  MBITS := -m32
-else
-  #
-  # If we're on a 64-bit kernel, use -m64:
-  #
-  ifneq ($(patsubst %64,%,$(uname_M)),$(uname_M))
-    MBITS := -m64
-  endif
-endif
-
 # CFLAGS and LDFLAGS are for the users to override from the command line.
 
 #
@@ -239,8 +218,16 @@ lib = lib
 
 export prefix bindir sharedir sysconfdir
 
-CC = gcc
-AR = ar
+# CROSS_COMPILE specify the prefix used for all executables used
+# during compilation. Only gcc and related bin-utils executables
+# are prefixed with $(CROSS_COMPILE).
+# CROSS_COMPILE can be set on the command line
+# make CROSS_COMPILE=ia64-linux-
+# Alternatively CROSS_COMPILE can be set in the environment.
+# Default value for CROSS_COMPILE is not to prefix executables
+CROSS_COMPILE ?=
+CC = $(CROSS_COMPILE)gcc
+AR = $(CROSS_COMPILE)ar
 RM = rm -f
 TAR = tar
 FIND = find
@@ -252,6 +239,29 @@ PTHREAD_LIBS = -lpthread
 # explicitly what architecture to check for. Fix this up for yours..
 SPARSE_FLAGS = -D__BIG_ENDIAN__ -D__powerpc__
 
+uname_S := $(shell sh -c 'uname -s 2>/dev/null || echo not')
+uname_M := $(shell sh -c 'uname -m 2>/dev/null || echo not')
+uname_O := $(shell sh -c 'uname -o 2>/dev/null || echo not')
+uname_R := $(shell sh -c 'uname -r 2>/dev/null || echo not')
+uname_P := $(shell sh -c 'uname -p 2>/dev/null || echo not')
+uname_V := $(shell sh -c 'uname -v 2>/dev/null || echo not')
+machine := $(shell sh -c '$(CC) -dumpmachine | cut -d- -f1')
+
+#
+# Add -m32 for cross-builds:
+# Note: not all architectures have a -m32/-m64 so only define it if we
+# explicitly force to 32 bits or detect a 64 bit arch.
+#
+ifdef FORCE_32BIT
+  MBITS := -m32
+else
+  #
+  # If we're on a 64-bit kernel, use -m64:
+  #
+  ifneq ($(patsubst %64,%,$(machine)),$(machine))
+    MBITS := -m64
+  endif
+endif
 
 
 ### --- END CONFIGURATION SECTION ---
maintainer
#2 lore raw
Quoted 11 lines · Peter Zijlstra
Quoted 7 lines · Jamie Iles

For embedded systems we need to cross compile applications on the build machine. Use the CROSS_COMPILE variable like the kernel itself.

Additionally, we can't use uname to determine whether we should build for 64 bit. Use the -dumpmachine flag of GCC to determine the target arch.

Hmm, and here I though Michael already send something similar to this.. but apparently I can't really find it

Ah, I'm turning senile, was looking at the wrong kernel tree.

Your patch is against something ancient too ;-)

#3 lore raw
Quoted 10 lines · Peter Zijlstra
Quoted 9 lines · Peter Zijlstra
Quoted 7 lines · Jamie Iles

For embedded systems we need to cross compile applications on the build machine. Use the CROSS_COMPILE variable like the kernel itself.

Additionally, we can't use uname to determine whether we should build for 64 bit. Use the -dumpmachine flag of GCC to determine the target arch.

Quoted 6 lines
Quoted 2 lines

Hmm, and here I though Michael already send something similar to this.. but apparently I can't really find it

Ah, I'm turning senile, was looking at the wrong kernel tree.

Your patch is against something ancient too ;-)

yep. Jamie, you can find the latest perf code at:

http://people.redhat.com/mingo/tip.git/README

mind checking it?

Thanks,

Ingo