Skip to contentSkip to conversation

atl1e: Remove redundant definitions of ethtool operations

PATCH Applied Ben Hutchings 2 participants 2 messages Dec 2, 2009 – Dec 3, 2009

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Ben Hutchings

author
#0 lore raw

PATCH 2/3 atl1e: Remove redundant definitions of ethtool operations

These functions provide the default behaviour and do not need to be set in struct ethtool_ops.

Signed-off-by Ben Hutchings <[email protected]>
---
 drivers/net/atl1e/atl1e_ethtool.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)
drivers/net/atl1e/atl1e_ethtool.c +0 -10
index b0fb725..bb15c51 100644
@@ -131,11 +131,6 @@ static int atl1e_set_settings(struct net_device *netdev,
 	return 0;
 }
 
-static u32 atl1e_get_tx_csum(struct net_device *netdev)
-{
-	return (netdev->features & NETIF_F_HW_CSUM) != 0;
-}
-
 static u32 atl1e_get_msglevel(struct net_device *netdev)
 {
 #ifdef DBG

@@ -393,13 +388,8 @@ static const struct ethtool_ops atl1e_ethtool_ops = {
 	.get_eeprom_len         = atl1e_get_eeprom_len,
 	.get_eeprom             = atl1e_get_eeprom,
 	.set_eeprom             = atl1e_set_eeprom,
-	.get_tx_csum            = atl1e_get_tx_csum,
 	.set_tx_csum            = ethtool_op_set_tx_hw_csum,
-	.get_sg                 = ethtool_op_get_sg,
 	.set_sg                 = ethtool_op_set_sg,
-#ifdef NETIF_F_TSO
-	.get_tso                = ethtool_op_get_tso,
-#endif
 	.set_tso                = ethtool_op_set_tso,
 };
Signature · 1 line
1.6.5.3