atl1e: Remove non-implementation of ethtool set_msglevel() operation
Subsystems (2)
PATCH 3/3 atl1e: Remove non-implementation of ethtool set_msglevel() operation
Unimplemented operations should not silently fail.
Signed-off-by Ben Hutchings <[email protected]>
--- drivers/net/atl1e/atl1e_ethtool.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-)
drivers/net/atl1e/atl1e_ethtool.c +0 -5
@@ -140,10 +140,6 @@ static u32 atl1e_get_msglevel(struct net_device *netdev)#endif } -static void atl1e_set_msglevel (struct net_device *netdev,u32 data) -{ -} -static int atl1e_get_regs_len (struct net_device *netdev) {return AT_REGS_LEN *sizeof (u32);
@@ -382,7 +378,6 @@ static const struct ethtool_ops atl1e_ethtool_ops = { .get_wol = atl1e_get_wol, .set_wol = atl1e_set_wol, .get_msglevel = atl1e_get_msglevel, - .set_msglevel = atl1e_set_msglevel, .nway_reset = atl1e_nway_reset, .get_link = ethtool_op_get_link, .get_eeprom_len = atl1e_get_eeprom_len,
Signature · 1 line
1.6.5.3
From: Ben Hutchings <[email protected]>
Date: Wed, 02 Dec 2009 05:10:18 +0000
Quoted 3 lines
Unimplemented operations should not silently fail.
Signed-off-by Ben Hutchings <[email protected]>
Applied.