Skip to contentSkip to conversation

make install... doesn't

LTP Paul Larson 3 participants 4 messages Dec 8, 2009 – Dec 9, 2009

lore
Share & tools
lore
#0 lore raw

Was trying to build ltp today, which sadly, seems to be a bit more complicated than it once was. The make install completed without errors, but noticed at the end that I didn't even have a testcases/bin directory! As I watched the make install output I noticed that everything in testcases was getting built with the 'all' target, but never install.

My make-foo is quite rusty, but I'm guessing that this change from changeset b2e46ed73e9601ecad1044d37a85c97ba0ca42ce (if you are following git, It was from around Nov 30 if not) seems to be a likely culprit:
-.SECONDEXPANSION:
-$(INSTALL_TARGETS) include-install lib-install: %-install:
$(abs_top_builddir)/$$*
- $(MAKE) -C $* -f "$(abs_top_srcdir)/$*/Makefile" install
+$(INSTALL_TARGETS) include-install lib-install:
+ $(MAKE) -C "$(subst -install,,$@)" \
+ -f "$(abs_top_srcdir)/$(subst -install,,$@)/Makefile"
all

Thanks,
Paul Larson

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw
Quoted 17 lines · Paul Larson

Was trying to build ltp today, which sadly, seems to be a bit more complicated than it once was. The make install completed without errors, but noticed at the end that I didn't even have a testcases/bin directory! As I watched the make install output I noticed that everything in testcases was getting built with the 'all' target, but never install.

My make-foo is quite rusty, but I'm guessing that this change from changeset b2e46ed73e9601ecad1044d37a85c97ba0ca42ce (if you are following git, It was from around Nov 30 if not) seems to be a likely culprit:
-.SECONDEXPANSION:
-$(INSTALL_TARGETS) include-install lib-install: %-install:
$(abs_top_builddir)/$$*

(quoted diff) +3 -1
-       $(MAKE) -C $* -f "$(abs_top_srcdir)/$*/Makefile" install 
+$(INSTALL_TARGETS) include-install lib-install:
+       $(MAKE) -C "$(subst -install,,$@)" \
+               -f "$(abs_top_srcdir)/$(subst -install,,$@)/Makefile"
Quoted 1 line

all

Yes... s/all/install/ was a stupid typo :(.
-Garrett

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#2 lore raw
In reply to Paul Larson

I've noticed the same. It used to be that I could easily build and run LTP, but now I build fine, but running has become an issue. I've typically ran the LTP suite against every kernel that our [my company] various project teams create; however, with the last few releases I've tended not to use it.

It used to be that when I built LTP, I could run it from the same directory, but that is no longer true. With November's release I can't run it period.

kdl

Quoted 34 lines · Paul Larson

Was trying to build ltp today, which sadly, seems to be a bit more complicated than it once was. The make install completed without errors, but noticed at the end that I didn't even have a testcases/bin directory! As I watched the make install output I noticed that everything in testcases was getting built with the 'all' target, but never install.

My make-foo is quite rusty, but I'm guessing that this change from changeset b2e46ed73e9601ecad1044d37a85c97ba0ca42ce (if you are following git, It was from around Nov 30 if not) seems to be a likely culprit:
-.SECONDEXPANSION:
-$(INSTALL_TARGETS) include-install lib-install: %-install:
$(abs_top_builddir)/$$*

(quoted diff) +3 -1
-       $(MAKE) -C $* -f "$(abs_top_srcdir)/$*/Makefile" install
+$(INSTALL_TARGETS) include-install lib-install:
+       $(MAKE) -C "$(subst -install,,$@)" \
+               -f "$(abs_top_srcdir)/$(subst -install,,$@)/Makefile"

all

Thanks,
Paul Larson

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Signature · 2 lines
K.D. Lucas
[email protected]

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#3 lore raw
Quoted 5 lines · K.D. Lucas

I've noticed the same. It used to be that I could easily build and run LTP, but now I build fine, but running has become an issue. I've typically ran the LTP suite against every kernel that our [my company] various project teams create; however, with the last few releases I've tended not to use it.

Quoted 26 lines

It used to be that when I built LTP, I could run it from the same directory, but that is no longer true. With November's release I can't run it period.

kdl

Quoted 19 lines · Paul Larson

Was trying to build ltp today, which sadly, seems to be a bit more complicated than it once was.  The make install completed without errors, but noticed at the end that I didn't even have a testcases/bin directory!  As I watched the make install output I noticed that everything in testcases was getting built with the 'all' target, but never install.

My make-foo is quite rusty, but I'm guessing that this change from changeset b2e46ed73e9601ecad1044d37a85c97ba0ca42ce (if you are following git, It was from around Nov 30 if not) seems to be a likely culprit:
-.SECONDEXPANSION:
-$(INSTALL_TARGETS) include-install lib-install: %-install:
$(abs_top_builddir)/$$*
-       $(MAKE) -C $* -f "$(abs_top_srcdir)/$*/Makefile" install +$(INSTALL_TARGETS) include-install lib-install:
+       $(MAKE) -C "$(subst -install,,$@)" \
+               -f "$(abs_top_srcdir)/$(subst -install,,$@)/Makefile" all

KD,
Please provide your development usecase requirements that the
current make system doesn't allow so I can either 1) suggest an alternative method to solve your problem, and/or 2) add needed support to enable you to do what you need to do in LTP.
Thanks!
-Garrett

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list