rpc: remove unneeded function parameter in gss_add_msg()
Subsystems (3)
PATCH 1/1 rpc: remove unneeded function parameter in gss_add_msg()
The pointer to struct gss_auth parameter in gss_add_msg is not really needed after commit 5b7ddd4a. Zap it.
Signed-off-by Suresh Jayaraman <[email protected]>
--- net/sunrpc/auth_gss/auth_gss.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
net/sunrpc/auth_gss/auth_gss.c +2 -2
@@ -304,7 +304,7 @@ __gss_find_upcall(struct rpc_inode *rpci, uid_t uid)* to that upcall instead of adding the new upcall. */ static inline struct gss_upcall_msg * -gss_add_msg (struct gss_auth *gss_auth,struct gss_upcall_msg *gss_msg) +gss_add_msg (struct gss_upcall_msg *gss_msg) {struct rpc_inode *rpci = gss_msg->inode;struct inode *inode = &rpci->vfs_inode;
@@ -445,7 +445,7 @@ gss_setup_upcall(struct rpc_clnt *clnt, struct gss_auth *gss_auth, struct rpc_cr gss_new =gss_alloc_msg (gss_auth, uid, clnt, gss_cred->gc_machine_cred);if (IS_ERR (gss_new))return gss_new; - gss_msg =gss_add_msg (gss_auth, gss_new); + gss_msg =gss_add_msg (gss_new);if (gss_msg == gss_new) {struct inode *inode = &gss_new->inode->vfs_inode;int res =rpc_queue_upcall (inode, &gss_new->msg);
Signature · 1 line
1.6.4.2
Quoted 2 lines · Suresh Jayaraman
The pointer to struct
gss_authparameter ingss_add_msgis not really needed after commit5b7ddd4a. Zap it.
Looks straightforward to me, thanks. (Assuming Trond will take it.)
--b.
Quoted 35 lines
Signed-off-by Suresh Jayaraman <[email protected]>--- net/sunrpc/auth_gss/auth_gss.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)net/sunrpc/auth_gss/auth_gss.c +2
-2@@ -304,7 +304,7 @@ __gss_find_upcall(struct rpc_inode *rpci, uid_t uid)* to that upcall instead of adding the new upcall. */ static inline struct gss_upcall_msg * -gss_add_msg (struct gss_auth *gss_auth,struct gss_upcall_msg *gss_msg) +gss_add_msg (struct gss_upcall_msg *gss_msg) {struct rpc_inode *rpci = gss_msg->inode;struct inode *inode = &rpci->vfs_inode;@@ -445,7 +445,7 @@ gss_setup_upcall(struct rpc_clnt *clnt, struct gss_auth *gss_auth, struct rpc_cr gss_new =gss_alloc_msg (gss_auth, uid, clnt, gss_cred->gc_machine_cred);if (IS_ERR (gss_new))return gss_new; - gss_msg =gss_add_msg (gss_auth, gss_new); + gss_msg =gss_add_msg (gss_new);if (gss_msg == gss_new) {struct inode *inode = &gss_new->inode->vfs_inode;int res =rpc_queue_upcall (inode, &gss_new->msg);Signature · 6 lines
1.6.4.2 -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 5 lines · J. Bruce Fields
Quoted 2 lines · Suresh Jayaraman
The pointer to struct
gss_authparameter ingss_add_msgis not really needed after commit5b7ddd4a. Zap it.Looks straightforward to me, thanks. (Assuming Trond will take it.)
Yes. I'll pick it up...
Trond