Skip to contentSkip to conversation

drivers/char/nvram: Restore #include <linux/smp_lock.h>

PATCH In review Joe Perches 2 participants 2 messages Dec 9, 2009 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/char/nvram: Restore #include <linux/smp_lock.h>

Commit 8587b33f4adee4e7614ea7f443346c3b6bb5427a removed the include, but it's still required for a different lock_kernel/unlock_kernel pair in nvram_open

Compiled: x86/defconfig

---

drivers/char/nvram.c +1 -0
index 2100a8f..3cfa0f6 100644
@@ -38,6 +38,7 @@
 #define NVRAM_VERSION	"1.3"
 
 #include <linux/module.h>
+#include <linux/smp_lock.h>
 #include <linux/nvram.h>
 
 #define PC		1
#1 lore raw
Quoted 15 lines · Joe Perches

Commit 8587b33f4adee4e7614ea7f443346c3b6bb5427a removed the include, but it's still required for a different lock_kernel/unlock_kernel pair in nvram_open

Compiled: x86/defconfig

---

drivers/char/nvram.c +0 -0
index 2100a8f..3cfa0f6 100644

drivers/char/nvram.c line 44

Quoted 7 lines
drivers/char/nvram.c +1 -0
@@ -38,6 +38,7 @@
 #define NVRAM_VERSION	"1.3"
 
 #include <linux/module.h>
+#include <linux/smp_lock.h>
 #include <linux/nvram.h>
 
 #define PC		1

I've already sent a fix for that.
See: nvram: Fix missing smp_lock.h in nvram

Thanks.