Skip to contentSkip to conversation

ps3_gelic_wireless: Fix build failure due to missing WEXT_PRIV

PATCH In review Benjamin Herrenschmidt 4 participants 8 messages Dec 18, 2009 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ps3_gelic_wireless: Fix build failure due to missing WEXT_PRIV

The option to support the old style PSK interface in the PS3 GELIC wireless drivers requires CONFIG_WEXT_PRIV to be set

---

Please send to Linus asap (or I can put it in powerpc.git) as it's breaking one of my test build configs :-)

drivers/net/Kconfig +1 -0
index e58a653..c0ecc77 100644
@@ -2358,6 +2358,7 @@ config GELIC_WIRELESS
 config GELIC_WIRELESS_OLD_PSK_INTERFACE
        bool "PS3 Wireless private PSK interface (OBSOLETE)"
        depends on GELIC_WIRELESS
+       select WEXT_PRIV
        help
           This option retains the obsolete private interface to pass
           the PSK from user space programs to the driver.  The PSK
#1 lore raw
Quoted 14 lines · On Fri, 18 Dec 2009 16:52:54 +1100 Benjamin Herrenschmidt wrote:

The option to support the old style PSK interface in the PS3 GELIC wireless drivers requires CONFIG_WEXT_PRIV to be set

---

Please send to Linus asap (or I can put it in powerpc.git) as it's breaking one of my test build configs :-)

drivers/net/Kconfig +0 -0
index e58a653..c0ecc77 100644

drivers/net/Kconfig config GELIC_WIRELESS · line 2364

Quoted 7 lines
drivers/net/Kconfig +1 -0
@@ -2358,6 +2358,7 @@ config GELIC_WIRELESS
 config GELIC_WIRELESS_OLD_PSK_INTERFACE
        bool "PS3 Wireless private PSK interface (OBSOLETE)"
        depends on GELIC_WIRELESS
+       select WEXT_PRIV
        help
           This option retains the obsolete private interface to pass
           the PSK from user space programs to the driver.  The PSK

Probably also needs
depends on WLAN
to prevent build failures.

---
~Randy

#2 lore raw

PATCH v2 1/1 ps3_gelic_wireless: Fix build failure due to missing WEXT_PRIV

From: Benjamin Herrenschmidt <[email protected]>

The option to support the old style PSK interface in the PS3 GELIC wireless drivers requires CONFIG_WEXT_PRIV to be set

---
v2: Added 'depends on WLAN'.

Please send to Linus asap (or I can put it in powerpc.git) as it's breaking one of my test build configs :-)

Just as a note, I asked Hamish to work to remove this option. No distros use it anymore, so we don't need it.

-Geoff

---
 drivers/net/Kconfig |    2 ++
 1 file changed, 2 insertions(+)
drivers/net/Kconfig +2 -0
@@ -2357,7 +2357,9 @@ config GELIC_WIRELESS
 
 config GELIC_WIRELESS_OLD_PSK_INTERFACE
        bool "PS3 Wireless private PSK interface (OBSOLETE)"
+       depends on WLAN
        depends on GELIC_WIRELESS
+       select WEXT_PRIV
        help
           This option retains the obsolete private interface to pass
           the PSK from user space programs to the driver.  The PSK
#4 lore raw
Quoted 6 lines · Johannes Berg
Quoted 5 lines · Geoff Levand

From: Benjamin Herrenschmidt <[email protected]>

The option to support the old style PSK interface in the PS3 GELIC wireless drivers requires CONFIG_WEXT_PRIV to be set

Quoted 6 lines
Quoted 4 lines

---
v2: Added 'depends on WLAN'.

Won't you want 'depends on WLAN' for GELIC_WIRELESS instead of here?

Yes, that seems correct. I'll post an update v3.

-Geoff

#7 lore raw

PATCH v3 1/1 ps3_gelic_wireless: Fix build failure due to missing WEXT_PRIV

In reply to Benjamin Herrenschmidt

From: Benjamin Herrenschmidt <[email protected]>

The option to support the old style PSK interface in the PS3 GELIC wireless drivers requires CONFIG_WEXT_PRIV to be set

---
v2: Added 'depends on WLAN'.
v3: Moved 'depends on WLAN' to GELIC_WIRELESS.

Please send to Linus asap (or I can put it in powerpc.git) as it's breaking one of my test build configs :-)

---
 drivers/net/Kconfig |    2 ++
 1 file changed, 2 insertions(+)
drivers/net/Kconfig +2 -0
@@ -2346,6 +2346,7 @@ config GELIC_NET
 
 config GELIC_WIRELESS
 	bool "PS3 Wireless support"
+	depends on WLAN
 	depends on GELIC_NET
 	select WIRELESS_EXT
 	help
@@ -2358,6 +2359,7 @@ config GELIC_WIRELESS
 config GELIC_WIRELESS_OLD_PSK_INTERFACE
        bool "PS3 Wireless private PSK interface (OBSOLETE)"
        depends on GELIC_WIRELESS
+       select WEXT_PRIV
        help
           This option retains the obsolete private interface to pass
           the PSK from user space programs to the driver.  The PSK
#6 lore raw
In reply to Randy Dunlap
Quoted 4 lines · Randy Dunlap

Probably also needs
depends on WLAN
to prevent build failures.

Yeah, GELIC_WIRELESS should probably. I'll do a separate patch next week but feel free to beat me to it.

Cheers,
Ben.

#5 lore raw
In reply to Geoff Levand
Quoted 7 lines · Geoff Levand

From: Benjamin Herrenschmidt <[email protected]>

The option to support the old style PSK interface in the PS3 GELIC wireless drivers requires CONFIG_WEXT_PRIV to be set

Quoted 8 lines

---
v2: Added 'depends on WLAN'.

Please send to Linus asap (or I can put it in powerpc.git) as it's breaking one of my test build configs :-)

Just as a note, I asked Hamish to work to remove this option. No distros use it anymore, so we don't need it.

Geoff, the depends on WLAN should be on config GELIC_WIRELESS

Cheers,
Ben.

Quoted 17 lines
(quoted diff) +0 -2
-Geoff
---
 drivers/net/Kconfig |    2 ++
 1 file changed, 2 insertions(+)
drivers/net/Kconfig +2 -0
@@ -2357,7 +2357,9 @@ config GELIC_WIRELESS
 
 config GELIC_WIRELESS_OLD_PSK_INTERFACE
        bool "PS3 Wireless private PSK interface (OBSOLETE)"
+       depends on WLAN
        depends on GELIC_WIRELESS
+       select WEXT_PRIV
        help
           This option retains the obsolete private interface to pass
           the PSK from user space programs to the driver.  The PSK