ppc: Don't use getenv_IPaddr() systems without network support
PATCH 1/1 ppc: Don't use getenv_IPaddr() systems without network support
This patch disables the usage of getenv_IPaddr() in lib_ppc/board.c on systems that don't have network support enabled.
This fixes the following compilation problem:
./MAKEALL DP405
Configuring for DP405 board...
lib_ppc/libppc.a(board.o): In function `board_init_r':/home/stefan/git/u-boot/u-boot/lib_ppc/board.c:858: undefined reference to `getenv_IPaddr'
--- lib_ppc/board.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
lib_ppc/board.c +1 -1
@@ -852,10 +852,10 @@ void board_init_r (gd_t *id, ulong dest_addr)#ifdef CONFIG_HAS_ETH5 eth_getenv_enetaddr ("eth5addr" , bd->bi_enet5addr);#endif -#endif /* CONFIG_CMD_NET */ /* IP Address */ bd->bi_ip_addr =getenv_IPaddr ("ipaddr" ); +#endif /* CONFIG_CMD_NET */ WATCHDOG_RESET ();
Signature · 1 line
1.6.6.rc4
PATCH 1/1 ppc: Don't use getenv_IPaddr() systems without network support
Hi Stefan,
thanks for fixing this issue.
Quoted 31 lines · Stefan Roese
This patch disables the usage of
getenv_IPaddr()inlib_ppc/board.con systems that don't have network support enabled.This fixes the following compilation problem:
./MAKEALL DP405
Configuring for DP405 board...
lib_ppc/libppc.a(board.o): In function `board_init_r':/home/stefan/git/u-boot/u-boot/lib_ppc/board.c:858: undefined reference to `getenv_IPaddr'Signed-off-by Stefan Roese <[email protected]>--- lib_ppc/board.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)lib_ppc/board.c +1
-1@@ -852,10 +852,10 @@ void board_init_r (gd_t *id, ulong dest_addr)#ifdef CONFIG_HAS_ETH5 eth_getenv_enetaddr ("eth5addr" , bd->bi_enet5addr);#endif -#endif /* CONFIG_CMD_NET */ /* IP Address */ bd->bi_ip_addr =getenv_IPaddr ("ipaddr" ); +#endif /* CONFIG_CMD_NET */ WATCHDOG_RESET ();
PATCH 1/1 ppc: Don't use getenv_IPaddr() systems without network support
In reply to Stefan RoeseDear Stefan Roese,
Quoted 10 lines · In message <[email protected]> you wrote:
This patch disables the usage of
getenv_IPaddr()inlib_ppc/board.con systems that don't have network support enabled.This fixes the following compilation problem:
./MAKEALL DP405
Configuring for DP405 board...
lib_ppc/libppc.a(board.o): In function `board_init_r':/home/stefan/git/u-boot/u-boot/lib_ppc/board.c:858: undefined reference to `getenv_IPaddr'
Quoted 4 lines
Signed-off-by Stefan Roese <[email protected]>--- lib_ppc/board.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Will this patch make the "bdinfo" command print a random IP address?
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You see things; and you say ``Why?'' But I dream things that never
were; and I say ``Why not?''
- George Bernard Shaw _Back to Methuselah_ (1921) pt. 1, act 1PATCH 1/1 ppc: Don't use getenv_IPaddr() systems without network support
Hi Wolfgang,
Quoted 11 lines · On Tuesday 22 December 2009 23:02:54 Wolfgang Denk wrote:
Quoted 11 lines
This patch disables the usage of
getenv_IPaddr()inlib_ppc/board.con systems that don't have network support enabled.This fixes the following compilation problem:
./MAKEALL DP405
Configuring for DP405 board...
lib_ppc/libppc.a(board.o): In function `board_init_r':/home/stefan/git/u-boot/u-boot/lib_ppc/board.c:858: undefined reference to `getenv_IPaddr'
Quoted 6 lines
Quoted 4 lines
Signed-off-by Stefan Roese <[email protected]>--- lib_ppc/board.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)Will this patch make the "bdinfo" command print a random IP address?
Maybe. Or it will be all zero's.
The first intention of this patch was to fix the recent build breakage on those boards without networking support. I'll try to cook up a patch to remove networking stuff from the bdinfo command soon.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de