Skip to contentSkip to conversation

drivers/gpu/drm/radeon: fix a couple of array index errors

PATCH Darren Jenkins 1 participant 1 message Dec 24, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

There are a couple of array overruns, and some associated confusion in the code.
This is just a wild guess at what the code should actually look like.

Coverity CID: 13305 13306

(quoted diff) +0 -0

b/drivers/gpu/drm/radeon/radeon_legacy_tv.c
index 3a12bb0..c37535a 100644

drivers/gpu/drm/radeon/radeon_legacy_tv.c +2 -0
@@ -112,6 +112,8 @@ static const uint16_t vert_timing_NTSC[] = {
 	0x1817,
 	0x21d4,
 	0x0002,
+	0x0000,
+	0x0000,
 	0
 };
 
@@ -623,9 +625,9 @@ void radeon_legacy_tv_mode_set(struct drm_encoder

*encoder,
}
flicker_removal = (tmp + 500) / 1000;

- if (flicker_removal < 3)
- flicker_removal = 3;
- for (i = 0; i < 6; ++i) {
+ if (flicker_removal < 2)
+ flicker_removal = 2;
+ for (i = 0; i < ARRAY_SIZE(SLOPE_limit); ++i) {
if (flicker_removal == SLOPE_limit[i])
break;
}

(quoted diff) +0 -0

b/drivers/gpu/drm/radeon/radeon_mode.h
index 3dcbe13..068f6ea 100644

drivers/gpu/drm/radeon/radeon_mode.h +2 -2
@@ -217,8 +217,8 @@ struct radeon_mode_info {
 
 };
 
-#define MAX_H_CODE_TIMING_LEN 32
-#define MAX_V_CODE_TIMING_LEN 32
+#define MAX_H_CODE_TIMING_LEN 16
+#define MAX_V_CODE_TIMING_LEN 16
 
 /* need to store these as reading
    back code tables is excessive */