Skip to contentSkip to conversation

drivers/gpu/drm/radeon/radeon_connectors.c: add a NULL test before dereference

PATCH Darren Jenkins 1 participant 1 message Dec 24, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

The encoder variable can be NULL in this function so I believe it should be checked before dereference.

Coverity CID: 13253

(quoted diff) +0 -0

b/drivers/gpu/drm/radeon/radeon_connectors.c
index 5eece18..3ba86fc 100644

drivers/gpu/drm/radeon/radeon_connectors.c +0 -0
@@ -603,7 +603,7 @@ static enum drm_connector_status

radeon_vga_detect(struct drm_connector *connect
ret = connector_status_connected;
}
} else {
- if (radeon_connector->dac_load_detect) {
+ if (radeon_connector->dac_load_detect && encoder) {
encoder_funcs = encoder->helper_private; ret = encoder_funcs->detect(encoder, connector);
}