Skip to contentSkip to conversation

drivers/gpu/drm/radeon/r100.c: check for invalid family

PATCH Darren Jenkins 1 participant 1 message Dec 24, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

If there is an invalid family the fw_name is NULL and causes an NULL pointer dereference.
This just adds a check for something unexpected.

Coverity CID: 13251

(quoted diff) +0 -0

b/drivers/gpu/drm/radeon/r100.c
index 84e5df7..7d5de31 100644

drivers/gpu/drm/radeon/r100.c +0 -0
@@ -584,6 +584,8 @@ static int r100_cp_init_microcode(struct

radeon_device *rdev)
(rdev->family == CHIP_RV570)) {
DRM_INFO("Loading R500 Microcode\n"); fw_name = FIRMWARE_R520;
+ } else {
+ return -EINVAL;
}

err = request_firmware(&rdev->me_fw, fw_name, &pdev->dev);