Skip to contentSkip to conversation

drm/radeon/radeon_connectors.c: add a NULL test before dereference

PATCH New Darren Jenkins 1 participant 1 message Dec 30, 2009 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/radeon/radeon_connectors.c: add a NULL test before dereference

The encoder variable can be NULL in this function so I believe it should be checked before dereference.

Coverity CID: 13253

gpu/drm/radeon/radeon_connectors.c +1 -1
index 2016156..b82ae61 100644
@@ -615,7 +615,7 @@ static enum drm_connector_status radeon_vga_detect(struct drm_connector *connect
 				ret = connector_status_connected;
 		}
 	} else {
-		if (radeon_connector->dac_load_detect) {
+		if (radeon_connector->dac_load_detect && encoder) {
 			encoder_funcs = encoder->helper_private;
 			ret = encoder_funcs->detect(encoder, connector);
 		}