Skip to contentSkip to conversation

mfd: WM835x GPIO direction register is not locked

PATCH New Mark Brown 1 participant 1 message Jan 7, 2010

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 mfd: WM835x GPIO direction register is not locked

No need to set the security key when writing to it.

---

Ideally this'd go into 2.6.33, though it's not so urgent without the gpiolib driver I just posted it's also very non-invasive.

 drivers/mfd/wm8350-core.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
drivers/mfd/wm8350-core.c +1 -2
index 8485a70..9a970bd 100644
@@ -134,8 +134,7 @@ static inline int is_reg_locked(struct wm8350 *wm8350, u8 reg)
 	    wm8350->reg_cache[WM8350_SECURITY] == WM8350_UNLOCK_KEY)
 		return 0;
 
-	if ((reg == WM8350_GPIO_CONFIGURATION_I_O) ||
-	    (reg >= WM8350_GPIO_FUNCTION_SELECT_1 &&
+	if ((reg >= WM8350_GPIO_FUNCTION_SELECT_1 &&
 	     reg <= WM8350_GPIO_FUNCTION_SELECT_4) ||
 	    (reg >= WM8350_BATTERY_CHARGER_CONTROL_1 &&
 	     reg <= WM8350_BATTERY_CHARGER_CONTROL_3))
Signature · 1 line
1.6.6