DSPBRIDGE: Use dspbridge to initialize platform data
Subsystems (3)
PATCH 6/8 DSPBRIDGE: Use dspbridge to initialize platform data
Include dspbridge compilation whenever bridge driver is selected to be compiled, either as a module or part of the kernel. This will initialize platform data specific PM functions.
--- arch/arm/mach-omap2/Makefile | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/Makefile +3 -1
@@ -75,7 +75,9 @@ obj-y += $(i2c-omap-m) $(i2c-omap-y) # Debobs obj-$(CONFIG_OMAP3_DEBOBS) += debobs.o -obj-$(CONFIG_MPU_BRIDGE) += dspbridge.o +ifneq ($(CONFIG_MPU_BRIDGE),) +obj-y += dspbridge.o +endif # Specific board support obj-$(CONFIG_MACH_OMAP_GENERIC) += board-generic.o
Signature · 1 line
1.6.2.4
Ramirez Luna, Omar had written, on 01/07/2010 07:00 PM, the following:
Quoted 3 lines
Include dspbridge compilation whenever bridge driver is selected to be compiled, either as a module or part of the kernel. This will initialize platform data specific PM functions.
?? are you intending to state that dspbridge.c can now not be a module? can you elaborate more as to why?
arch/arm/mach-omap2/Makefile obj-y += $(i2c-omap-m) $(i2c-omap-y) · line 76
Quoted 13 lines
Signed-off-by Omar Ramirez Luna <[email protected]>--- arch/arm/mach-omap2/Makefile | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)arch/arm/mach-omap2/Makefile +0
-0@@ -75,7 +75,9 @@ obj-y += $(i2c-omap-m) $(i2c-omap-y) # Debobs obj-$(CONFIG_OMAP3_DEBOBS) += debobs.o
?? I dont find this in l-o master/2.6.32.. something I am missing?
Quoted 9 lines
arch/arm/mach-omap2/Makefile +3
-1-obj-$(CONFIG_MPU_BRIDGE) += dspbridge.o +ifneq ($(CONFIG_MPU_BRIDGE),) +obj-y += dspbridge.o +endif # Specific board support obj-$(CONFIG_MACH_OMAP_GENERIC) += board-generic.o
Signature · 2 lines
Regards, Nishanth Menon
Quoted 7 lines
From: Menon, Nishanth
Ramirez Luna, Omar had written, on 01/07/2010 07:00 PM, the following:
Quoted 3 lines
Include dspbridge compilation whenever bridge driver is selected to be compiled, either as a module or part of the kernel. This will initialize platform data specific PM functions.
?? are you intending to state that
dspbridge.ccan now not be a module?
Yes, if bridge is selected it will include dspbridge as part of the kernel, leaving bridgedriver to be installed depending on selected option (module or built in)
Quoted 1 line
can you elaborate more as to why?
Lately EXPORT_SYMBOL has been removed from pm functions, bridge depends on those symbols and now that they can't be resolved at runtime (or insmod time), then dspbridge driver needs to be compiled as part of the kernel to resolve them on its platform data structure, otherwise linking will break.
Quoted 30 lines
Quoted 12 lines
Signed-off-by Omar Ramirez Luna <[email protected]>--- arch/arm/mach-omap2/Makefile | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)arch/arm/mach-omap2/Makefile +0
-0arch/arm/mach-omap2/Makefile obj-y += $(i2c-omap-m) $(i2c-omap-y) · line 76
Quoted 2 lines
arch/arm/mach-omap2/Makefile +0
-0@@ -75,7 +75,9 @@ obj-y += $(i2c-omap-m) $(i2c-omap-y) # Debobs obj-$(CONFIG_OMAP3_DEBOBS) += debobs.o?? I dont find this in l-o master/2.6.32.. something I am missing?
arch/arm/mach-omap2/Makefile obj-y += $(i2c-omap-m) $(i2c-omap-y) · line 83
Quoted 9 lines
arch/arm/mach-omap2/Makefile +3
-1-obj-$(CONFIG_MPU_BRIDGE) += dspbridge.o +ifneq ($(CONFIG_MPU_BRIDGE),) +obj-y += dspbridge.o +endif # Specific board support obj-$(CONFIG_MACH_OMAP_GENERIC) += board-generic.o--
Regards,
Nishanth Menon
Ramirez Luna, Omar had written, on 01/08/2010 10:48 AM, the following:
Quoted 6 lines
Quoted 6 lines
From: Menon, Nishanth
Ramirez Luna, Omar had written, on 01/07/2010 07:00 PM, the following:
Quoted 3 lines
Include dspbridge compilation whenever bridge driver is selected to be compiled, either as a module or part of the kernel. This will initialize platform data specific PM functions.
Quoted 7 lines
Quoted 1 line
?? are you intending to state that
dspbridge.ccan now not be a module?Yes, if bridge is selected it will include dspbridge as part of the kernel, leaving bridgedriver to be installed depending on selected option (module or built in)
Quoted 1 line
can you elaborate more as to why?
Lately
EXPORT_SYMBOLhas been removed from pm functions, bridge depends on those symbols and now that they can't be resolved at runtime (or insmod time), then dspbridge driver needs to be compiled as part of the kernel to resolve them on its platform data structure, otherwise linking will break.
might be good to know what these functions are and why they need to be exported. we could see how the community thinks about exporting those APIs. further, I thought your branch was based on l-o and not l-o pm. am I wrong?
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Signed-off-by Omar Ramirez Luna <[email protected]>--- arch/arm/mach-omap2/Makefile | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
Quoted 8 lines
Quoted 8 lines
arch/arm/mach-omap2/Makefile obj-y += $(i2c-omap-m) $(i2c-omap-y) · line 76
Quoted 7 lines
arch/arm/mach-omap2/Makefile +0
-0@@ -75,7 +75,9 @@ obj-y += $(i2c-omap-m) $(i2c-omap-y) # Debobs obj-$(CONFIG_OMAP3_DEBOBS) += debobs.o?? I dont find this in l-o master/2.6.32.. something I am missing?
You never answered this.is your patch based on PM branch?
Quoted 11 lines
Quoted 11 lines
arch/arm/mach-omap2/Makefile obj-y += $(i2c-omap-m) $(i2c-omap-y) · line 83
Quoted 7 lines
arch/arm/mach-omap2/Makefile +3
-1-obj-$(CONFIG_MPU_BRIDGE) += dspbridge.o +ifneq ($(CONFIG_MPU_BRIDGE),) +obj-y += dspbridge.o +endif # Specific board support obj-$(CONFIG_MACH_OMAP_GENERIC) += board-generic.o--
Regards,
Nishanth Menon
Signature · 2 lines
Regards, Nishanth Menon
Quoted 16 lines
From: Menon, Nishanth
Ramirez Luna, Omar had written, on 01/08/2010 10:48 AM, the following:
Quoted 9 lines
Quoted 7 lines
From: Menon, Nishanth
Ramirez Luna, Omar had written, on 01/07/2010 07:00 PM, the following:
Quoted 3 lines
Include dspbridge compilation whenever bridge driver is selected to be compiled, either as a module or part of the kernel. This will initialize platform data specific PM functions.
?? are you intending to state that
dspbridge.ccan now not be a module?Yes, if bridge is selected it will include dspbridge as part of the kernel, leaving bridgedriver to
be installed depending on selected option (module or built in)
Quoted 3 lines
Quoted 2 lines
can you elaborate more as to why?
Quoted 8 lines
Quoted 1 line
Lately
EXPORT_SYMBOLhas been removed from pm functions, bridge depends on those symbols and nowthat they can't be resolved at runtime (or insmod time), then dspbridge driver needs to be compiled as part of the kernel to resolve them on its platform data structure, otherwise linking will break.
might be good to know what these functions are and why they need to be exported. we could see how the community thinks about exporting those APIs. further, I thought your branch was based on l-o and not l-o pm. am I wrong?
Branch is based on l-o, but I'm trying to keep the less differences between l-o-pm version... as of now since DVFS doesn't exists on l-o, this problem is not shown, but bridge version based on l-o-pm has it.
Quoted 16 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Signed-off-by Omar Ramirez Luna <[email protected]>--- arch/arm/mach-omap2/Makefile | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)Quoted 8 lines
Quoted 8 lines
arch/arm/mach-omap2/Makefile obj-y += $(i2c-omap-m) $(i2c-omap-y) · line 76
Quoted 7 lines
arch/arm/mach-omap2/Makefile +0
-0@@ -75,7 +75,9 @@ obj-y += $(i2c-omap-m) $(i2c-omap-y) # Debobs obj-$(CONFIG_OMAP3_DEBOBS) += debobs.o?? I dont find this in l-o master/2.6.32.. something I am missing?
Quoted 1 line
You never answered this.is your patch based on PM branch?
Sorry, yes this version of the patch is based on PM, must have confused both versions. I'll resend master/2.6.32 which should change this reference lines...
Btw why do we have this "debobs" on l-o-pm and not on l-o?
Quoted 17 lines
Quoted 12 lines
Quoted 12 lines
arch/arm/mach-omap2/Makefile obj-y += $(i2c-omap-m) $(i2c-omap-y) · line 83
Quoted 8 lines
arch/arm/mach-omap2/Makefile +3
-1-obj-$(CONFIG_MPU_BRIDGE) += dspbridge.o +ifneq ($(CONFIG_MPU_BRIDGE),) +obj-y += dspbridge.o +endif # Specific board support obj-$(CONFIG_MACH_OMAP_GENERIC) += board-generic.o--
Regards,
Nishanth Menon--
Regards,
Nishanth Menon
Ramirez Luna, Omar had written, on 01/08/2010 11:58 AM, the following:
Quoted 17 lines
Quoted 17 lines
From: Menon, Nishanth
Ramirez Luna, Omar had written, on 01/08/2010 10:48 AM, the following:
Quoted 8 lines
Quoted 7 lines
From: Menon, Nishanth
Ramirez Luna, Omar had written, on 01/07/2010 07:00 PM, the following:
Quoted 3 lines
Include dspbridge compilation whenever bridge driver is selected to be compiled, either as a module or part of the kernel. This will initialize platform data specific PM functions.
?? are you intending to state that
dspbridge.ccan now not be a module?Yes, if bridge is selected it will include dspbridge as part of the kernel, leaving bridgedriver to
be installed depending on selected option (module or built in)
Quoted 2 lines
Quoted 1 line
can you elaborate more as to why?
Lately
EXPORT_SYMBOLhas been removed from pm functions, bridge depends on those symbols and nowthat they can't be resolved at runtime (or insmod time), then dspbridge driver needs to be compiled as part of the kernel to resolve them on its platform data structure, otherwise linking will break.
Quoted 7 lines
Quoted 4 lines
might be good to know what these functions are and why they need to be exported. we could see how the community thinks about exporting those APIs. further, I thought your branch was based on l-o and not l-o pm. am I wrong?
Branch is based on l-o, but I'm trying to keep the less differences between l-o-pm version... as of now since DVFS doesn't exists on l-o, this problem is not shown, but bridge version based on l-o-pm has it.
alright, so please keep the patch for dspbridge-pm or equivalent branch that you maintain :).
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
arch/arm/mach-omap2/Makefile obj-y += $(i2c-omap-m) $(i2c-omap-y) · line 76
Quoted 13 lines
Signed-off-by Omar Ramirez Luna <[email protected]>--- arch/arm/mach-omap2/Makefile | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)arch/arm/mach-omap2/Makefile +0
-0@@ -75,7 +75,9 @@ obj-y += $(i2c-omap-m) $(i2c-omap-y) # Debobs obj-$(CONFIG_OMAP3_DEBOBS) += debobs.o?? I dont find this in l-o master/2.6.32.. something I am missing?
Quoted 6 lines
Quoted 1 line
You never answered this.is your patch based on PM branch?
Sorry, yes this version of the patch is based on PM, must have confused both versions. I'll resend master/2.6.32 which should change this reference lines...
Btw why do we have this "debobs" on l-o-pm and not on l-o?
due to patch in pm tree:
OMAP3: Add debug observablity (debobs) Kconfig item
this is adding debug observability signals over ETK lines (which is kinda cool ;) ).
[...]
Signature · 2 lines
Regards, Nishanth Menon