drivers/acpi/power_meter.c : remove double kfree()
Subsystems (2)
PATCH 1/1 drivers/acpi/power_meter.c : remove double kfree()
resource->domain_devices can be double kfree()'d in a couple of places. Fix this by setting num_domain_devices = 0 after the kfree().
Coverity CID: 13356, 13355, 13354
Signed-off-by Darren Jenkins <[email protected]>
acpi/power_meter.c +1 -1
@@ -534,6 +534,7 @@ static void remove_domain_devices(struct acpi_power_meter_resource *resource)kfree (resource->domain_devices);kobject_put (resource->holders_dir); + resource->num_domain_devices =0 ; }static int read_domain_devices (struct acpi_power_meter_resource *resource)
@@ -740,7 +741,6 @@ skip_unsafe_cap:return res; error: -remove_domain_devices (resource);remove_attrs (resource);return res; }
Quoted 6 lines · Darren Jenkins
resource->domain_devicescan be double kfree()'d in a couple of places. Fix this by settingnum_domain_devices= 0 after thekfree().Coverity CID: 13356, 13355, 13354
Signed-off-by Darren Jenkins <[email protected]>
Thanks for catching this.
Acked-by Darrick J. Wong <[email protected]>
Quoted 23 lines
acpi/power_meter.c +1
-1@@ -534,6 +534,7 @@ static void remove_domain_devices(struct acpi_power_meter_resource *resource)kfree (resource->domain_devices);kobject_put (resource->holders_dir); + resource->num_domain_devices =0 ; }static int read_domain_devices (struct acpi_power_meter_resource *resource)@@ -740,7 +741,6 @@ skip_unsafe_cap:return res; error: -remove_domain_devices (resource);remove_attrs (resource);return res; }
applied
thanks,
Len Brown, Intel Open Source Technology Center