Skip to contentSkip to conversation

x86: Merge show_regs()

PATCH In review Brian Gerst 1 participant 2 messages Jan 13, 2010 x86

lore
Share & tools
lore

Brian Gerst

author
#0 lore raw

PATCH 1/1 x86: Merge show_regs()

Using kernel_stack_pointer() allows 32-bit and 64-bit versions to be merged. This is more correct for 64-bit, since the old %rsp is always saved on the stack.

Signed-off-by Brian Gerst <[email protected]>
---
 arch/x86/kernel/process.c    |    7 +++++++
 arch/x86/kernel/process_32.c |    6 ------
 arch/x86/kernel/process_64.c |    6 ------
 3 files changed, 7 insertions(+), 12 deletions(-)
arch/x86/kernel/process.c +7 -0
index c6ee241..cbdbbdb 100644
@@ -92,6 +92,13 @@ void exit_thread(void)
 	}
 }
 
+void show_regs(struct pt_regs *regs)
+{
+	show_registers(regs);
+	show_trace(NULL, regs, (unsigned long *)kernel_stack_pointer(regs),
+		   regs->bp);
+}
+
 void show_regs_common(void)
 {
 	const char *board, *product;
arch/x86/kernel/process_32.c +0 -6
index 37ad1e0..f6c6266 100644
@@ -174,12 +174,6 @@ void __show_regs(struct pt_regs *regs, int all)
 			d6, d7);
 }
 
-void show_regs(struct pt_regs *regs)
-{
-	show_registers(regs);
-	show_trace(NULL, regs, &regs->sp, regs->bp);
-}
-
 void release_thread(struct task_struct *dead_task)
 {
 	BUG_ON(dead_task->mm);
arch/x86/kernel/process_64.c +0 -6
index f9e0331..ff5830b 100644
@@ -211,12 +211,6 @@ void __show_regs(struct pt_regs *regs, int all)
 	printk(KERN_DEFAULT "DR3: %016lx DR6: %016lx DR7: %016lx\n", d3, d6, d7);
 }
 
-void show_regs(struct pt_regs *regs)
-{
-	show_registers(regs);
-	show_trace(NULL, regs, (void *)(regs + 1), regs->bp);
-}
-
 void release_thread(struct task_struct *dead_task)
 {
 	if (dead_task->mm) {
Signature · 1 line
1.6.5.2
author
#1 lore raw
Commit-ID:  3bef444797f7624f8fbd27f4e0334ce96a108725
Gitweb:     http://git.kernel.org/tip/3bef444797f7624f8fbd27f4e0334ce96a108725
Author:     Brian Gerst <[email protected]>
AuthorDate: Wed, 13 Jan 2010 10:45:55 -0500
Committer:  H. Peter Anvin <[email protected]>
CommitDate: Wed, 13 Jan 2010 09:23:15 -0800

x86: Merge show_regs()

Using kernel_stack_pointer() allows 32-bit and 64-bit versions to be merged. This is more correct for 64-bit, since the old %rsp is always saved on the stack.

Signed-off-by Brian Gerst <[email protected]>

LKML-Reference: <[email protected]>

Signed-off-by H. Peter Anvin <[email protected]>
---
 arch/x86/kernel/process.c    |    7 +++++++
 arch/x86/kernel/process_32.c |    6 ------
 arch/x86/kernel/process_64.c |    6 ------
 3 files changed, 7 insertions(+), 12 deletions(-)
arch/x86/kernel/process.c +7 -0
index 98c2cde..cf1e04b 100644
@@ -92,6 +92,13 @@ void exit_thread(void)
 	}
 }
 
+void show_regs(struct pt_regs *regs)
+{
+	show_registers(regs);
+	show_trace(NULL, regs, (unsigned long *)kernel_stack_pointer(regs),
+		   regs->bp);
+}
+
 void show_regs_common(void)
 {
 	const char *board, *product;
arch/x86/kernel/process_32.c +0 -6
index 9c517b5..fe6a34e 100644
@@ -174,12 +174,6 @@ void __show_regs(struct pt_regs *regs, int all)
 			d6, d7);
 }
 
-void show_regs(struct pt_regs *regs)
-{
-	show_registers(regs);
-	show_trace(NULL, regs, &regs->sp, regs->bp);
-}
-
 void release_thread(struct task_struct *dead_task)
 {
 	BUG_ON(dead_task->mm);
arch/x86/kernel/process_64.c +0 -6
index 52fbd0c..418f860 100644
@@ -211,12 +211,6 @@ void __show_regs(struct pt_regs *regs, int all)
 	printk(KERN_INFO "DR3: %016lx DR6: %016lx DR7: %016lx\n", d3, d6, d7);
 }
 
-void show_regs(struct pt_regs *regs)
-{
-	show_registers(regs);
-	show_trace(NULL, regs, (void *)(regs + 1), regs->bp);
-}
-
 void release_thread(struct task_struct *dead_task)
 {
 	if (dead_task->mm) {