s2250: Fix write_reg i2c address

PATCH New Pete Eberlein 1 participant 1 message Jan 13, 2010 Media (V4L/DVB)

Share & tools

Pete Eberlein

author

2010-01-13 23:16 UTC #0 lore raw

PATCH 1/1 s2250: Fix write_reg i2c address

The kernel i2c model uses right-aligned 7-bit i2c addresses, but the 2250 firmware uses an 8-bit address in the usb vendor request. A previous patch by Jean Delvare shifted the i2c addresses 1 bit to the right, and this patch fixes the write_reg function to shift it back before sending the vendor request.

Priority: normal

Signed-off-by Pete Eberlein <[email protected]>

linux/drivers/staging/go7007/s2250-board.c +1 -1

diff -r 3a4be7d7dabd -r 134a95c0d98b linux/drivers/staging/go7007/s2250-board.c
@@ -159,7 +159,7 @@
 	struct go7007 *go = i2c_get_adapdata(client->adapter);
 	struct go7007_usb *usb;
 	int rc;
-	int dev_addr = client->addr;
+	int dev_addr = client->addr << 1;  /* firmware wants 8-bit address */
 	u8 *buf;
 
 	if (go == NULL)