Skip to contentSkip to conversation

go7007 staging changes

PATCH In review Pete Eberlein 2 participants 3 messages Feb 12, 2010 – Feb 19, 2010 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

cover go7007 staging changes

Hello.

This series moves most of the subdevice drivers used by the go7007 driver out of the staging directory. The sony-tuner, ov7640, tw2804 and tw9903 are converted to use the v4l2_subdev API, and the wis- versions are made obsolete. The wis-saa7113 and wis-saa7115 drivers are obsolete, and don't add anything not already in the existing saa7113 and saa7115 video decoder drivers. The audio chip driver wis-uda1342 doesn't belong in

If these changes are accepted, it should be determined if the go7007 driver can be moved out of staging, or what work remains to be done.

Pete Eberlein

[PATCH 1/5] go7007: driver id cleanup
[PATCH 2/5] sony-tuner: Subdev conversion from wis-sony-tuner [PATCH 3/5] tw2804: video decoder subdev conversion [PATCH 4/5] tw9903: video decoder subdev conversion [PATCH 5/5] ov7640: sensor driver subdev conversion

 b/linux/drivers/media/common/tuners/sony-tuner.c |  695 +++++++++++++++++++++++
 b/linux/drivers/media/video/ov7640.c             |  141 ++++
 b/linux/drivers/media/video/tw2804.c             |  398 +++++++++++++
 b/linux/drivers/media/video/tw9903.c             |  370 ++++++++++++
 linux/Documentation/video4linux/CARDLIST.tuner   |    3 
 linux/drivers/media/common/tuners/Kconfig        |    8 
 linux/drivers/media/common/tuners/Makefile       |    1 
 linux/drivers/media/common/tuners/tuner-types.c  |   12 
 linux/drivers/media/video/Kconfig                |   19 
 linux/drivers/media/video/Makefile               |    3 
 linux/drivers/staging/go7007/go7007-driver.c     |   55 -
 linux/drivers/staging/go7007/go7007-priv.h       |   18 
 linux/drivers/staging/go7007/go7007-usb.c        |   30 
 linux/drivers/staging/go7007/wis-i2c.h           |   11 
 linux/drivers/staging/go7007/wis-ov7640.c        |    2 
 linux/drivers/staging/go7007/wis-sony-tuner.c    |    2 
 linux/include/media/tuner.h                      |    4 
 linux/include/media/v4l2-chip-ident.h            |    1 
 18 files changed, 1692 insertions(+), 81 deletions(-)
#1 lore raw
Quoted 10 lines · Pete Eberlein

Hello.

This series moves most of the subdevice drivers used by the go7007 driver out of the staging directory. The sony-tuner, ov7640, tw2804 and tw9903 are converted to use the v4l2_subdev API, and the wis- versions are made obsolete. The wis-saa7113 and wis-saa7115 drivers are obsolete, and don't add anything not already in the existing saa7113 and saa7115 video decoder drivers. The audio chip driver wis-uda1342 doesn't belong in

Quoted 2 lines

If these changes are accepted, it should be determined if the go7007 driver can be moved out of staging, or what work remains to be done.

Hi Pete,

Nice work! It seems that the driver is almost ready.

Please work around the comments made by the others and submit us a new version. I think you may add a patch at the end of the series, moving all those drivers to drivers/media and drivers/media/go7007.

Cheers,
Mauro

#2 lore raw
Quoted 14 lines · Mauro Carvalho Chehab
Quoted 10 lines · Pete Eberlein

Hello.

This series moves most of the subdevice drivers used by the go7007 driver out of the staging directory. The sony-tuner, ov7640, tw2804 and tw9903 are converted to use the v4l2_subdev API, and the wis- versions are made obsolete. The wis-saa7113 and wis-saa7115 drivers are obsolete, and don't add anything not already in the existing saa7113 and saa7115 video decoder drivers. The audio chip driver wis-uda1342 doesn't belong in

Quoted 2 lines

If these changes are accepted, it should be determined if the go7007 driver can be moved out of staging, or what work remains to be done.

Quoted 7 lines

Hi Pete,

Nice work! It seems that the driver is almost ready.

Please work around the comments made by the others and submit us a new version. I think you may add a patch at the end of the series, moving all those drivers to drivers/media and drivers/media/go7007.

Thanks for the feedback, Mauro. Other projects have been consuming my time, but I hope to soon resubmit the patches incorporating the comments from Hans, and adding the go7007 subdirectory. I also realized that the s2250 driver is actually two devices, one of which is tlv320aic23b, and should be using that driver instead. I also fixed up the patch for the ADS Tech DVD Xpress DX2 from Timothy Jones, and will get that submitted too.

Quoted 2 lines

Cheers,
Mauro

Pete Eberlein