Skip to contentSkip to conversation

em28xx-dvb: fix memleak in dvb_fini()

PATCH New Francesco Lavra 1 participant 1 message Feb 13, 2010 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 em28xx-dvb: fix memleak in dvb_fini()

This patch fixes a memory leak which occurs when an em28xx card with DVB extension is unplugged or its DVB extension driver is unloaded. In dvb_fini(), dev->dvb must be freed before being set to NULL, as is done in dvb_init() in case of error.

---

NOTE: this patch has already reached linux-next, but has not been requested to be pulled for 2.6.33, as it should.

drivers/media/video/em28xx/em28xx-dvb.c +1 -0
@@ -606,6 +606,7 @@ static int dvb_fini(struct em28xx *dev)
 
 	if (dev->dvb) {
 		unregister_dvb(dev->dvb);
+		kfree(dev->dvb);
 		dev->dvb = NULL;
 	}