Skip to contentSkip to conversation

fs: inode - remove 8 bytes of padding on 64bits allowing 1 more objects/slab under slub

PATCH In review Richard Kennedy 2 participants 2 messages Feb 15, 2010 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: inode - remove 8 bytes of padding on 64bits allowing 1 more objects/slab under slub

This removes 8 bytes of padding from struct inode on 64bit builds, and so allows 1 more object/slab in the inode_cache when using slub.

----
patch against 2.6.33-rc8
compiled & tested on x86_64 AMDX2

I've been running this patch for over a week with no obvious problems regards
Richard

include/linux/fs.h +1 -1
index b1bcb27..ebb1cd5 100644
@@ -729,6 +729,7 @@ struct inode {
 	uid_t			i_uid;
 	gid_t			i_gid;
 	dev_t			i_rdev;
+	unsigned int		i_blkbits;
 	u64			i_version;
 	loff_t			i_size;
 #ifdef __NEED_I_SIZE_ORDERED
@@ -738,7 +739,6 @@ struct inode {
 	struct timespec		i_mtime;
 	struct timespec		i_ctime;
 	blkcnt_t		i_blocks;
-	unsigned int		i_blkbits;
 	unsigned short          i_bytes;
 	umode_t			i_mode;
 	spinlock_t		i_lock;	/* i_blocks, i_bytes, maybe i_size */
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Richard Kennedy

This removes 8 bytes of padding from struct inode on 64bit builds, and so allows 1 more object/slab in the inode_cache when using slub.

Looks good to me.

Honza

Quoted 31 lines

----
patch against 2.6.33-rc8
compiled & tested on x86_64 AMDX2

I've been running this patch for over a week with no obvious problems regards
Richard

include/linux/fs.h +1 -1
index b1bcb27..ebb1cd5 100644
@@ -729,6 +729,7 @@ struct inode {
 	uid_t			i_uid;
 	gid_t			i_gid;
 	dev_t			i_rdev;
+	unsigned int		i_blkbits;
 	u64			i_version;
 	loff_t			i_size;
 #ifdef __NEED_I_SIZE_ORDERED
@@ -738,7 +739,6 @@ struct inode {
 	struct timespec		i_mtime;
 	struct timespec		i_ctime;
 	blkcnt_t		i_blocks;
-	unsigned int		i_blkbits;
 	unsigned short          i_bytes;
 	umode_t			i_mode;
 	spinlock_t		i_lock;	/* i_blocks, i_bytes, maybe i_size */
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR